惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

酷 壳 – CoolShell
酷 壳 – CoolShell
G
Google Developers Blog
V
V2EX
美团技术团队
H
Help Net Security
月光博客
月光博客
爱范儿
爱范儿
Engineering at Meta
Engineering at Meta
The Cloudflare Blog
U
Unit 42
大猫的无限游戏
大猫的无限游戏
Recent Announcements
Recent Announcements
A
About on SuperTechFans
博客园 - Franky
The GitHub Blog
The GitHub Blog
N
Netflix TechBlog - Medium
人人都是产品经理
人人都是产品经理
博客园 - 司徒正美
MyScale Blog
MyScale Blog
B
Blog
雷峰网
雷峰网
Y
Y Combinator Blog
云风的 BLOG
云风的 BLOG
T
The Blog of Author Tim Ferriss

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(ssh): scope tunnel port preflight to loopback (#94603...
wangwllu · 2026-06-20 · via Recent Commits to openclaw:main
1-

// Covers SSH target parsing.

2-

import { describe, expect, it } from "vitest";

3-

import { parseSshTarget } from "./ssh-tunnel.js";

1+

// Covers SSH target parsing and tunnel startup preflight behavior.

2+

import { EventEmitter } from "node:events";

3+

import net from "node:net";

4+

import { afterEach, describe, expect, it, vi } from "vitest";

5+6+

const mocks = vi.hoisted(() => ({

7+

ensurePortAvailable: vi.fn<(port: number, host?: string) => Promise<void>>(),

8+

spawn: vi.fn(),

9+

}));

10+11+

vi.mock("./ports.js", async (importOriginal) => ({

12+

...(await importOriginal<typeof import("./ports.js")>()),

13+

ensurePortAvailable: mocks.ensurePortAvailable,

14+

}));

15+16+

vi.mock("node:child_process", async (importOriginal) => ({

17+

...(await importOriginal<typeof import("node:child_process")>()),

18+

spawn: mocks.spawn,

19+

}));

20+21+

import { PortInUseError } from "./ports.js";

22+

import { parseSshTarget, startSshPortForward } from "./ssh-tunnel.js";

423524

describe("parseSshTarget", () => {

625

it("parses user@host:port targets", () => {

@@ -30,3 +49,107 @@ describe("parseSshTarget", () => {

3049

expect(parseSshTarget("-oProxyCommand=echo")).toBeNull();

3150

});

3251

});

52+53+

describe("startSshPortForward", () => {

54+

const openServers: net.Server[] = [];

55+56+

afterEach(async () => {

57+

while (openServers.length > 0) {

58+

const server = openServers.pop();

59+

await new Promise<void>((resolve) => {

60+

server?.close(() => resolve());

61+

});

62+

}

63+

mocks.ensurePortAvailable.mockReset();

64+

mocks.spawn.mockReset();

65+

});

66+67+

// Fake ssh child that, when spawned, parses the -L forward spec and starts a

68+

// real IPv4-loopback listener on the chosen local port so waitForLocalListener

69+

// resolves without launching a real ssh process.

70+

function spawnFakeSshListening() {

71+

mocks.spawn.mockImplementation((_cmd: string, args: string[]) => {

72+

const forwardSpec = args[args.indexOf("-L") + 1] ?? "";

73+

const localPort = Number(forwardSpec.split(":")[1]);

74+

const server = net.createServer();

75+

server.on("error", () => {});

76+

openServers.push(server);

77+

server.listen(localPort, "127.0.0.1");

78+79+

const child = new EventEmitter() as EventEmitter & {

80+

killed: boolean;

81+

pid: number;

82+

stderr: EventEmitter & { setEncoding: (enc: string) => void };

83+

kill: (signal?: string) => boolean;

84+

};

85+

child.killed = false;

86+

child.pid = 4242;

87+

const stderr = new EventEmitter() as EventEmitter & { setEncoding: (enc: string) => void };

88+

stderr.setEncoding = () => {};

89+

child.stderr = stderr;

90+

child.kill = (signal?: string) => {

91+

child.killed = true;

92+

queueMicrotask(() => child.emit("exit", 0, signal ?? null));

93+

return true;

94+

};

95+

return child;

96+

});

97+

}

98+99+

it("scopes the preferred-port preflight to the IPv4 loopback interface", async () => {

100+

const sentinel = new Error("stop before spawning ssh");

101+

mocks.ensurePortAvailable.mockRejectedValueOnce(sentinel);

102+103+

await expect(

104+

startSshPortForward({

105+

target: "me@example.com:2222",

106+

localPortPreferred: 43210,

107+

remotePort: 18789,

108+

timeoutMs: 250,

109+

}),

110+

).rejects.toBe(sentinel);

111+112+

expect(mocks.ensurePortAvailable).toHaveBeenCalledWith(43210, "127.0.0.1");

113+

});

114+115+

it("falls back to an ephemeral port when the preferred port is in use", async () => {

116+

// ensurePortAvailable raises the domain PortInUseError (no errno `code`),

117+

// which the catch must treat as "busy" and route to pickEphemeralPort.

118+

// Reserve a real port so pickEphemeralPort (listen(0)) cannot hand the same

119+

// number back and make the assertion flaky.

120+

const occupied = net.createServer();

121+

await new Promise<void>((resolve, reject) => {

122+

occupied.once("error", reject);

123+

occupied.listen(0, "127.0.0.1", () => {

124+

occupied.off("error", reject);

125+

resolve();

126+

});

127+

});

128+

openServers.push(occupied);

129+

const addr = occupied.address();

130+

if (!addr || typeof addr === "string") {

131+

throw new Error("failed to reserve preferred port");

132+

}

133+

const preferredPort = addr.port;

134+135+

mocks.ensurePortAvailable.mockRejectedValueOnce(new PortInUseError(preferredPort));

136+

spawnFakeSshListening();

137+138+

const tunnel = await startSshPortForward({

139+

target: "me@example.com:2222",

140+

localPortPreferred: preferredPort,

141+

remotePort: 18789,

142+

timeoutMs: 1000,

143+

});

144+145+

expect(tunnel.localPort).not.toBe(preferredPort);

146+

expect(tunnel.localPort).toBeGreaterThan(0);

147+

expect(mocks.spawn).toHaveBeenCalledWith(

148+

"/usr/bin/ssh",

149+

expect.arrayContaining(["-L", `127.0.0.1:${tunnel.localPort}:127.0.0.1:18789`]),

150+

expect.anything(),

151+

);

152+153+

await tunnel.stop();

154+

});

155+

});