惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

V
V2EX
P
Proofpoint News Feed
D
DataBreaches.Net
C
Check Point Blog
L
LangChain Blog
量子位
美团技术团队
Vercel News
Vercel News
人人都是产品经理
人人都是产品经理
N
Netflix TechBlog - Medium
V
Visual Studio Blog
Microsoft Security Blog
Microsoft Security Blog
博客园 - 【当耐特】
MongoDB | Blog
MongoDB | Blog
Cyber Security Advisories - MS-ISAC
Cyber Security Advisories - MS-ISAC
freeCodeCamp Programming Tutorials: Python, JavaScript, Git & More
Last Week in AI
Last Week in AI
The GitHub Blog
The GitHub Blog
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
U
Unit 42
腾讯CDC
M
MIT News - Artificial intelligence
Microsoft Azure Blog
Microsoft Azure Blog
Blog — PlanetScale
Blog — PlanetScale

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix: Found one reliability bug: the new Docker-daemon-una...
clawsweeper · 2026-04-30 · via Recent Commits to openclaw:main
Original file line numberDiff line numberDiff line change

@@ -101,6 +101,58 @@ describe("resolveSandboxContext", () => {

101101

expect(result).toBeNull();

102102

}, 15_000);

103103
104+

it("does not touch sandbox backends for cron or sub-agent sessions when sandbox mode is off", async () => {

105+

const backendFactory = vi.fn(async () => ({

106+

id: "test-off-backend",

107+

runtimeId: "unexpected-runtime",

108+

runtimeLabel: "Unexpected Runtime",

109+

workdir: "/workspace",

110+

buildExecSpec: async () => ({

111+

argv: ["unexpected"],

112+

env: process.env,

113+

stdinMode: "pipe-closed" as const,

114+

}),

115+

runShellCommand: async () => ({

116+

stdout: Buffer.alloc(0),

117+

stderr: Buffer.alloc(0),

118+

code: 0,

119+

}),

120+

}));

121+

const restore = registerSandboxBackend("test-off-backend", backendFactory);

122+

try {

123+

const cfg: OpenClawConfig = {

124+

agents: {

125+

defaults: {

126+

sandbox: {

127+

mode: "off",

128+

backend: "test-off-backend",

129+

scope: "session",

130+

},

131+

},

132+

},

133+

};

134+
135+

await expect(

136+

resolveSandboxContext({

137+

config: cfg,

138+

sessionKey: "agent:main:cron:job:run:uuid",

139+

workspaceDir: "/tmp/openclaw-test",

140+

}),

141+

).resolves.toBeNull();

142+

await expect(

143+

resolveSandboxContext({

144+

config: cfg,

145+

sessionKey: "agent:main:subagent:child",

146+

workspaceDir: "/tmp/openclaw-test",

147+

}),

148+

).resolves.toBeNull();

149+
150+

expect(backendFactory).not.toHaveBeenCalled();

151+

} finally {

152+

restore();

153+

}

154+

}, 15_000);

155+
104156

it("treats main session aliases as main in non-main mode", async () => {

105157

const cfg: OpenClawConfig = {

106158

session: { mainKey: "work" },

Original file line numberDiff line numberDiff line change

@@ -236,6 +236,34 @@ describe("ensureSandboxBrowser create args", () => {

236236

expect(result?.noVncUrl).toBeUndefined();

237237

});

238238
239+

it("fails before creating a browser container when Docker daemon is unavailable", async () => {

240+

dockerMocks.execDocker.mockImplementation(async (args: string[]) => {

241+

if (args[0] === "network" && args[1] === "inspect") {

242+

return { stdout: "", stderr: "", code: 0 };

243+

}

244+

if (args[0] === "image" && args[1] === "inspect") {

245+

return {

246+

stdout: "",

247+

stderr:

248+

"Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?",

249+

code: 1,

250+

};

251+

}

252+

return { stdout: "", stderr: "", code: 0 };

253+

});

254+
255+

await expect(

256+

ensureTestSandboxBrowser({

257+

scopeKey: "session:test",

258+

workspaceDir: "/tmp/workspace",

259+

agentWorkspaceDir: "/tmp/workspace",

260+

cfg: buildConfig(false),

261+

}),

262+

).rejects.toThrow("Docker daemon is not available");

263+
264+

expect(findDockerArgsCall(dockerMocks.execDocker.mock.calls, "create")).toBeUndefined();

265+

});

266+
239267

it("passes the browser SSRF policy to the sandbox bridge", async () => {

240268

await ensureTestSandboxBrowser({

241269

scopeKey: "session:test",

Original file line numberDiff line numberDiff line change

@@ -26,6 +26,7 @@ import {

2626

buildSandboxCreateArgs,

2727

dockerContainerState,

2828

execDocker,

29+

formatDockerDaemonUnavailableError,

2930

isDockerDaemonUnavailable,

3031

readDockerContainerEnvVar,

3132

readDockerContainerLabel,

@@ -132,10 +133,8 @@ async function ensureSandboxBrowserImage(image: string) {

132133

return;

133134

}

134135

const stderr = result.stderr.trim();

135-

// When Docker daemon is unavailable, silently return instead of throwing.

136-

// This allows sandbox.mode="off" sessions to start without Docker errors.

137136

if (isDockerDaemonUnavailable(stderr)) {

138-

return;

137+

throw new Error(formatDockerDaemonUnavailableError(stderr));

139138

}

140139

throw new Error(

141140

`Sandbox browser image not found: ${image}. Build it with scripts/sandbox-browser-setup.sh.`,

Original file line numberDiff line numberDiff line change

@@ -118,12 +118,14 @@ describe("ensureDockerImage", () => {

118118

]);

119119

});

120120
121-

it("returns when the Docker daemon is unavailable during image inspection", async () => {

121+

it("throws when the Docker daemon is unavailable during image inspection", async () => {

122122

spawnState.imageExists = false;

123123

spawnState.inspectError =

124124

"Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?";

125125
126-

await ensureDockerImage(DEFAULT_SANDBOX_IMAGE);

126+

await expect(ensureDockerImage(DEFAULT_SANDBOX_IMAGE)).rejects.toThrow(

127+

"Docker daemon is not available",

128+

);

127129
128130

expect(spawnState.calls).toEqual([

129131

{

Original file line numberDiff line numberDiff line change

@@ -283,7 +283,18 @@ export function isDockerDaemonUnavailable(stderr: string): boolean {

283283

return DOCKER_DAEMON_UNAVAILABLE_MARKERS.some((marker) => stderr.toLowerCase().includes(marker));

284284

}

285285
286-

async function inspectDockerImage(image: string): Promise<"exists" | "missing" | "unavailable"> {

286+

export function formatDockerDaemonUnavailableError(stderr: string): string {

287+

const detail = stderr.trim();

288+

return [

289+

"Sandbox mode requires Docker, but the Docker daemon is not available.",

290+

"Start Docker, or set `agents.defaults.sandbox.mode=off` to disable sandboxing.",

291+

detail ? `Docker said: ${detail}` : undefined,

292+

]

293+

.filter((line): line is string => Boolean(line))

294+

.join(" ");

295+

}

296+
297+

async function inspectDockerImage(image: string): Promise<"exists" | "missing"> {

287298

const result = await execDocker(["image", "inspect", image], {

288299

allowFailure: true,

289300

});

@@ -294,18 +305,15 @@ async function inspectDockerImage(image: string): Promise<"exists" | "missing" |

294305

if (stderr.toLowerCase().includes("no such image")) {

295306

return "missing";

296307

}

297-

// When Docker daemon is unavailable, treat the image as unavailable

298-

// rather than throwing. This allows sandbox.mode="off" sessions to

299-

// start without a running Docker daemon.

300308

if (isDockerDaemonUnavailable(stderr)) {

301-

return "unavailable";

309+

throw new Error(formatDockerDaemonUnavailableError(stderr));

302310

}

303311

throw new Error(`Failed to inspect sandbox image: ${stderr}`);

304312

}

305313
306314

export async function ensureDockerImage(image: string) {

307315

const imageState = await inspectDockerImage(image);

308-

if (imageState === "exists" || imageState === "unavailable") {

316+

if (imageState === "exists") {

309317

return;

310318

}

311319

if (image === DEFAULT_SANDBOX_IMAGE) {