refactor(qa): share artifact write assertion · openclaw/o...

Recent Commits to openclaw:main

vincentkoc · 2026-06-20 · via Recent Commits to openclaw:main

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,18 @@`
	`1`	`+import fs from "node:fs/promises";`
	`2`	`+import { formatErrorMessage } from "openclaw/plugin-sdk/error-runtime";`
	`3`	`+import { QaSuiteArtifactError } from "./errors.js";`
	`4`	`+`
	`5`	`+export async function assertQaSuiteArtifactWritten(`
	`6`	`+kind: "evidence" \| "report" \| "summary",`
	`7`	`+filePath: string,`
	`8`	`+) {`
	`9`	`+try {`
	`10`	`+await fs.access(filePath);`
	`11`	`+} catch (error) {`
	`12`	`+throw new QaSuiteArtifactError(`
	`13`	+`${kind}_missing`,
	`14`	+`QA suite did not produce ${kind} artifact at ${filePath}: ${formatErrorMessage(error)}`,
	`15`	`+{ cause: error },`
	`16`	`+);`
	`17`	`+}`
	`18`	`+}`

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ import {`
`12`	`12`	`type QaReportScenario,`
`13`	`13`	`} from "openclaw/plugin-sdk/qa-runtime";`
`14`	`14`	`import { fetchWithSsrFGuard } from "openclaw/plugin-sdk/ssrf-runtime";`
`15`		`-import { QaSuiteArtifactError } from "./errors.js";`
	`15`	`+import { assertQaSuiteArtifactWritten } from "./artifact-assertion.js";`
`16`	`16`	`import { buildQaSuiteEvidenceSummary, QA_EVIDENCE_FILENAME } from "./evidence-summary.js";`
`17`	`17`	`import { startQaGatewayChild, type QaCliBackendAuthMode } from "./gateway-child.js";`
`18`	`18`	`import type {`
`@@ -884,21 +884,6 @@ async function writeQaSuiteArtifacts(params: {`
`884`	`884`	`return { evidencePath, report, reportPath, summaryPath };`
`885`	`885`	`}`
`886`	`886`
`887`		`-async function assertQaSuiteArtifactWritten(`
`888`		`-kind: "evidence" \| "report" \| "summary",`
`889`		`-filePath: string,`
`890`		`-) {`
`891`		`-try {`
`892`		`-await fs.access(filePath);`
`893`		`-} catch (error) {`
`894`		`-throw new QaSuiteArtifactError(`
`895`		-`${kind}_missing`,
`896`		-`QA suite did not produce ${kind} artifact at ${filePath}: ${formatErrorMessage(error)}`,
`897`		`-{ cause: error },`
`898`		`-);`
`899`		`-}`
`900`		`-}`
`901`		`-`
`902`	`887`	`function buildQaSuiteRuntimeMetrics(params: {`
`903`	`888`	`startedAt: Date;`
`904`	`889`	`finishedAt: Date;`

Original file line number	Diff line number	Diff line change
`@@ -2,8 +2,8 @@ import { spawn } from "node:child_process";`
`2`	`2`	`import fs from "node:fs/promises";`
`3`	`3`	`import path from "node:path";`
`4`	`4`	`import { formatErrorMessage } from "openclaw/plugin-sdk/error-runtime";`
	`5`	`+import { assertQaSuiteArtifactWritten } from "./artifact-assertion.js";`
`5`	`6`	`import { isRepoRootRelativeRef, toRepoRelativePath } from "./cli-paths.js";`
`6`		`-import { QaSuiteArtifactError } from "./errors.js";`
`7`	`7`	`import {`
`8`	`8`	`buildPlaywrightEvidenceSummary,`
`9`	`9`	`buildScriptEvidenceSummary,`
`@@ -542,22 +542,10 @@ async function writeTestFileEvidenceFile(params: {`
`542`	`542`	`}): Promise<Pick<QaTestFileScenarioRunResult, "evidencePath">> {`
`543`	`543`	`const evidencePath = path.join(params.outputDir, QA_EVIDENCE_FILENAME);`
`544`	`544`	await fs.writeFile(evidencePath, `${JSON.stringify(params.evidence, null, 2)}\n`, "utf8");
`545`		`-await assertQaTestFileArtifactWritten("evidence", evidencePath);`
	`545`	`+await assertQaSuiteArtifactWritten("evidence", evidencePath);`
`546`	`546`	`return { evidencePath };`
`547`	`547`	`}`
`548`	`548`
`549`		`-async function assertQaTestFileArtifactWritten(kind: "evidence", filePath: string) {`
`550`		`-try {`
`551`		`-await fs.access(filePath);`
`552`		`-} catch (error) {`
`553`		`-throw new QaSuiteArtifactError(`
`554`		-`${kind}_missing`,
`555`		-`QA suite did not produce ${kind} artifact at ${filePath}: ${formatErrorMessage(error)}`,
`556`		`-{ cause: error },`
`557`		`-);`
`558`		`-}`
`559`		`-}`
`560`		`-`
`561`	`549`	`export async function runQaTestFileScenarios(`
`562`	`550`	`params: QaTestFileScenarioRunParams,`
`563`	`551`	`): Promise<QaTestFileScenarioRunResult> {`

此内容由惯性聚合(RSS阅读器)自动聚合整理，仅供阅读参考。原文来自 — 版权归原作者所有。

推荐订阅源

Recent Commits to openclaw:main