惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

S
SegmentFault 最新的问题
爱范儿
爱范儿
博客园 - Franky
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻
WordPress大学
WordPress大学
宝玉的分享
宝玉的分享
雷峰网
雷峰网
酷 壳 – CoolShell
酷 壳 – CoolShell
IT之家
IT之家
有赞技术团队
有赞技术团队
美团技术团队
Last Week in AI
Last Week in AI
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
大猫的无限游戏
大猫的无限游戏
The Cloudflare Blog
Jina AI
Jina AI
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
Engineering at Meta
Engineering at Meta
T
Tailwind CSS Blog
J
Java Code Geeks
Martin Fowler
Martin Fowler
I
InfoQ
小众软件
小众软件
MongoDB | Blog
MongoDB | Blog

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(discord): gate native built-in UI before owner auth ·...
adupdev · 2026-05-26 · via Recent Commits to openclaw:main

@@ -32,6 +32,8 @@ vi.mock("openclaw/plugin-sdk/agent-runtime", () => ({

32323333

let listNativeCommandSpecs: typeof import("openclaw/plugin-sdk/command-auth").listNativeCommandSpecs;

3434

let createDiscordNativeCommand: typeof import("./native-command.js").createDiscordNativeCommand;

35+

let nativeCommandTesting: typeof import("./native-command.js").testing;

36+

let resolveDiscordNativeAutocompleteAuthorized: typeof import("./native-command-auth.js").resolveDiscordNativeAutocompleteAuthorized;

3537

let createNoopThreadBindingManager: typeof import("./thread-bindings.js").createNoopThreadBindingManager;

36383739

function createNativeCommand(

@@ -116,6 +118,29 @@ function requireAutocomplete(option: CommandOption, errorMessage: string) {

116118

return autocomplete as (interaction: unknown) => Promise<unknown>;

117119

}

118120121+

function createAllowedGuildAutocompleteConfig(

122+

commands: NonNullable<OpenClawConfig["commands"]>,

123+

): OpenClawConfig {

124+

return {

125+

commands,

126+

channels: {

127+

discord: {

128+

groupPolicy: "allowlist",

129+

guilds: {

130+

"guild-1": {

131+

channels: {

132+

"channel-1": {

133+

enabled: true,

134+

requireMention: false,

135+

},

136+

},

137+

},

138+

},

139+

},

140+

},

141+

} as OpenClawConfig;

142+

}

143+119144

async function runAutocomplete(

120145

autocomplete: (interaction: unknown) => Promise<unknown>,

121146

params: {

@@ -156,10 +181,43 @@ async function runAutocomplete(

156181

return respond;

157182

}

158183184+

async function resolveAutocompleteAuthorized(params: {

185+

cfg: OpenClawConfig;

186+

userId: string;

187+

username?: string;

188+

globalName?: string;

189+

}) {

190+

return await resolveDiscordNativeAutocompleteAuthorized({

191+

cfg: params.cfg,

192+

discordConfig: params.cfg.channels?.discord ?? {},

193+

accountId: "default",

194+

interaction: {

195+

user: {

196+

id: params.userId,

197+

username: params.username ?? params.userId,

198+

globalName: params.globalName ?? params.userId,

199+

},

200+

channel: {

201+

type: ChannelType.GuildText,

202+

id: "channel-1",

203+

name: "general",

204+

},

205+

guild: { id: "guild-1" },

206+

rawData: {

207+

member: { roles: [] },

208+

},

209+

client: {},

210+

} as never,

211+

});

212+

}

213+159214

describe("createDiscordNativeCommand option wiring", () => {

160215

beforeAll(async () => {

161216

({ listNativeCommandSpecs } = await import("openclaw/plugin-sdk/command-auth"));

162-

({ createDiscordNativeCommand } = await import("./native-command.js"));

217+

({ createDiscordNativeCommand, testing: nativeCommandTesting } = await import(

218+

"./native-command.js"

219+

));

220+

({ resolveDiscordNativeAutocompleteAuthorized } = await import("./native-command-auth.js"));

163221

({ createNoopThreadBindingManager } = await import("./thread-bindings.js"));

164222

});

165223

@@ -230,6 +288,114 @@ describe("createDiscordNativeCommand option wiring", () => {

230288

expect(respond).toHaveBeenCalledWith([]);

231289

});

232290291+

it("rejects autocomplete when commands.ownerAllowFrom rejects the sender", async () => {

292+

await expect(

293+

resolveAutocompleteAuthorized({

294+

cfg: createAllowedGuildAutocompleteConfig({

295+

ownerAllowFrom: ["user:owner-user"],

296+

}),

297+

userId: "blocked-user",

298+

username: "blocked",

299+

globalName: "Blocked",

300+

}),

301+

).resolves.toBe(false);

302+

});

303+304+

it("authorizes autocomplete for commands.allowFrom users when commands.ownerAllowFrom is configured", async () => {

305+

await expect(

306+

resolveAutocompleteAuthorized({

307+

cfg: createAllowedGuildAutocompleteConfig({

308+

ownerAllowFrom: ["user:owner-user"],

309+

allowFrom: {

310+

discord: ["user:allowed-user"],

311+

},

312+

}),

313+

userId: "blocked-user",

314+

username: "blocked",

315+

globalName: "Blocked",

316+

}),

317+

).resolves.toBe(false);

318+

await expect(

319+

resolveAutocompleteAuthorized({

320+

cfg: createAllowedGuildAutocompleteConfig({

321+

ownerAllowFrom: ["user:owner-user"],

322+

allowFrom: {

323+

discord: ["user:allowed-user"],

324+

},

325+

}),

326+

userId: "allowed-user",

327+

username: "allowed",

328+

globalName: "Allowed",

329+

}),

330+

).resolves.toBe(true);

331+

});

332+333+

it("keeps plugin command autocomplete aligned with dispatch owner checks", async () => {

334+

const restoreMatchPluginCommand = nativeCommandTesting.setMatchPluginCommand((prompt) =>

335+

prompt === "/pair" ? ({ command: { name: "pair" }, args: "" } as never) : null,

336+

);

337+

try {

338+

const command = createDiscordNativeCommand({

339+

command: {

340+

name: "pair",

341+

description: "Pair",

342+

acceptsArgs: true,

343+

args: [

344+

{

345+

name: "mode",

346+

description: "Pairing mode",

347+

type: "string",

348+

preferAutocomplete: true,

349+

choices: () => [

350+

{ label: "fast", value: "fast" },

351+

{ label: "secure", value: "secure" },

352+

],

353+

},

354+

],

355+

},

356+

cfg: createAllowedGuildAutocompleteConfig({

357+

ownerAllowFrom: ["user:owner-user"],

358+

}),

359+

discordConfig: {

360+

groupPolicy: "allowlist",

361+

guilds: {

362+

"guild-1": {

363+

channels: {

364+

"channel-1": {

365+

enabled: true,

366+

requireMention: false,

367+

},

368+

},

369+

},

370+

},

371+

},

372+

accountId: "default",

373+

sessionPrefix: "discord:slash",

374+

ephemeralDefault: true,

375+

threadBindings: createNoopThreadBindingManager("default"),

376+

});

377+

const mode = requireOption(command, "mode");

378+

const autocomplete = requireAutocomplete(mode, "plugin mode option did not wire autocomplete");

379+

const respond = await runAutocomplete(autocomplete, {

380+

userId: "blocked-user",

381+

username: "blocked",

382+

globalName: "Blocked",

383+

channelType: ChannelType.GuildText,

384+

channelId: "channel-1",

385+

channelName: "general",

386+

guildId: "guild-1",

387+

focusedValue: "",

388+

});

389+390+

expect(respond).toHaveBeenCalledWith([

391+

{ name: "fast", value: "fast" },

392+

{ name: "secure", value: "secure" },

393+

]);

394+

} finally {

395+

nativeCommandTesting.setMatchPluginCommand(restoreMatchPluginCommand);

396+

}

397+

});

398+233399

it("returns no autocomplete choices outside the Discord allowlist when commands.useAccessGroups is false and commands.allowFrom is not configured", async () => {

234400

const command = createNativeCommand("think", {

235401

cfg: {