惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

T
Tailwind CSS Blog
Cyber Security Advisories - MS-ISAC
Cyber Security Advisories - MS-ISAC
雷峰网
雷峰网
量子位
有赞技术团队
有赞技术团队
阮一峰的网络日志
阮一峰的网络日志
The Cloudflare Blog
博客园 - Franky
罗磊的独立博客
宝玉的分享
宝玉的分享
博客园_首页
腾讯CDC
The GitHub Blog
The GitHub Blog
D
DataBreaches.Net
IT之家
IT之家
D
Docker
Microsoft Security Blog
Microsoft Security Blog
博客园 - 司徒正美
V
V2EX
月光博客
月光博客
N
Netflix TechBlog - Medium
爱范儿
爱范儿
I
InfoQ
P
Proofpoint News Feed

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
perf: slim slack media test imports · openclaw/openclaw@0...
steipete · 2026-04-24 · via Recent Commits to openclaw:main

@@ -1,11 +1,4 @@

1-

import * as ssrf from "openclaw/plugin-sdk/infra-runtime";

2-

import * as mediaFetch from "openclaw/plugin-sdk/media-runtime";

3-

import type { SavedMedia } from "openclaw/plugin-sdk/media-runtime";

4-

import * as mediaStore from "openclaw/plugin-sdk/media-runtime";

5-

import { logVerbose } from "openclaw/plugin-sdk/runtime-env";

6-

import { type FetchMock, withFetchPreconnect } from "openclaw/plugin-sdk/testing";

71

import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";

8-

import { mockPinnedHostnameResolution } from "../../../../src/test-helpers/ssrf.js";

92

import {

103

fetchWithSlackAuth,

114

resolveSlackAttachmentContent,

@@ -14,16 +7,84 @@ import {

147

resolveSlackThreadStarter,

158

resetSlackThreadStarterCacheForTest,

169

} from "./media.js";

17-18-

vi.mock("openclaw/plugin-sdk/runtime-env", () => ({

19-

logVerbose: vi.fn(),

20-

danger: (message: string) => message,

21-

shouldLogVerbose: () => false,

10+

import type { FetchLike, SavedMedia } from "./media.runtime.js";

11+

import * as mediaRuntime from "./media.runtime.js";

12+

import { logVerbose } from "./media.runtime.js";

13+14+

type FetchMock = (input: RequestInfo | URL, init?: RequestInit) => Promise<Response>;

15+16+

const fetchRemoteMediaMock = vi.hoisted(() =>

17+

vi.fn(

18+

async (params: {

19+

url: string;

20+

fetchImpl: FetchLike;

21+

filePathHint?: string;

22+

requestInit?: RequestInit;

23+

}) => {

24+

let response = await params.fetchImpl(params.url, {

25+

...params.requestInit,

26+

dispatcher: {},

27+

} as RequestInit & { dispatcher: unknown });

28+

if (response.status >= 300 && response.status < 400) {

29+

const location = response.headers.get("location");

30+

if (location) {

31+

const source = new URL(params.url);

32+

const redirect = new URL(location, source);

33+

const sameOrigin = redirect.origin === source.origin;

34+

response = await params.fetchImpl(redirect.toString(), {

35+

...(sameOrigin ? params.requestInit : {}),

36+

redirect: "follow",

37+

dispatcher: {},

38+

} as RequestInit & { dispatcher: unknown });

39+

}

40+

}

41+

if (response.status < 200 || response.status >= 300) {

42+

throw new Error(`fetch failed: ${response.status}`);

43+

}

44+

return {

45+

buffer: Buffer.from(await response.arrayBuffer()),

46+

contentType: response.headers.get("content-type") ?? undefined,

47+

fileName: params.filePathHint ?? new URL(params.url).pathname.split("/").at(-1),

48+

};

49+

},

50+

),

51+

);

52+

const saveMediaBufferMock = vi.hoisted(() =>

53+

vi.fn(async (_buffer: Buffer, contentType?: string) => ({

54+

id: "saved-media-id",

55+

path: "/tmp/test.bin",

56+

size: _buffer.byteLength,

57+

contentType,

58+

})),

59+

);

60+

const fetchWithRuntimeDispatcherMock = vi.hoisted(() => vi.fn());

61+

const logVerboseMock = vi.hoisted(() => vi.fn());

62+63+

vi.mock("./media.runtime.js", () => ({

64+

fetchRemoteMedia: fetchRemoteMediaMock,

65+

fetchWithRuntimeDispatcher: fetchWithRuntimeDispatcherMock,

66+

logVerbose: logVerboseMock,

67+

saveMediaBuffer: saveMediaBufferMock,

2268

}));

236970+

function withFetchPreconnect(fetchMock: ReturnType<typeof vi.fn<FetchMock>>): typeof fetch {

71+

return Object.assign(

72+

((input: RequestInfo | URL, init?: RequestInit) => fetchMock(input, init)) as typeof fetch,

73+

{ mock: fetchMock.mock },

74+

);

75+

}

76+2477

// Store original fetch

2578

const originalFetch = globalThis.fetch;

2679

let mockFetch: ReturnType<typeof vi.fn<FetchMock>>;

80+81+

beforeEach(() => {

82+

fetchRemoteMediaMock.mockClear();

83+

fetchWithRuntimeDispatcherMock.mockClear();

84+

logVerboseMock.mockClear();

85+

saveMediaBufferMock.mockClear();

86+

});

87+2788

const createSavedMedia = (filePath: string, contentType: string): SavedMedia => ({

2889

id: "saved-media-id",

2990

path: filePath,

@@ -41,7 +102,7 @@ async function expectPrivateDownloadRedirect(params: {

41102

redirectedUrl: string;

42103

secondAuthorization: string | null;

43104

}) {

44-

vi.spyOn(mediaStore, "saveMediaBuffer").mockResolvedValue(

105+

vi.spyOn(mediaRuntime, "saveMediaBuffer").mockResolvedValue(

45106

createSavedMedia("/tmp/test.jpg", "image/jpeg"),

46107

);

47108

@@ -225,7 +286,6 @@ describe("resolveSlackMedia", () => {

225286

beforeEach(() => {

226287

mockFetch = vi.fn();

227288

globalThis.fetch = mockFetch as unknown as typeof fetch;

228-

mockPinnedHostnameResolution();

229289

});

230290231291

afterEach(() => {

@@ -234,7 +294,7 @@ describe("resolveSlackMedia", () => {

234294

});

235295236296

it("prefers url_private_download over url_private", async () => {

237-

vi.spyOn(mediaStore, "saveMediaBuffer").mockResolvedValue(

297+

vi.spyOn(mediaRuntime, "saveMediaBuffer").mockResolvedValue(

238298

createSavedMedia("/tmp/test.jpg", "image/jpeg"),

239299

);

240300

@@ -313,7 +373,7 @@ describe("resolveSlackMedia", () => {

313373

});

314374315375

it("rejects HTML auth pages for non-HTML files", async () => {

316-

const saveMediaBufferMock = vi.spyOn(mediaStore, "saveMediaBuffer");

376+

const saveMediaBufferMock = vi.spyOn(mediaRuntime, "saveMediaBuffer");

317377

mockFetch.mockResolvedValueOnce(

318378

new Response("<!DOCTYPE html><html><body>login</body></html>", {

319379

status: 200,

@@ -332,7 +392,7 @@ describe("resolveSlackMedia", () => {

332392

});

333393334394

it("allows expected HTML uploads", async () => {

335-

vi.spyOn(mediaStore, "saveMediaBuffer").mockResolvedValue(

395+

vi.spyOn(mediaRuntime, "saveMediaBuffer").mockResolvedValue(

336396

createSavedMedia("/tmp/page.html", "text/html"),

337397

);

338398

mockFetch.mockResolvedValueOnce(

@@ -363,7 +423,7 @@ describe("resolveSlackMedia", () => {

363423

// video/mp4 for MP4 containers. Verify resolveSlackMedia preserves

364424

// the overridden audio/* type in its return value despite this.

365425

const saveMediaBufferMock = vi

366-

.spyOn(mediaStore, "saveMediaBuffer")

426+

.spyOn(mediaRuntime, "saveMediaBuffer")

367427

.mockResolvedValue(createSavedMedia("/tmp/voice.mp4", "video/mp4"));

368428369429

const mockResponse = new Response(Buffer.from("audio data"), {

@@ -401,7 +461,7 @@ describe("resolveSlackMedia", () => {

401461402462

it("preserves original MIME for non-voice Slack files", async () => {

403463

const saveMediaBufferMock = vi

404-

.spyOn(mediaStore, "saveMediaBuffer")

464+

.spyOn(mediaRuntime, "saveMediaBuffer")

405465

.mockResolvedValue(createSavedMedia("/tmp/video.mp4", "video/mp4"));

406466407467

const mockResponse = new Response(Buffer.from("video data"), {

@@ -434,7 +494,7 @@ describe("resolveSlackMedia", () => {

434494

});

435495436496

it("falls through to next file when first file returns error", async () => {

437-

vi.spyOn(mediaStore, "saveMediaBuffer").mockResolvedValue(

497+

vi.spyOn(mediaRuntime, "saveMediaBuffer").mockResolvedValue(

438498

createSavedMedia("/tmp/test.jpg", "image/jpeg"),

439499

);

440500

@@ -463,7 +523,7 @@ describe("resolveSlackMedia", () => {

463523

});

464524465525

it("returns all successfully downloaded files as an array", async () => {

466-

vi.spyOn(mediaStore, "saveMediaBuffer").mockImplementation(async (buffer, _contentType) => {

526+

vi.spyOn(mediaRuntime, "saveMediaBuffer").mockImplementation(async (buffer, _contentType) => {

467527

const text = Buffer.from(buffer).toString("utf8");

468528

if (text.includes("image a")) {

469529

return createSavedMedia("/tmp/a.jpg", "image/jpeg");

@@ -510,7 +570,7 @@ describe("resolveSlackMedia", () => {

510570511571

it("caps downloads to 8 files for large multi-attachment messages", async () => {

512572

const saveMediaBufferMock = vi

513-

.spyOn(mediaStore, "saveMediaBuffer")

573+

.spyOn(mediaRuntime, "saveMediaBuffer")

514574

.mockResolvedValue(createSavedMedia("/tmp/x.jpg", "image/jpeg"));

515575516576

mockFetch.mockImplementation(async () => {

@@ -539,14 +599,14 @@ describe("resolveSlackMedia", () => {

539599

});

540600541601

it("routes dispatcher-backed Slack media requests through runtime fetch", async () => {

542-

vi.spyOn(mediaStore, "saveMediaBuffer").mockResolvedValue(

602+

vi.spyOn(mediaRuntime, "saveMediaBuffer").mockResolvedValue(

543603

createSavedMedia("/tmp/test.jpg", "image/jpeg"),

544604

);

545605

globalThis.fetch = (async () => {

546606

throw new Error("global fetch should not receive dispatcher-backed Slack media requests");

547607

}) as typeof fetch;

548608

const runtimeFetchSpy = vi

549-

.spyOn(ssrf, "fetchWithRuntimeDispatcher")

609+

.spyOn(mediaRuntime, "fetchWithRuntimeDispatcher")

550610

.mockImplementation(async () => {

551611

return new Response(Buffer.from("image data"), {

552612

status: 200,

@@ -578,7 +638,6 @@ describe("Slack media SSRF policy", () => {

578638

beforeEach(() => {

579639

mockFetch = vi.fn();

580640

globalThis.fetch = withFetchPreconnect(mockFetch);

581-

mockPinnedHostnameResolution();

582641

});

583642584643

afterEach(() => {

@@ -587,14 +646,14 @@ describe("Slack media SSRF policy", () => {

587646

});

588647589648

it("passes ssrfPolicy with Slack CDN allowedHostnames and allowRfc2544BenchmarkRange to file downloads", async () => {

590-

vi.spyOn(mediaStore, "saveMediaBuffer").mockResolvedValue(

649+

vi.spyOn(mediaRuntime, "saveMediaBuffer").mockResolvedValue(

591650

createSavedMedia("/tmp/test.jpg", "image/jpeg"),

592651

);

593652

mockFetch.mockResolvedValueOnce(

594653

new Response(Buffer.from("img"), { status: 200, headers: { "content-type": "image/jpeg" } }),

595654

);

596655597-

const spy = vi.spyOn(mediaFetch, "fetchRemoteMedia");

656+

const spy = vi.spyOn(mediaRuntime, "fetchRemoteMedia");

598657599658

await resolveSlackMedia({

600659

files: [{ url_private: "https://files.slack.com/test.jpg", name: "test.jpg" }],

@@ -615,22 +674,14 @@ describe("Slack media SSRF policy", () => {

615674

});

616675617676

it("passes ssrfPolicy to forwarded attachment image downloads", async () => {

618-

vi.spyOn(mediaStore, "saveMediaBuffer").mockResolvedValue(

677+

vi.spyOn(mediaRuntime, "saveMediaBuffer").mockResolvedValue(

619678

createSavedMedia("/tmp/fwd.jpg", "image/jpeg"),

620679

);

621-

vi.spyOn(ssrf, "resolvePinnedHostnameWithPolicy").mockImplementation(async (hostname) => {

622-

const normalized = hostname.trim().toLowerCase().replace(/\.$/, "");

623-

return {

624-

hostname: normalized,

625-

addresses: ["93.184.216.34"],

626-

lookup: ssrf.createPinnedLookup({ hostname: normalized, addresses: ["93.184.216.34"] }),

627-

};

628-

});

629680

mockFetch.mockResolvedValueOnce(

630681

new Response(Buffer.from("fwd"), { status: 200, headers: { "content-type": "image/jpeg" } }),

631682

);

632683633-

const spy = vi.spyOn(mediaFetch, "fetchRemoteMedia");

684+

const spy = vi.spyOn(mediaRuntime, "fetchRemoteMedia");

634685635686

await resolveSlackAttachmentContent({

636687

attachments: [{ is_share: true, image_url: "https://files.slack.com/forwarded.jpg" }],

@@ -650,7 +701,6 @@ describe("resolveSlackAttachmentContent", () => {

650701

beforeEach(() => {

651702

mockFetch = vi.fn();

652703

globalThis.fetch = mockFetch as unknown as typeof fetch;

653-

mockPinnedHostnameResolution();

654704

});

655705656706

afterEach(() => {

@@ -696,7 +746,7 @@ describe("resolveSlackAttachmentContent", () => {

696746

});

697747698748

it("skips forwarded image URLs on non-Slack hosts", async () => {

699-

const saveMediaBufferMock = vi.spyOn(mediaStore, "saveMediaBuffer");

749+

const saveMediaBufferMock = vi.spyOn(mediaRuntime, "saveMediaBuffer");

700750701751

const result = await resolveSlackAttachmentContent({

702752

attachments: [{ is_share: true, image_url: "https://example.com/forwarded.jpg" }],

@@ -710,7 +760,7 @@ describe("resolveSlackAttachmentContent", () => {

710760

});

711761712762

it("downloads Slack-hosted images from forwarded shared attachments", async () => {

713-

vi.spyOn(mediaStore, "saveMediaBuffer").mockResolvedValue(

763+

vi.spyOn(mediaRuntime, "saveMediaBuffer").mockResolvedValue(

714764

createSavedMedia("/tmp/forwarded.jpg", "image/jpeg"),

715765

);

716766