惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

V
Visual Studio Blog
Y
Y Combinator Blog
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
Hugging Face - Blog
Hugging Face - Blog
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻
The Cloudflare Blog
L
LangChain Blog
美团技术团队
N
Netflix TechBlog - Medium
量子位
酷 壳 – CoolShell
酷 壳 – CoolShell
B
Blog
博客园 - 司徒正美
爱范儿
爱范儿
D
DataBreaches.Net
月光博客
月光博客
U
Unit 42
B
Blog RSS Feed
Engineering at Meta
Engineering at Meta
Apple Machine Learning Research
Apple Machine Learning Research
Jina AI
Jina AI
MongoDB | Blog
MongoDB | Blog
腾讯CDC

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(browser): validate screenshot timeout · openclaw/open...
steipete · 2026-05-29 · via Recent Commits to openclaw:main

File tree

  • extensions/browser/src/browser/routes

Original file line numberDiff line numberDiff line change

@@ -169,4 +169,18 @@ describe("browser agent snapshot timeout routing", () => {

169169

}),

170170

);

171171

});

172+
173+

it("rejects loose screenshot timeoutMs values before dispatching", async () => {

174+

const handler = getScreenshotHandler();

175+

const response = createBrowserRouteResponse();

176+
177+

await handler?.(

178+

{ params: {}, query: {}, body: { type: "png", timeoutMs: "1e3" } },

179+

response.res,

180+

);

181+
182+

expect(response.statusCode).toBe(400);

183+

expect(response.body).toEqual({ error: "timeoutMs must be a positive integer." });

184+

expect(cdpMocks.captureScreenshot).not.toHaveBeenCalled();

185+

});

172186

});

Original file line numberDiff line numberDiff line change

@@ -43,8 +43,9 @@ import {

4343

shouldUsePlaywrightForScreenshot,

4444

} from "./agent.snapshot.plan.js";

4545

import { EXISTING_SESSION_LIMITS } from "./existing-session-limits.js";

46+

import { readRoutePositiveInteger } from "./route-numeric.js";

4647

import type { BrowserResponse, BrowserRouteRegistrar } from "./types.js";

47-

import { asyncBrowserRoute, jsonError, toBoolean, toNumber, toStringOrEmpty } from "./utils.js";

48+

import { asyncBrowserRoute, jsonError, toBoolean, toStringOrEmpty } from "./utils.js";

4849
4950

const CHROME_MCP_OVERLAY_ATTR = "data-openclaw-mcp-overlay";

5051

@@ -368,11 +369,16 @@ export function registerBrowserAgentSnapshotRoutes(

368369

const element = toStringOrEmpty(body.element) || undefined;

369370

const labels = toBoolean(body.labels) ?? false;

370371

const type = body.type === "jpeg" ? "jpeg" : "png";

371-

const timeoutMsRaw = toNumber(body.timeoutMs);

372-

const timeoutMs =

373-

timeoutMsRaw !== undefined

374-

? normalizeBrowserTimerDelayMs(timeoutMsRaw)

375-

: DEFAULT_BROWSER_SCREENSHOT_TIMEOUT_MS;

372+

let timeoutMs: number;

373+

try {

374+

const timeoutMsRaw = readRoutePositiveInteger(body.timeoutMs, "timeoutMs");

375+

timeoutMs =

376+

timeoutMsRaw !== undefined

377+

? normalizeBrowserTimerDelayMs(timeoutMsRaw)

378+

: DEFAULT_BROWSER_SCREENSHOT_TIMEOUT_MS;

379+

} catch (err) {

380+

return jsonError(res, 400, String(err instanceof Error ? err.message : err));

381+

}

376382
377383

if (fullPage && (ref || element)) {

378384

return jsonError(res, 400, "fullPage is not supported for element screenshots");