chore(lint): enable more readability rules · openclaw/openclaw@4eba3e5

Recent Commits to openclaw:main

steipete · 2026-05-31 · via Recent Commits to openclaw:main

File tree

- whatsapp/src/auto-reply/monitor
packages/agent-core/src/harness
- e2e/lib/plugin-lifecycle-matrix

Original file line number	Diff line number	Diff line change
`@@ -32,11 +32,13 @@`
`32`	`32`	`"eslint/no-useless-computed-key": "error",`
`33`	`33`	`"eslint/no-useless-concat": "error",`
`34`	`34`	`"eslint/no-useless-constructor": "error",`
	`35`	`+"eslint/no-useless-rename": "error",`
`35`	`36`	`"eslint/no-unused-vars": "off",`
`36`	`37`	`"eslint/no-warning-comments": "error",`
`37`	`38`	`"eslint/no-unmodified-loop-condition": "error",`
`38`	`39`	`"eslint/no-new-wrappers": "error",`
`39`	`40`	`"eslint/no-else-return": "error",`
	`41`	`+"eslint/no-lonely-if": "error",`
`40`	`42`	`"eslint/no-case-declarations": "error",`
`41`	`43`	`"eslint/default-case-last": "error",`
`42`	`44`	`"eslint/default-param-last": "error",`
`@@ -89,6 +91,7 @@`
`89`	`91`	`"typescript/prefer-namespace-keyword": "error",`
`90`	`92`	`"typescript/prefer-return-this-type": "error",`
`91`	`93`	`"typescript/prefer-find": "error",`
	`94`	`+"typescript/prefer-for-of": "error",`
`92`	`95`	`"typescript/prefer-function-type": "error",`
`93`	`96`	`"typescript/prefer-includes": "error",`
`94`	`97`	`"typescript/prefer-reduce-type-parameter": "error",`
`@@ -118,6 +121,7 @@`
`118`	`121`	`"unicorn/prefer-date-now": "error",`
`119`	`122`	`"unicorn/prefer-dom-node-text-content": "error",`
`120`	`123`	`"unicorn/prefer-keyboard-event-key": "error",`
	`124`	`+"unicorn/prefer-array-flat": "error",`
`121`	`125`	`"unicorn/prefer-array-some": "error",`
`122`	`126`	`"unicorn/prefer-math-min-max": "error",`
`123`	`127`	`"unicorn/prefer-node-protocol": "error",`

Original file line number	Diff line number	Diff line change
`@@ -373,8 +373,7 @@ function splitExecLine(line: string): string[] {`
`373`	`373`	`let current = "";`
`374`	`374`	`let inQuotes = false;`
`375`	`375`	`let quoteChar = "";`
`376`		`-for (let i = 0; i < line.length; i += 1) {`
`377`		`-const ch = line[i];`
	`376`	`+for (const ch of line) {`
`378`	`377`	`if ((ch === '"' \|\| ch === "'") && (!inQuotes \|\| ch === quoteChar)) {`
`379`	`378`	`if (inQuotes) {`
`380`	`379`	`inQuotes = false;`

Original file line number	Diff line number	Diff line change
`@@ -2051,10 +2051,8 @@ export class MatrixClient {`
`2051`	`2051`	`this.emitter.emit("room.event", roomId, raw);`
`2052`	`2052`	`if (isEncryptedEvent) {`
`2053`	`2053`	`this.emitter.emit("room.encrypted_event", roomId, raw);`
`2054`		`-} else {`
`2055`		`-if (decryptBridge.shouldEmitUnencryptedMessage(roomId, raw.event_id)) {`
`2056`		`-this.emitter.emit("room.message", roomId, raw);`
`2057`		`-}`
	`2054`	`+} else if (decryptBridge.shouldEmitUnencryptedMessage(roomId, raw.event_id)) {`
	`2055`	`+this.emitter.emit("room.message", roomId, raw);`
`2058`	`2056`	`}`
`2059`	`2057`
`2060`	`2058`	`const stateKey = raw.state_key ?? "";`

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,7 @@ const LANGUAGE_STOP_WORDS = {`
`231`	`231`
`232`	`232`	`const CONCEPT_STOP_WORDS = new Set(`
`233`	`233`	`Object.values(LANGUAGE_STOP_WORDS)`
`234`		`-.flatMap((words) => words)`
	`234`	`+.flat()`
`235`	`235`	`.map((word) => normalizeLowercaseStringOrEmpty(word)),`
`236`	`236`	`);`
`237`	`237`

Original file line number	Diff line number	Diff line change
`@@ -255,28 +255,26 @@ export async function handleNextcloudTalkInbound(params: {`
`255`	`255`	runtime.log?.(`nextcloud-talk: drop group sender ${senderId} (reason=${accessReason})`);
`256`	`256`	`return;`
`257`	`257`	`}`
`258`		`-} else {`
`259`		`-if (access.senderAccess.decision !== "allow") {`
`260`		`-if (access.senderAccess.decision === "pairing") {`
`261`		`-await pairing.issueChallenge({`
`262`		`- senderId,`
`263`		-senderIdLine: `Your Nextcloud user id: ${senderId}`,
`264`		`-meta: { name: senderName \|\| undefined },`
`265`		`-sendPairingReply: async (text) => {`
`266`		`-await sendMessageNextcloudTalk(roomToken, text, {`
`267`		`-cfg: config,`
`268`		`-accountId: account.accountId,`
`269`		`-});`
`270`		`-statusSink?.({ lastOutboundAt: Date.now() });`
`271`		`-},`
`272`		`-onReplyError: (err) => {`
`273`		-runtime.error?.(`nextcloud-talk: pairing reply failed for ${senderId}: ${String(err)}`);
`274`		`-},`
`275`		`-});`
`276`		`-}`
`277`		-runtime.log?.(`nextcloud-talk: drop DM sender ${senderId} (reason=${accessReason})`);
`278`		`-return;`
	`258`	`+} else if (access.senderAccess.decision !== "allow") {`
	`259`	`+if (access.senderAccess.decision === "pairing") {`
	`260`	`+await pairing.issueChallenge({`
	`261`	`+ senderId,`
	`262`	+senderIdLine: `Your Nextcloud user id: ${senderId}`,
	`263`	`+meta: { name: senderName \|\| undefined },`
	`264`	`+sendPairingReply: async (text) => {`
	`265`	`+await sendMessageNextcloudTalk(roomToken, text, {`
	`266`	`+cfg: config,`
	`267`	`+accountId: account.accountId,`
	`268`	`+});`
	`269`	`+statusSink?.({ lastOutboundAt: Date.now() });`
	`270`	`+},`
	`271`	`+onReplyError: (err) => {`
	`272`	+runtime.error?.(`nextcloud-talk: pairing reply failed for ${senderId}: ${String(err)}`);
	`273`	`+},`
	`274`	`+});`
`279`	`275`	`}`
	`276`	+runtime.log?.(`nextcloud-talk: drop DM sender ${senderId} (reason=${accessReason})`);
	`277`	`+return;`
`280`	`278`	`}`
`281`	`279`
`282`	`280`	`if (access.commandAccess.shouldBlockControlCommand) {`

Original file line number	Diff line number	Diff line change
`@@ -312,13 +312,11 @@ export async function waitForFile(`
`312`	`312`	`stableCount = 0;`
`313`	`313`	`}`
`314`	`314`	`lastSize = stat.size;`
`315`		`-} else {`
`316`		`-if (Date.now() - fileAppearedAt > emptyGiveUpMs) {`
`317`		`-debugError(`
`318`		-`[audio-convert] waitForFile: file still empty after ${emptyGiveUpMs}ms, giving up: ${path.basename(filePath)}`,
`319`		`-);`
`320`		`-return 0;`
`321`		`-}`
	`315`	`+} else if (Date.now() - fileAppearedAt > emptyGiveUpMs) {`
	`316`	`+debugError(`
	`317`	+`[audio-convert] waitForFile: file still empty after ${emptyGiveUpMs}ms, giving up: ${path.basename(filePath)}`,
	`318`	`+);`
	`319`	`+return 0;`
`322`	`320`	`}`
`323`	`321`	`} catch {`
`324`	`322`	`if (!fileExists && Date.now() - start > noFileGiveUpMs) {`

Original file line number	Diff line number	Diff line change
`@@ -107,17 +107,13 @@ function expectRpcCall(params: {`
`107`	`107`	`expect(method).toBe(params.method);`
`108`	`108`	`if (params.rpcParams) {`
`109`	`109`	`expectFields(requireRecord(rpcParams, "rpc params"), params.rpcParams);`
`110`		`-} else {`
`111`		`-if (rpcParams === undefined) {`
`112`		`-throw new Error("expected rpc params argument");`
`113`		`-}`
	`110`	`+} else if (rpcParams === undefined) {`
	`111`	`+throw new Error("expected rpc params argument");`
`114`	`112`	`}`
`115`	`113`	`if (params.options) {`
`116`	`114`	`expectFields(requireRecord(options, "rpc options"), params.options);`
`117`		`-} else {`
`118`		`-if (options === undefined) {`
`119`		`-throw new Error("expected rpc options argument");`
`120`		`-}`
	`115`	`+} else if (options === undefined) {`
	`116`	`+throw new Error("expected rpc options argument");`
`121`	`117`	`}`
`122`	`118`	`}`
`123`	`119`

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ class GroupFairQueue {`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`private takeNext(): QueuedApiRequest<unknown> \| undefined {`
`71`		`-for (let scanned = 0; scanned < this.laneOrder.length; scanned += 1) {`
	`71`	`+for (const ignoredLaneKey of this.laneOrder) {`
`72`	`72`	`this.nextLaneIndex %= this.laneOrder.length;`
`73`	`73`	`const laneKey = this.laneOrder[this.nextLaneIndex];`
`74`	`74`	`const queue = this.lanes.get(laneKey);`

Original file line number	Diff line number	Diff line change
`@@ -294,8 +294,7 @@ async function sendTelegramVoiceFallbackText(opts: {`
`294`	`294`	`let firstDeliveredMessageId: number \| undefined;`
`295`	`295`	`const chunks = filterEmptyTelegramTextChunks(opts.chunkText(opts.text));`
`296`	`296`	`let appliedReplyTo = false;`
`297`		`-for (let i = 0; i < chunks.length; i += 1) {`
`298`		`-const chunk = chunks[i];`
	`297`	`+for (const chunk of chunks) {`
`299`	`298`	`// Only apply reply reference, quote text, and buttons to the first chunk.`
`300`	`299`	`const replyToForChunk = !appliedReplyTo ? opts.replyToId : undefined;`
`301`	`300`	`const applyQuoteForChunk = !appliedReplyTo;`

Original file line number	Diff line number	Diff line change
`@@ -216,8 +216,7 @@ function shouldBypassEnvProxyForTelegramApi(env: NodeJS.ProcessEnv = process.env`
`216`	`216`	`const targetHostname = normalizeLowercaseStringOrEmpty(TELEGRAM_API_HOSTNAME);`
`217`	`217`	`const targetPort = 443;`
`218`	`218`	`const noProxyEntries = noProxyValue.split(/[,\s]/);`
`219`		`-for (let i = 0; i < noProxyEntries.length; i++) {`
`220`		`-const entry = noProxyEntries[i];`
	`219`	`+for (const entry of noProxyEntries) {`
`221`	`220`	`if (!entry) {`
`222`	`221`	`continue;`
`223`	`222`	`}`

此内容由惯性聚合(RSS阅读器)自动聚合整理，仅供阅读参考。原文来自 — 版权归原作者所有。

推荐订阅源

Recent Commits to openclaw:main

File tree