import { formatAuditList } from "../../src/gateway/server/ws-connection/message-handler.js";

// Reproduction for issue #90654

// Demonstrates that formatAuditList must skip non-string items instead of

// crashing with "Cannot read properties of undefined (reading 'trim')".

function main() {

console.log("=== Reproduction for issue #90654 ===");

// Valid cases

console.log("\nValid cases:");

console.log(" undefined:", formatAuditList(undefined));

console.log(" empty:", formatAuditList([]));

console.log(" normal:", formatAuditList([" b ", "a", "c "]));

// Before fix: this would crash with TypeError

const malformed = [

"valid",

undefined,

null,

42,

"also-valid",

] as unknown as string[];

console.log("\nMalformed input (contains non-string items):");

console.log(" Input:", malformed);

let result: string;

try {

result = formatAuditList(malformed);

console.log(" Result:", result);

} catch (err) {

console.error("\nFAIL: formatAuditList threw on non-string items:");

console.error(" ", err);

process.exitCode = 1;

return;

}

const expected = "also-valid,valid";

if (result === expected) {

console.log("\nPASS: Non-string items are safely skipped.");

} else {

console.error(`\nFAIL: Expected "${expected}", got "${result}".`);

process.exitCode = 1;

}

}

main();

});

});

});

describe("formatAuditList", () => {

it("returns <none> for empty or undefined arrays", () => {

expect(testing.formatAuditList(undefined)).toBe("<none>");

expect(testing.formatAuditList([])).toBe("<none>");

});

it("trims, deduplicates, and sorts valid strings", () => {

expect(testing.formatAuditList([" b ", "a", " b", "c ", ""])).toBe("a,b,c");

});

it("skips non-string items without crashing (regression for #90654)", () => {

expect(

testing.formatAuditList([

"valid",

undefined as unknown as string,

null as unknown as string,

42 as unknown as string,

"also-valid",

]),

).toBe("also-valid,valid");

});

it("returns <none> when all items are non-strings or empty", () => {

expect(

testing.formatAuditList([

undefined as unknown as string,

null as unknown as string,

" ",

"",

]),

).toBe("<none>");

});

});

logWsControl: SubsystemLogger;

};

export function formatAuditList(items: string[] | undefined): string {

if (!items || items.length === 0) {

return "<none>";

}

const out = new Set<string>();

for (const item of items) {

if (typeof item !== "string") {

continue;

}

const trimmed = item.trim();

if (trimmed) {

out.add(trimmed);

}

}

if (out.size === 0) {

return "<none>";

}

return [...out].toSorted().join(",");

}

export function attachGatewayWsMessageHandler(params: GatewayWsMessageHandlerParams) {

const {

socket,

);

let hasServerApprovedDeviceTokenBaseline = false;

if (device && devicePublicKey) {

const formatAuditList = (items: string[] | undefined): string => {

if (!items || items.length === 0) {

return "<none>";

}

const out = new Set<string>();

for (const item of items) {

const trimmed = item.trim();

if (trimmed) {

out.add(trimmed);

}

}

if (out.size === 0) {

return "<none>";

}

return [...out].toSorted().join(",");

};

const logUpgradeAudit = (

reason: "role-upgrade" | "scope-upgrade",

currentRoles: string[] | undefined,

export const testing = {

resolvePinnedClientMetadata,

formatAuditList,

};

export { testing as __testing };