惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

有赞技术团队
有赞技术团队
M
MIT News - Artificial intelligence
Hugging Face - Blog
Hugging Face - Blog
博客园 - 聂微东
量子位
S
SegmentFault 最新的问题
V
Visual Studio Blog
博客园 - 【当耐特】
Apple Machine Learning Research
Apple Machine Learning Research
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
小众软件
小众软件
Stack Overflow Blog
Stack Overflow Blog
Vercel News
Vercel News
D
Docker
J
Java Code Geeks
博客园 - 三生石上(FineUI控件)
博客园 - Franky
Recent Announcements
Recent Announcements
freeCodeCamp Programming Tutorials: Python, JavaScript, Git & More
MongoDB | Blog
MongoDB | Blog
D
DataBreaches.Net
Y
Y Combinator Blog
云风的 BLOG
云风的 BLOG
V
V2EX

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(cron): invalidate stale external schedule slots · ope...
steipete · 2026-04-27 · via Recent Commits to openclaw:main

@@ -2,6 +2,8 @@ import fs from "node:fs/promises";

22

import path from "node:path";

33

import { describe, expect, it, vi } from "vitest";

44

import { setupCronServiceSuite } from "../service.test-harness.js";

5+

import { saveCronStore } from "../store.js";

6+

import type { CronJob } from "../types.js";

57

import { findJobOrThrow } from "./jobs.js";

68

import { createCronServiceState } from "./state.js";

79

import { ensureLoaded, persist } from "./store.js";

@@ -40,6 +42,22 @@ function createStoreTestState(storePath: string) {

4042

});

4143

}

424445+

function createReloadCronJob(params?: Partial<CronJob>): CronJob {

46+

return {

47+

id: "reload-cron-expr-job",

48+

name: "reload cron expr job",

49+

enabled: true,

50+

createdAtMs: STORE_TEST_NOW - 60_000,

51+

updatedAtMs: STORE_TEST_NOW - 60_000,

52+

schedule: { kind: "cron", expr: "0 6 * * *", tz: "UTC" },

53+

sessionTarget: "main",

54+

wakeMode: "now",

55+

payload: { kind: "systemEvent", text: "tick" },

56+

state: {},

57+

...params,

58+

};

59+

}

60+4361

describe("cron service store seam coverage", () => {

4462

it("loads stored jobs, recomputes next runs, and does not rewrite the store on load", async () => {

4563

const { storePath } = await makeStorePath();

@@ -189,4 +207,183 @@ describe("cron service store seam coverage", () => {

189207

expect.stringContaining("invalid persisted sessionTarget"),

190208

);

191209

});

210+211+

it("clears stale nextRunAtMs after force reload when cron schedule expression changes", async () => {

212+

const { storePath } = await makeStorePath();

213+

const staleNextRunAtMs = STORE_TEST_NOW + 3_600_000;

214+215+

await saveCronStore(storePath, {

216+

version: 1,

217+

jobs: [

218+

createReloadCronJob({

219+

state: { nextRunAtMs: staleNextRunAtMs },

220+

}),

221+

],

222+

});

223+224+

const state = createStoreTestState(storePath);

225+

await ensureLoaded(state, { skipRecompute: true });

226+

expect(findJobOrThrow(state, "reload-cron-expr-job").state.nextRunAtMs).toBe(staleNextRunAtMs);

227+228+

await writeSingleJobStore(storePath, {

229+

id: "reload-cron-expr-job",

230+

name: "reload cron expr job",

231+

enabled: true,

232+

createdAtMs: STORE_TEST_NOW - 60_000,

233+

updatedAtMs: STORE_TEST_NOW - 30_000,

234+

schedule: { kind: "cron", expr: "30 6 * * 0,6", tz: "UTC" },

235+

sessionTarget: "main",

236+

wakeMode: "now",

237+

payload: { kind: "systemEvent", text: "tick" },

238+

state: {},

239+

});

240+241+

await ensureLoaded(state, { forceReload: true, skipRecompute: true });

242+243+

const reloadedJob = findJobOrThrow(state, "reload-cron-expr-job");

244+

expect(reloadedJob.schedule).toEqual({ kind: "cron", expr: "30 6 * * 0,6", tz: "UTC" });

245+

expect(reloadedJob.state.nextRunAtMs).toBeUndefined();

246+

});

247+248+

it("preserves nextRunAtMs after force reload when cron schedule key order changes only", async () => {

249+

const { storePath } = await makeStorePath();

250+

const dueNextRunAtMs = STORE_TEST_NOW - 1_000;

251+252+

await saveCronStore(storePath, {

253+

version: 1,

254+

jobs: [

255+

createReloadCronJob({

256+

state: { nextRunAtMs: dueNextRunAtMs },

257+

}),

258+

],

259+

});

260+261+

const state = createStoreTestState(storePath);

262+

await ensureLoaded(state, { skipRecompute: true });

263+264+

await writeSingleJobStore(storePath, {

265+

id: "reload-cron-expr-job",

266+

name: "reload cron expr job",

267+

enabled: true,

268+

createdAtMs: STORE_TEST_NOW - 60_000,

269+

updatedAtMs: STORE_TEST_NOW - 30_000,

270+

schedule: { expr: "0 6 * * *", kind: "cron", tz: "UTC" },

271+

sessionTarget: "main",

272+

wakeMode: "now",

273+

payload: { kind: "systemEvent", text: "tick" },

274+

state: {},

275+

});

276+277+

await ensureLoaded(state, { forceReload: true, skipRecompute: true });

278+279+

expect(findJobOrThrow(state, "reload-cron-expr-job").state.nextRunAtMs).toBe(dueNextRunAtMs);

280+

});

281+282+

it("preserves nextRunAtMs after force reload when scheduling inputs are unchanged", async () => {

283+

const { storePath } = await makeStorePath();

284+

const originalNextRunAtMs = STORE_TEST_NOW + 3_600_000;

285+286+

await writeSingleJobStore(storePath, {

287+

...createReloadCronJob({ state: { nextRunAtMs: originalNextRunAtMs } }),

288+

});

289+290+

const state = createStoreTestState(storePath);

291+

await ensureLoaded(state, { skipRecompute: true });

292+

await writeSingleJobStore(storePath, {

293+

...createReloadCronJob({

294+

updatedAtMs: STORE_TEST_NOW,

295+

state: { nextRunAtMs: originalNextRunAtMs + 60_000 },

296+

}),

297+

});

298+299+

await ensureLoaded(state, { forceReload: true, skipRecompute: true });

300+301+

expect(findJobOrThrow(state, "reload-cron-expr-job").state.nextRunAtMs).toBe(

302+

originalNextRunAtMs + 60_000,

303+

);

304+

});

305+306+

it("clears stale nextRunAtMs after force reload when enabled state changes", async () => {

307+

const { storePath } = await makeStorePath();

308+

const staleNextRunAtMs = STORE_TEST_NOW + 3_600_000;

309+310+

await writeSingleJobStore(storePath, {

311+

...createReloadCronJob({

312+

enabled: true,

313+

state: { nextRunAtMs: staleNextRunAtMs },

314+

}),

315+

});

316+317+

const state = createStoreTestState(storePath);

318+

await ensureLoaded(state, { skipRecompute: true });

319+

await writeSingleJobStore(storePath, {

320+

...createReloadCronJob({

321+

enabled: false,

322+

updatedAtMs: STORE_TEST_NOW,

323+

state: { nextRunAtMs: staleNextRunAtMs },

324+

}),

325+

});

326+327+

await ensureLoaded(state, { forceReload: true, skipRecompute: true });

328+329+

expect(findJobOrThrow(state, "reload-cron-expr-job").state.nextRunAtMs).toBeUndefined();

330+

});

331+332+

it("clears stale nextRunAtMs after force reload when every schedule anchor changes", async () => {

333+

const { storePath } = await makeStorePath();

334+

const jobId = "reload-every-anchor-job";

335+

const staleNextRunAtMs = STORE_TEST_NOW + 3_600_000;

336+337+

await writeSingleJobStore(storePath, {

338+

...createReloadCronJob({

339+

id: jobId,

340+

schedule: { kind: "every", everyMs: 60_000, anchorMs: STORE_TEST_NOW - 60_000 },

341+

state: { nextRunAtMs: staleNextRunAtMs },

342+

}),

343+

});

344+345+

const state = createStoreTestState(storePath);

346+

await ensureLoaded(state, { skipRecompute: true });

347+

await writeSingleJobStore(storePath, {

348+

...createReloadCronJob({

349+

id: jobId,

350+

updatedAtMs: STORE_TEST_NOW,

351+

schedule: { kind: "every", everyMs: 60_000, anchorMs: STORE_TEST_NOW },

352+

state: { nextRunAtMs: staleNextRunAtMs },

353+

}),

354+

});

355+356+

await ensureLoaded(state, { forceReload: true, skipRecompute: true });

357+358+

expect(findJobOrThrow(state, jobId).state.nextRunAtMs).toBeUndefined();

359+

});

360+361+

it("clears stale nextRunAtMs after force reload when at schedule target changes", async () => {

362+

const { storePath } = await makeStorePath();

363+

const jobId = "reload-at-target-job";

364+

const staleNextRunAtMs = STORE_TEST_NOW + 3_600_000;

365+366+

await writeSingleJobStore(storePath, {

367+

...createReloadCronJob({

368+

id: jobId,

369+

schedule: { kind: "at", at: "2026-03-23T13:00:00.000Z" },

370+

state: { nextRunAtMs: staleNextRunAtMs },

371+

}),

372+

});

373+374+

const state = createStoreTestState(storePath);

375+

await ensureLoaded(state, { skipRecompute: true });

376+

await writeSingleJobStore(storePath, {

377+

...createReloadCronJob({

378+

id: jobId,

379+

updatedAtMs: STORE_TEST_NOW,

380+

schedule: { kind: "at", at: "2026-03-23T14:00:00.000Z" },

381+

state: { nextRunAtMs: staleNextRunAtMs },

382+

}),

383+

});

384+385+

await ensureLoaded(state, { forceReload: true, skipRecompute: true });

386+387+

expect(findJobOrThrow(state, jobId).state.nextRunAtMs).toBeUndefined();

388+

});

192389

});