惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

月光博客
月光博客
罗磊的独立博客
The GitHub Blog
The GitHub Blog
V
V2EX
Last Week in AI
Last Week in AI
博客园 - 聂微东
MyScale Blog
MyScale Blog
美团技术团队
L
LangChain Blog
博客园 - Franky
腾讯CDC
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻
博客园_首页
S
SegmentFault 最新的问题
爱范儿
爱范儿
让小产品的独立变现更简单 - ezindie.com
让小产品的独立变现更简单 - ezindie.com
Stack Overflow Blog
Stack Overflow Blog
量子位
小众软件
小众软件
宝玉的分享
宝玉的分享
J
Java Code Geeks
Google DeepMind News
Google DeepMind News
D
Docker
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
test: tighten stale pid restart assertions · openclaw/ope...
steipete · 2026-05-11 · via Recent Commits to openclaw:main

@@ -161,6 +161,35 @@ function installInitialBusyPoll(

161161

return () => call;

162162

}

163163164+

function mockCall(mock: ReturnType<typeof vi.fn>, callIndex = 0): unknown[] {

165+

const call = mock.mock.calls[callIndex] as unknown[] | undefined;

166+

if (!call) {

167+

throw new Error(`expected mock call ${callIndex}`);

168+

}

169+

return call;

170+

}

171+172+

function mockCallRecordArg(

173+

mock: ReturnType<typeof vi.fn>,

174+

callIndex: number,

175+

argIndex: number,

176+

label: string,

177+

): Record<string, unknown> {

178+

const value = mockCall(mock, callIndex)[argIndex];

179+

if (!value || typeof value !== "object") {

180+

throw new Error(`expected ${label} to be an object`);

181+

}

182+

return value as Record<string, unknown>;

183+

}

184+185+

function expectWarningContaining(text: string): void {

186+

expect(

187+

mockRestartWarn.mock.calls.some((call) =>

188+

typeof call[0] === "string" ? call[0].includes(text) : false,

189+

),

190+

).toBe(true);

191+

}

192+164193

describe.skipIf(isWindows)("restart-stale-pids", () => {

165194

beforeAll(async () => {

166195

({ __testing, cleanStaleGatewayProcessesSync, findGatewayPidsOnPortSync } =

@@ -222,9 +251,7 @@ describe.skipIf(isWindows)("restart-stale-pids", () => {

222251

it("logs warning when initial lsof scan exits with status > 1", () => {

223252

mockSpawnSync.mockReturnValue({ error: null, status: 2, stdout: "", stderr: "lsof error" });

224253

expect(findGatewayPidsOnPortSync(18789)).toStrictEqual([]);

225-

expect(mockRestartWarn).toHaveBeenCalledWith(

226-

expect.stringContaining("lsof exited with status 2"),

227-

);

254+

expectWarningContaining("lsof exited with status 2");

228255

});

229256230257

it("returns [] when lsof returns an error object (e.g. ENOENT)", () => {

@@ -235,9 +262,7 @@ describe.skipIf(isWindows)("restart-stale-pids", () => {

235262

stderr: "",

236263

});

237264

expect(findGatewayPidsOnPortSync(18789)).toStrictEqual([]);

238-

expect(mockRestartWarn).toHaveBeenCalledWith(

239-

expect.stringContaining("lsof failed during initial stale-pid scan"),

240-

);

265+

expectWarningContaining("lsof failed during initial stale-pid scan");

241266

});

242267243268

it("parses openclaw-gateway pids and excludes the current process", () => {

@@ -276,11 +301,9 @@ describe.skipIf(isWindows)("restart-stale-pids", () => {

276301

});

277302278303

expect(findGatewayPidsOnPortSync(18789)).toEqual([stalePid]);

279-

expect(mockSpawnSync).toHaveBeenCalledWith(

280-

"ps",

281-

["-ww", "-p", String(stalePid), "-o", "command="],

282-

expect.objectContaining({ timeout: 2000 }),

283-

);

304+

const psCall = mockSpawnSync.mock.calls.find((call) => call[0] === "ps");

305+

expect(psCall?.[1]).toEqual(["-ww", "-p", String(stalePid), "-o", "command="]);

306+

expect(psCall?.[2]).toEqual({ timeout: 2000, encoding: "utf8" });

284307

});

285308286309

it("excludes ancestor pids so a sidecar cannot kill its parent gateway — regression for #68451", () => {

@@ -433,11 +456,10 @@ describe.skipIf(isWindows)("restart-stale-pids", () => {

433456

it("forwards the spawnTimeoutMs argument to spawnSync", () => {

434457

mockSpawnSync.mockReturnValue({ error: null, status: 0, stdout: "", stderr: "" });

435458

findGatewayPidsOnPortSync(18789, 400);

436-

expect(mockSpawnSync).toHaveBeenCalledWith(

437-

"lsof",

438-

expect.any(Array),

439-

expect.objectContaining({ timeout: 400 }),

440-

);

459+

const lsofCall = mockCall(mockSpawnSync);

460+

expect(lsofCall[0]).toBe("lsof");

461+

expect(Array.isArray(lsofCall[1])).toBe(true);

462+

expect(mockCallRecordArg(mockSpawnSync, 0, 2, "lsof options").timeout).toBe(400);

441463

});

442464443465

it("deduplicates pids from dual-stack listeners (IPv4+IPv6 emit same pid twice)", () => {

@@ -944,9 +966,7 @@ describe.skipIf(isWindows)("restart-stale-pids", () => {

944966945967

expect(cleanStaleGatewayProcessesSync()).toEqual([stalePid]);

946968

expect(mockReadWindowsListeningPidsResult).toHaveBeenCalledWith(18789, 400);

947-

expect(mockRestartWarn).toHaveBeenCalledWith(

948-

expect.stringContaining("port 18789 still in use after 2000ms"),

949-

);

969+

expectWarningContaining("port 18789 still in use after 2000ms");

950970

expect(killSpy).toHaveBeenCalledWith(stalePid, 0);

951971

} finally {

952972

__testing.setDateNowOverride(null);

@@ -972,9 +992,7 @@ describe.skipIf(isWindows)("restart-stale-pids", () => {

972992973993

expect(cleanStaleGatewayProcessesSync()).toStrictEqual([]);

974994

expect(mockReadWindowsListeningPidsResult).toHaveBeenCalledWith(18789, 400);

975-

expect(mockRestartWarn).toHaveBeenCalledWith(

976-

expect.stringContaining("port 18789 still in use after 2000ms"),

977-

);

995+

expectWarningContaining("port 18789 still in use after 2000ms");

978996

expect(killSpy).not.toHaveBeenCalled();

979997

} finally {

980998

__testing.setDateNowOverride(null);

@@ -1002,9 +1020,7 @@ describe.skipIf(isWindows)("restart-stale-pids", () => {

1002102010031021

expect(cleanStaleGatewayProcessesSync()).toStrictEqual([]);

10041022

expect(mockReadWindowsProcessArgsResult).toHaveBeenCalledWith(stalePid, undefined);

1005-

expect(mockRestartWarn).toHaveBeenCalledWith(

1006-

expect.stringContaining("port 18789 still in use after 2000ms"),

1007-

);

1023+

expectWarningContaining("port 18789 still in use after 2000ms");

10081024

expect(killSpy).not.toHaveBeenCalled();

10091025

} finally {

10101026

__testing.setDateNowOverride(null);

@@ -1049,11 +1065,11 @@ describe.skipIf(isWindows)("restart-stale-pids", () => {

10491065

});

1050106610511067

expect(cleanStaleGatewayProcessesSync()).toStrictEqual([]);

1052-

expect(mockSpawnSync).toHaveBeenCalledWith(

1053-

"C:\\Windows\\System32\\taskkill.exe",

1054-

["/T", "/PID", String(stalePid)],

1055-

expect.objectContaining({ timeout: 5000 }),

1068+

const taskkillCall = mockSpawnSync.mock.calls.find(

1069+

(call) => call[0] === "C:\\Windows\\System32\\taskkill.exe",

10561070

);

1071+

expect(taskkillCall?.[1]).toEqual(["/T", "/PID", String(stalePid)]);

1072+

expect((taskkillCall?.[2] as { timeout?: number } | undefined)?.timeout).toBe(5000);

10571073

} finally {

10581074

__testing.setDateNowOverride(null);

10591075

if (originalSystemRoot === undefined) {

@@ -1104,17 +1120,13 @@ describe.skipIf(isWindows)("restart-stale-pids", () => {

11041120

});

1105112111061122

expect(cleanStaleGatewayProcessesSync()).toStrictEqual([]);

1107-

expect(mockSpawnSync).toHaveBeenNthCalledWith(

1108-

1,

1109-

"C:\\Windows\\System32\\taskkill.exe",

1110-

["/T", "/PID", String(stalePid)],

1111-

expect.objectContaining({ timeout: 5000 }),

1112-

);

1113-

expect(mockSpawnSync).toHaveBeenNthCalledWith(

1114-

2,

1115-

"C:\\Windows\\System32\\taskkill.exe",

1116-

["/F", "/T", "/PID", String(stalePid)],

1117-

expect.objectContaining({ timeout: 5000 }),

1123+

expect(mockCall(mockSpawnSync, 0)[0]).toBe("C:\\Windows\\System32\\taskkill.exe");

1124+

expect(mockCall(mockSpawnSync, 0)[1]).toEqual(["/T", "/PID", String(stalePid)]);

1125+

expect(mockCallRecordArg(mockSpawnSync, 0, 2, "taskkill options").timeout).toBe(5000);

1126+

expect(mockCall(mockSpawnSync, 1)[0]).toBe("C:\\Windows\\System32\\taskkill.exe");

1127+

expect(mockCall(mockSpawnSync, 1)[1]).toEqual(["/F", "/T", "/PID", String(stalePid)]);

1128+

expect(mockCallRecordArg(mockSpawnSync, 1, 2, "forced taskkill options").timeout).toBe(

1129+

5000,

11181130

);

11191131

} finally {

11201132

__testing.setSleepSyncOverride(null);