惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

美团技术团队
J
Java Code Geeks
有赞技术团队
有赞技术团队
GbyAI
GbyAI
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
酷 壳 – CoolShell
酷 壳 – CoolShell
博客园 - 叶小钗
阮一峰的网络日志
阮一峰的网络日志
Microsoft Security Blog
Microsoft Security Blog
IT之家
IT之家
G
Google Developers Blog
月光博客
月光博客
Cyber Security Advisories - MS-ISAC
Cyber Security Advisories - MS-ISAC
S
SegmentFault 最新的问题
博客园 - 三生石上(FineUI控件)
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
博客园 - Franky
腾讯CDC
V
Visual Studio Blog
博客园 - 【当耐特】
D
Docker
H
Hackread – Cybersecurity News, Data Breaches, AI and More
Engineering at Meta
Engineering at Meta
L
LangChain Blog

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(auth): reclaim stale file locks · openclaw/openclaw@c...
steipete · 2026-05-14 · via Recent Commits to openclaw:main

@@ -1,4 +1,5 @@

11

import "../infra/fs-safe-defaults.js";

2+

import fs from "node:fs/promises";

23

import {

34

acquireFileLock as acquireFsSafeFileLock,

45

drainFileLockManagerForTest,

@@ -28,14 +29,25 @@ export type FileLockHandle = {

2829

};

29303031

export const FILE_LOCK_TIMEOUT_ERROR_CODE = "file_lock_timeout";

32+

export const FILE_LOCK_STALE_ERROR_CODE = "file_lock_stale";

31333234

export type FileLockTimeoutError = Error & {

3335

code: typeof FILE_LOCK_TIMEOUT_ERROR_CODE;

3436

lockPath: string;

3537

};

363839+

export type FileLockStaleError = Error & {

40+

code: typeof FILE_LOCK_STALE_ERROR_CODE;

41+

lockPath: string;

42+

};

43+3744

const FILE_LOCK_MANAGER_KEY = "openclaw.plugin-sdk.file-lock";

384546+

type LockFileSnapshot = {

47+

raw: string;

48+

payload: Record<string, unknown> | null;

49+

};

50+3951

function readLockPayload(value: Record<string, unknown> | null): LockFilePayload | null {

4052

if (!value) {

4153

return null;

@@ -63,13 +75,98 @@ async function shouldReclaimPluginLock(params: {

6375

return true;

6476

}

657766-

function normalizeTimeoutError(err: unknown): never {

78+

function isFileLockError(error: unknown, code: string): boolean {

79+

return (error as { code?: unknown } | null)?.code === code;

80+

}

81+82+

async function readLockFileSnapshot(lockPath: string): Promise<LockFileSnapshot | null> {

83+

let raw: string;

84+

try {

85+

raw = await fs.readFile(lockPath, "utf8");

86+

} catch (err) {

87+

if ((err as NodeJS.ErrnoException).code === "ENOENT") {

88+

return null;

89+

}

90+

throw err;

91+

}

92+93+

try {

94+

const parsed = JSON.parse(raw) as unknown;

95+

return {

96+

raw,

97+

payload:

98+

parsed && typeof parsed === "object" && !Array.isArray(parsed)

99+

? (parsed as Record<string, unknown>)

100+

: null,

101+

};

102+

} catch {

103+

return { raw, payload: null };

104+

}

105+

}

106+107+

function shouldRemoveReportedStalePluginLock(params: {

108+

payload: Record<string, unknown> | null;

109+

staleMs: number;

110+

nowMs: number;

111+

}): boolean {

112+

const payload = readLockPayload(params.payload);

113+

if (payload?.pid) {

114+

return !isPidAlive(payload.pid);

115+

}

116+

if (payload?.createdAt) {

117+

const createdAt = Date.parse(payload.createdAt);

118+

return !Number.isFinite(createdAt) || params.nowMs - createdAt > params.staleMs;

119+

}

120+

return true;

121+

}

122+123+

async function removeReportedStaleLockIfStillStale(params: {

124+

lockPath: string;

125+

staleMs: number;

126+

}): Promise<boolean> {

127+

const snapshot = await readLockFileSnapshot(params.lockPath);

128+

if (!snapshot) {

129+

return true;

130+

}

131+

if (

132+

!shouldRemoveReportedStalePluginLock({

133+

payload: snapshot.payload,

134+

staleMs: params.staleMs,

135+

nowMs: Date.now(),

136+

})

137+

) {

138+

return false;

139+

}

140+141+

const current = await readLockFileSnapshot(params.lockPath);

142+

if (!current) {

143+

return true;

144+

}

145+

if (current.raw !== snapshot.raw) {

146+

return false;

147+

}

148+149+

try {

150+

await fs.unlink(params.lockPath);

151+

return true;

152+

} catch (err) {

153+

return (err as NodeJS.ErrnoException).code === "ENOENT";

154+

}

155+

}

156+157+

function normalizeLockError(err: unknown): never {

67158

if ((err as { code?: unknown }).code === FILE_LOCK_TIMEOUT_ERROR_CODE) {

68159

throw Object.assign(new Error((err as Error).message), {

69160

code: FILE_LOCK_TIMEOUT_ERROR_CODE,

70161

lockPath: (err as { lockPath?: string }).lockPath ?? "",

71162

}) as FileLockTimeoutError;

72163

}

164+

if ((err as { code?: unknown }).code === FILE_LOCK_STALE_ERROR_CODE) {

165+

throw Object.assign(new Error((err as Error).message), {

166+

code: FILE_LOCK_STALE_ERROR_CODE,

167+

lockPath: (err as { lockPath?: string }).lockPath ?? "",

168+

}) as FileLockStaleError;

169+

}

73170

throw err;

74171

}

75172

@@ -86,18 +183,32 @@ export async function acquireFileLock(

86183

filePath: string,

87184

options: FileLockOptions,

88185

): Promise<FileLockHandle> {

89-

try {

90-

const lock = await acquireFsSafeFileLock(filePath, {

91-

managerKey: FILE_LOCK_MANAGER_KEY,

92-

staleMs: options.stale,

93-

retry: options.retries,

94-

allowReentrant: true,

95-

payload: () => ({ pid: process.pid, createdAt: new Date().toISOString() }),

96-

shouldReclaim: shouldReclaimPluginLock,

97-

});

98-

return { lockPath: lock.lockPath, release: lock.release };

99-

} catch (err) {

100-

return normalizeTimeoutError(err);

186+

while (true) {

187+

try {

188+

const lock = await acquireFsSafeFileLock(filePath, {

189+

managerKey: FILE_LOCK_MANAGER_KEY,

190+

staleMs: options.stale,

191+

retry: options.retries,

192+

allowReentrant: true,

193+

payload: () => ({ pid: process.pid, createdAt: new Date().toISOString() }),

194+

shouldReclaim: shouldReclaimPluginLock,

195+

});

196+

return { lockPath: lock.lockPath, release: lock.release };

197+

} catch (err) {

198+

if (isFileLockError(err, FILE_LOCK_STALE_ERROR_CODE)) {

199+

const lockPath = (err as { lockPath?: string }).lockPath;

200+

if (

201+

lockPath &&

202+

(await removeReportedStaleLockIfStillStale({

203+

lockPath,

204+

staleMs: options.stale,

205+

}))

206+

) {

207+

continue;

208+

}

209+

}

210+

return normalizeLockError(err);

211+

}

101212

}

102213

}

103214