惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

云风的 BLOG
云风的 BLOG
The GitHub Blog
The GitHub Blog
Y
Y Combinator Blog
博客园 - 三生石上(FineUI控件)
T
The Blog of Author Tim Ferriss
宝玉的分享
宝玉的分享
Hugging Face - Blog
Hugging Face - Blog
WordPress大学
WordPress大学
V
Visual Studio Blog
小众软件
小众软件
Cyber Security Advisories - MS-ISAC
Cyber Security Advisories - MS-ISAC
MongoDB | Blog
MongoDB | Blog
V
V2EX
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
博客园 - 【当耐特】
Microsoft Azure Blog
Microsoft Azure Blog
The Cloudflare Blog
H
Hackread – Cybersecurity News, Data Breaches, AI and More
freeCodeCamp Programming Tutorials: Python, JavaScript, Git & More
Engineering at Meta
Engineering at Meta
L
LangChain Blog
Martin Fowler
Martin Fowler
GbyAI
GbyAI
博客园 - 司徒正美

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(cli): reject invalid node run port (#84307) · opencla...
giodl73-repo · 2026-05-22 · via Recent Commits to openclaw:main

@@ -1,8 +1,16 @@

11

import { Command } from "commander";

2-

import { describe, expect, it, vi } from "vitest";

2+

import { beforeEach, describe, expect, it, vi } from "vitest";

33

import { registerNodeCli } from "./register.js";

445+

type LoadNodeHostConfig = typeof import("../../node-host/config.js").loadNodeHostConfig;

6+57

const daemonMocks = vi.hoisted(() => ({

8+

defaultRuntime: {

9+

error: vi.fn(),

10+

exit: vi.fn(),

11+

},

12+

loadNodeHostConfig: vi.fn<LoadNodeHostConfig>(async () => null),

13+

runNodeHost: vi.fn(),

614

runNodeDaemonInstall: vi.fn(),

715

runNodeDaemonRestart: vi.fn(),

816

runNodeDaemonStart: vi.fn(),

@@ -14,11 +22,15 @@ const daemonMocks = vi.hoisted(() => ({

1422

vi.mock("./daemon.js", () => daemonMocks);

15231624

vi.mock("../../node-host/config.js", () => ({

17-

loadNodeHostConfig: vi.fn(async () => null),

25+

loadNodeHostConfig: daemonMocks.loadNodeHostConfig,

1826

}));

19272028

vi.mock("../../node-host/runner.js", () => ({

21-

runNodeHost: vi.fn(),

29+

runNodeHost: daemonMocks.runNodeHost,

30+

}));

31+32+

vi.mock("../../runtime.js", () => ({

33+

defaultRuntime: daemonMocks.defaultRuntime,

2234

}));

23352436

function createProgram(): Command {

@@ -33,11 +45,62 @@ function createProgram(): Command {

3345

}

34463547

describe("registerNodeCli", () => {

48+

beforeEach(() => {

49+

daemonMocks.defaultRuntime.error.mockClear();

50+

daemonMocks.defaultRuntime.exit.mockClear();

51+

daemonMocks.loadNodeHostConfig.mockClear();

52+

daemonMocks.loadNodeHostConfig.mockResolvedValue(null);

53+

daemonMocks.runNodeHost.mockClear();

54+

daemonMocks.runNodeDaemonInstall.mockClear();

55+

daemonMocks.runNodeDaemonRestart.mockClear();

56+

daemonMocks.runNodeDaemonStart.mockClear();

57+

daemonMocks.runNodeDaemonStatus.mockClear();

58+

daemonMocks.runNodeDaemonStop.mockClear();

59+

daemonMocks.runNodeDaemonUninstall.mockClear();

60+

});

61+3662

it("registers node start for the macOS app node service manager", async () => {

3763

const program = createProgram();

38643965

await program.parseAsync(["node", "start", "--json"], { from: "user" });

40664167

expect(daemonMocks.runNodeDaemonStart.mock.calls[0]?.[0]?.json).toBe(true);

4268

});

69+70+

it("rejects an explicit invalid node run port", async () => {

71+

const program = createProgram();

72+73+

await program.parseAsync(["node", "run", "--port", "abc"], { from: "user" });

74+75+

expect(daemonMocks.runNodeHost).not.toHaveBeenCalled();

76+

expect(daemonMocks.defaultRuntime.error).toHaveBeenCalledWith(

77+

expect.stringContaining("Invalid --port"),

78+

);

79+

expect(daemonMocks.defaultRuntime.exit).toHaveBeenCalledWith(1);

80+

});

81+82+

it("uses an explicit valid node run port", async () => {

83+

const program = createProgram();

84+85+

await program.parseAsync(["node", "run", "--port", "19000"], { from: "user" });

86+87+

expect(daemonMocks.runNodeHost).toHaveBeenCalledWith(

88+

expect.objectContaining({ gatewayPort: 19000 }),

89+

);

90+

});

91+92+

it("falls back to configured node run port when --port is omitted", async () => {

93+

daemonMocks.loadNodeHostConfig.mockResolvedValue({

94+

version: 1,

95+

nodeId: "node-existing",

96+

gateway: { host: "10.0.0.2", port: 19001 },

97+

});

98+

const program = createProgram();

99+100+

await program.parseAsync(["node", "run"], { from: "user" });

101+102+

expect(daemonMocks.runNodeHost).toHaveBeenCalledWith(

103+

expect.objectContaining({ gatewayHost: "10.0.0.2", gatewayPort: 19001 }),

104+

);

105+

});

43106

});