fix(test): guard gateway benchmark cli args · openclaw/openclaw@4b2b70e

Recent Commits to openclaw:main

vincentkoc · 2026-06-20 · via Recent Commits to openclaw:main

Original file line number	Diff line number	Diff line change
`@@ -178,6 +178,21 @@ const DEFAULT_TIMEOUT_MS = 30_000;`
`178`	`178`	`const DEFAULT_POST_READY_DELAY_MS = 250;`
`179`	`179`	`const DEFAULT_ENTRY = "dist/entry.js";`
`180`	`180`	`const RESTART_INTENT_FILENAME = "gateway-restart-intent.json";`
	`181`	`+const BOOLEAN_FLAGS = new Set(["--allow-failures", "--help", "-h", "--json"]);`
	`182`	`+const VALUE_FLAGS = new Set([`
	`183`	`+"--case",`
	`184`	`+"--entry",`
	`185`	`+"--output",`
	`186`	`+"--post-ready-delay-ms",`
	`187`	`+"--restarts",`
	`188`	`+"--runs",`
	`189`	`+"--timeout-ms",`
	`190`	`+"--warmup",`
	`191`	`+]);`
	`192`	`+`
	`193`	`+class CliArgumentError extends Error {`
	`194`	`+override name = "CliArgumentError";`
	`195`	`+}`
`181`	`196`
`182`	`197`	`const BASE_CONFIG = {`
`183`	`198`	`browser: { enabled: false },`
`@@ -233,11 +248,26 @@ const GATEWAY_CASES: readonly GatewayBenchCase[] = [`
`233`	`248`	`function readRequiredFlagValue(argv: string[], index: number, flag: string): string {`
`234`	`249`	`const value = argv[index + 1];`
`235`	`250`	`if (!value \|\| value.startsWith("-")) {`
`236`		-throw new Error(`${flag} requires a value`);
	`251`	+throw new CliArgumentError(`${flag} requires a value`);
`237`	`252`	`}`
`238`	`253`	`return value;`
`239`	`254`	`}`
`240`	`255`
	`256`	`+function validateCliArgs(argv: string[]): void {`
	`257`	`+for (let index = 0; index < argv.length; index += 1) {`
	`258`	`+const arg = argv[index] ?? "";`
	`259`	`+if (BOOLEAN_FLAGS.has(arg)) {`
	`260`	`+continue;`
	`261`	`+}`
	`262`	`+if (VALUE_FLAGS.has(arg)) {`
	`263`	`+readRequiredFlagValue(argv, index, arg);`
	`264`	`+index += 1;`
	`265`	`+continue;`
	`266`	`+}`
	`267`	+throw new CliArgumentError(`Unknown argument: ${arg}`);
	`268`	`+}`
	`269`	`+}`
	`270`	`+`
`241`	`271`	`function parseFlagValue(argv: string[], flag: string): string \| undefined {`
`242`	`272`	`for (let index = 0; index < argv.length; index += 1) {`
`243`	`273`	`if (argv[index] === flag) {`
`@@ -319,6 +349,7 @@ function resolveCases(caseIds: string[]): GatewayBenchCase[] {`
`319`	`349`	`}`
`320`	`350`
`321`	`351`	`function parseOptions(argv: string[] = process.argv.slice(2)): CliOptions {`
	`352`	`+validateCliArgs(argv);`
`322`	`353`	`return {`
`323`	`354`	`allowFailures: hasFlag(argv, "--allow-failures"),`
`324`	`355`	`cases: resolveCases(parseRepeatableFlag(argv, "--case")),`
`@@ -1649,13 +1680,19 @@ export const testing = {`
`1649`	`1680`	`shouldFailBenchmark,`
`1650`	`1681`	`stopChild,`
`1651`	`1682`	`summarizeCase,`
	`1683`	`+ validateCliArgs,`
`1652`	`1684`	`waitForRestartProbe,`
`1653`	`1685`	`writeConfig,`
`1654`	`1686`	`writeRestartIntent,`
`1655`	`1687`	`};`
`1656`	`1688`
`1657`	`1689`	`if (import.meta.url === pathToFileURL(process.argv[1] ?? "").href) {`
`1658`	`1690`	`main().catch((err: unknown) => {`
	`1691`	`+if (err instanceof CliArgumentError) {`
	`1692`	`+console.error(err.message);`
	`1693`	`+process.exitCode = 1;`
	`1694`	`+return;`
	`1695`	`+}`
`1659`	`1696`	`console.error(err instanceof Error ? err.stack : String(err));`
`1660`	`1697`	`process.exitCode = 1;`
`1661`	`1698`	`});`

Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,20 @@ const DEFAULT_RUNS = 5;`
`108`	`108`	`const DEFAULT_WARMUP = 1;`
`109`	`109`	`const DEFAULT_TIMEOUT_MS = 30_000;`
`110`	`110`	`const DEFAULT_ENTRY = "dist/entry.js";`
	`111`	`+const BOOLEAN_FLAGS = new Set(["--help", "-h", "--json"]);`
	`112`	`+const VALUE_FLAGS = new Set([`
	`113`	`+"--case",`
	`114`	`+"--cpu-prof-dir",`
	`115`	`+"--entry",`
	`116`	`+"--output",`
	`117`	`+"--runs",`
	`118`	`+"--timeout-ms",`
	`119`	`+"--warmup",`
	`120`	`+]);`
	`121`	`+`
	`122`	`+class CliArgumentError extends Error {`
	`123`	`+override name = "CliArgumentError";`
	`124`	`+}`
`111`	`125`
`112`	`126`	`const BASE_CONFIG = {`
`113`	`127`	`browser: { enabled: false },`
`@@ -187,11 +201,26 @@ const GATEWAY_CASES: readonly GatewayBenchCase[] = [`
`187`	`201`	`function readRequiredFlagValue(argv: string[], index: number, flag: string): string {`
`188`	`202`	`const value = argv[index + 1];`
`189`	`203`	`if (!value \|\| value.startsWith("-")) {`
`190`		-throw new Error(`${flag} requires a value`);
	`204`	+throw new CliArgumentError(`${flag} requires a value`);
`191`	`205`	`}`
`192`	`206`	`return value;`
`193`	`207`	`}`
`194`	`208`
	`209`	`+function validateCliArgs(argv: string[]): void {`
	`210`	`+for (let index = 0; index < argv.length; index += 1) {`
	`211`	`+const arg = argv[index] ?? "";`
	`212`	`+if (BOOLEAN_FLAGS.has(arg)) {`
	`213`	`+continue;`
	`214`	`+}`
	`215`	`+if (VALUE_FLAGS.has(arg)) {`
	`216`	`+readRequiredFlagValue(argv, index, arg);`
	`217`	`+index += 1;`
	`218`	`+continue;`
	`219`	`+}`
	`220`	+throw new CliArgumentError(`Unknown argument: ${arg}`);
	`221`	`+}`
	`222`	`+}`
	`223`	`+`
`195`	`224`	`function parseFlagValue(argv: string[], flag: string): string \| undefined {`
`196`	`225`	`for (let index = 0; index < argv.length; index += 1) {`
`197`	`226`	`if (argv[index] === flag) {`
`@@ -265,6 +294,7 @@ function resolveCases(caseIds: string[]): GatewayBenchCase[] {`
`265`	`294`	`}`
`266`	`295`
`267`	`296`	`function parseOptions(argv: string[] = process.argv.slice(2)): CliOptions {`
	`297`	`+validateCliArgs(argv);`
`268`	`298`	`return {`
`269`	`299`	`cases: resolveCases(parseRepeatableFlag(argv, "--case")),`
`270`	`300`	`cpuProfDir: parseFlagValue(argv, "--cpu-prof-dir"),`
`@@ -965,12 +995,18 @@ export const testing = {`
`965`	`995`	`sanitizedEnv,`
`966`	`996`	`stopChild,`
`967`	`997`	`summarizeCase,`
	`998`	`+ validateCliArgs,`
`968`	`999`	`waitForProbe,`
`969`	`1000`	`writeConfig,`
`970`	`1001`	`};`
`971`	`1002`
`972`	`1003`	`if (import.meta.url === pathToFileURL(process.argv[1] ?? "").href) {`
`973`	`1004`	`main().catch((err: unknown) => {`
	`1005`	`+if (err instanceof CliArgumentError) {`
	`1006`	`+console.error(err.message);`
	`1007`	`+process.exitCode = 1;`
	`1008`	`+return;`
	`1009`	`+}`
`974`	`1010`	`console.error(err instanceof Error ? err.stack : String(err));`
`975`	`1011`	`process.exitCode = 1;`
`976`	`1012`	`});`

Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,7 @@ describe("gateway restart benchmark script", () => {`
`42`	`42`	`});`
`43`	`43`
`44`	`44`	`it("rejects ambiguous benchmark CLI values before spawning Node", () => {`
	`45`	`+expect(() => testing.parseOptions(["--wat"])).toThrow("Unknown argument: --wat");`
`45`	`46`	`expect(testing.parsePositiveInt("5", 1, "--restarts")).toBe(5);`
`46`	`47`	`expect(testing.parseNonNegativeInt("0", 1, "--warmup")).toBe(0);`
`47`	`48`	`expect(`
`@@ -73,6 +74,26 @@ describe("gateway restart benchmark script", () => {`
`73`	`74`	`expect(() => testing.resolveEntry("--inspect")).toThrow(/must be a file path/u);`
`74`	`75`	`});`
`75`	`76`
	`77`	`+it("rejects unknown benchmark CLI args before checking platform or running cases", () => {`
	`78`	`+const result = spawnSync(`
	`79`	`+process.execPath,`
	`80`	`+["--import", "tsx", "scripts/bench-gateway-restart.ts", "--wat"],`
	`81`	`+{`
	`82`	`+cwd: process.cwd(),`
	`83`	`+encoding: "utf8",`
	`84`	`+env: {`
	`85`	`+ ...process.env,`
	`86`	`+NODE_NO_WARNINGS: "1",`
	`87`	`+},`
	`88`	`+},`
	`89`	`+);`
	`90`	`+`
	`91`	`+expect(result.status).toBe(1);`
	`92`	`+expect(result.stdout).toBe("");`
	`93`	`+expect(result.stderr.trim()).toBe("Unknown argument: --wat");`
	`94`	`+expect(result.stderr).not.toContain("\n at ");`
	`95`	`+});`
	`96`	`+`
`76`	`97`	`it("guards the SIGUSR1 restart benchmark on Windows", () => {`
`77`	`98`	`expect(() => testing.ensureSupportedRestartPlatform("linux")).not.toThrow();`
`78`	`99`	`expect(() => testing.ensureSupportedRestartPlatform("darwin")).not.toThrow();`

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,7 @@ describe("gateway startup benchmark script", () => {`
`52`	`52`	`});`
`53`	`53`
`54`	`54`	`it("rejects ambiguous benchmark CLI values before spawning Node", () => {`
	`55`	`+expect(() => testing.parseOptions(["--wat"])).toThrow("Unknown argument: --wat");`
`55`	`56`	`expect(testing.parsePositiveInt("5", 1, "--runs")).toBe(5);`
`56`	`57`	`expect(testing.parseNonNegativeInt("0", 1, "--warmup")).toBe(0);`
`57`	`58`	`expect(`
`@@ -83,6 +84,26 @@ describe("gateway startup benchmark script", () => {`
`83`	`84`	`expect(() => testing.resolveEntry("--inspect")).toThrow(/must be a file path/u);`
`84`	`85`	`});`
`85`	`86`
	`87`	`+it("rejects unknown benchmark CLI args before running cases", () => {`
	`88`	`+const result = spawnSync(`
	`89`	`+process.execPath,`
	`90`	`+["--import", "tsx", "scripts/bench-gateway-startup.ts", "--wat"],`
	`91`	`+{`
	`92`	`+cwd: process.cwd(),`
	`93`	`+encoding: "utf8",`
	`94`	`+env: {`
	`95`	`+ ...process.env,`
	`96`	`+NODE_NO_WARNINGS: "1",`
	`97`	`+},`
	`98`	`+},`
	`99`	`+);`
	`100`	`+`
	`101`	`+expect(result.status).toBe(1);`
	`102`	`+expect(result.stdout).toBe("");`
	`103`	`+expect(result.stderr.trim()).toBe("Unknown argument: --wat");`
	`104`	`+expect(result.stderr).not.toContain("\n at ");`
	`105`	`+});`
	`106`	`+`
`86`	`107`	`it("does not disable local-check policy in the child gateway environment", () => {`
`87`	`108`	`const env = testing.sanitizedEnv("/tmp/openclaw-bench", "/tmp/openclaw-bench/config.json", {`
`88`	`109`	`config: {},`

此内容由惯性聚合(RSS阅读器)自动聚合整理，仅供阅读参考。原文来自 — 版权归原作者所有。

推荐订阅源

Recent Commits to openclaw:main