惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

Y
Y Combinator Blog
有赞技术团队
有赞技术团队
J
Java Code Geeks
H
Hackread – Cybersecurity News, Data Breaches, AI and More
美团技术团队
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻
Hugging Face - Blog
Hugging Face - Blog
人人都是产品经理
人人都是产品经理
酷 壳 – CoolShell
酷 壳 – CoolShell
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
C
Check Point Blog
博客园 - 【当耐特】
The GitHub Blog
The GitHub Blog
Recent Announcements
Recent Announcements
The Cloudflare Blog
Microsoft Azure Blog
Microsoft Azure Blog
腾讯CDC
Vercel News
Vercel News
IT之家
IT之家
MyScale Blog
MyScale Blog
博客园_首页
Martin Fowler
Martin Fowler
WordPress大学
WordPress大学
罗磊的独立博客

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(e2e): prove gateway health after websocket connect · ...
vincentkoc · 2026-05-31 · via Recent Commits to openclaw:main
Original file line numberDiff line numberDiff line change

@@ -57,6 +57,7 @@ Docs: https://docs.openclaw.ai

5757

- CI/tooling: route script edits through conventional owner tests when matching `test/scripts` or `src/scripts` coverage already exists.

5858

- CI/tooling: honor option terminators in the memory FD repro script so follow-on arguments are not reparsed.

5959

- Release/CI/E2E: assert plugin lifecycle runtime inspect output instead of only capturing it.

60+

- Release/CI/E2E: make gateway-network prove the advertised health RPC and retry early WebSocket closes without burning full open timeouts.

6061

- Release/CI/E2E: honor option terminators across release, Parallels smoke, plugin gauntlet, and extension-memory scripts.

6162

- Release/CI/E2E: fail plugin gateway gauntlet QA chunks when the requested suite summary is missing or invalid.

6263

- Performance: prebuild QA runtime probes with generated plugin assets but without CLI startup metadata.

Original file line numberDiff line numberDiff line change

@@ -40,6 +40,22 @@ function onceFrame(ws, filter, timeoutMs = 10_000) {

4040

});

4141

}

4242
43+

function responseError(method, response) {

44+

const message = response.error?.message ?? "unknown";

45+

return new Error(`${method} failed: ${message}`);

46+

}

47+
48+

function isRetryableStartupError(message) {

49+

return (

50+

message.includes("gateway starting") ||

51+

message.includes("closed before open") ||

52+

message.includes("ws open timeout") ||

53+

message.includes("ECONNREFUSED") ||

54+

message.includes("ECONNRESET") ||

55+

message.includes("timeout")

56+

);

57+

}

58+
4359

let lastError;

4460

while (Date.now() < deadline) {

4561

let ws;

@@ -67,33 +83,28 @@ while (Date.now() < deadline) {

6783

);

6884
6985

const connectRes = await onceFrame(ws, (frame) => frame?.type === "res" && frame?.id === "c1");

70-

if (connectRes.ok) {

71-

ws.close();

72-

console.log("ok");

73-

process.exit(0);

74-

}

86+

if (!connectRes.ok) {

87+

lastError = responseError("connect", connectRes);

88+

if (!isRetryableStartupError(lastError.message)) {

89+

throw lastError;

90+

}

91+

} else {

92+

ws.send(JSON.stringify({ type: "req", id: "h1", method: "health" }));

93+

const healthRes = await onceFrame(

94+

ws,

95+

(frame) => frame?.type === "res" && frame?.id === "h1",

96+

);

97+

if (healthRes.ok) {

98+

ws.close();

99+

console.log("ok");

100+

process.exit(0);

101+

}

75102
76-

const message = connectRes.error?.message ?? "unknown";

77-

lastError = new Error(`connect failed: ${message}`);

78-

if (

79-

!message.includes("gateway starting") &&

80-

!message.includes("ws open timeout") &&

81-

!message.includes("ECONNREFUSED") &&

82-

!message.includes("ECONNRESET") &&

83-

!message.includes("timeout")

84-

) {

85-

throw lastError;

103+

throw responseError("health", healthRes);

86104

}

87105

} catch (error) {

88106

lastError = error instanceof Error ? error : new Error(String(error));

89-

const message = lastError.message;

90-

if (

91-

!message.includes("gateway starting") &&

92-

!message.includes("ws open timeout") &&

93-

!message.includes("ECONNREFUSED") &&

94-

!message.includes("ECONNRESET") &&

95-

!message.includes("timeout")

96-

) {

107+

if (!isRetryableStartupError(lastError.message)) {

97108

throw lastError;

98109

}

99110

} finally {

Original file line numberDiff line numberDiff line change

@@ -1,3 +1,19 @@

1+

function formatCloseValue(value) {

2+

if (value === undefined || value === null) {

3+

return "";

4+

}

5+

if (typeof value === "string") {

6+

return value;

7+

}

8+

if (typeof value === "number" || typeof value === "boolean" || typeof value === "bigint") {

9+

return value.toString();

10+

}

11+

if (value instanceof Uint8Array) {

12+

return Buffer.from(value).toString();

13+

}

14+

return JSON.stringify(value) ?? "";

15+

}

16+
117

export function waitForWebSocketOpen(ws, timeoutMs, message = "ws open timeout") {

218

return new Promise((resolve, reject) => {

319

let settled = false;

@@ -10,11 +26,19 @@ export function waitForWebSocketOpen(ws, timeoutMs, message = "ws open timeout")

1026

clearTimeout(timer);

1127

ws.off?.("open", onOpen);

1228

ws.off?.("error", onError);

29+

ws.off?.("close", onClose);

1330

fn(value);

1431

};

1532

const onOpen = () => settle(resolve);

1633

const onError = (error) =>

1734

settle(reject, error instanceof Error ? error : new Error(String(error)));

35+

const onClose = (code, reason) => {

36+

const closeDetails = [formatCloseValue(code), formatCloseValue(reason)]

37+

.filter(Boolean)

38+

.join(" ");

39+

const suffix = closeDetails ? `: ${closeDetails}` : "";

40+

settle(reject, new Error(`closed before open${suffix}`));

41+

};

1842

const timer = setTimeout(() => {

1943

const consumeAbortError = () => {};

2044

const removeAbortErrorConsumer = () => {

@@ -23,6 +47,7 @@ export function waitForWebSocketOpen(ws, timeoutMs, message = "ws open timeout")

2347

};

2448

try {

2549

ws.off?.("error", onError);

50+

ws.off?.("close", onClose);

2651

ws.on?.("error", consumeAbortError);

2752

ws.once?.("close", removeAbortErrorConsumer);

2853

ws.terminate?.();

@@ -37,5 +62,6 @@ export function waitForWebSocketOpen(ws, timeoutMs, message = "ws open timeout")

3762

timer.unref?.();

3863

ws.once("open", onOpen);

3964

ws.once("error", onError);

65+

ws.once("close", onClose);

4066

});

4167

}

Original file line numberDiff line numberDiff line change

@@ -300,6 +300,7 @@ function isRetryableGatewayConnectError(error: Error): boolean {

300300

return (

301301

message.includes("gateway ws open timeout") ||

302302

message.includes("gateway connect timeout") ||

303+

message.includes("closed before open") ||

303304

message.includes("gateway closed") ||

304305

message.includes("econnrefused") ||

305306

message.includes("socket hang up")

Original file line numberDiff line numberDiff line change

@@ -6,6 +6,22 @@ type WebSocketOpenHandle = {

66

terminate?: () => void;

77

};

88
9+

function formatCloseValue(value: unknown): string {

10+

if (value === undefined || value === null) {

11+

return "";

12+

}

13+

if (typeof value === "string") {

14+

return value;

15+

}

16+

if (typeof value === "number" || typeof value === "boolean" || typeof value === "bigint") {

17+

return value.toString();

18+

}

19+

if (value instanceof Uint8Array) {

20+

return Buffer.from(value).toString();

21+

}

22+

return JSON.stringify(value) ?? "";

23+

}

24+
925

export function waitForWebSocketOpen(

1026

ws: WebSocketOpenHandle,

1127

timeoutMs: number,

@@ -19,6 +35,7 @@ export function waitForWebSocketOpen(

1935

clearTimeout(timer);

2036

ws.off?.("open", onOpen);

2137

ws.off?.("error", onError);

38+

ws.off?.("close", onClose);

2239

};

2340

const resolveOpen = () => {

2441

if (settled) {

@@ -38,6 +55,13 @@ export function waitForWebSocketOpen(

3855

};

3956

const onOpen = () => resolveOpen();

4057

const onError = (error: unknown) => rejectOpen(error);

58+

const onClose = (code?: unknown, reason?: unknown) => {

59+

const closeDetails = [formatCloseValue(code), formatCloseValue(reason)]

60+

.filter(Boolean)

61+

.join(" ");

62+

const suffix = closeDetails ? `: ${closeDetails}` : "";

63+

rejectOpen(new Error(`closed before open${suffix}`));

64+

};

4165

timer = setTimeout(() => {

4266

const consumeAbortError = () => {};

4367

const removeAbortErrorConsumer = () => {

@@ -46,6 +70,7 @@ export function waitForWebSocketOpen(

4670

};

4771

try {

4872

ws.off?.("error", onError);

73+

ws.off?.("close", onClose);

4974

ws.on?.("error", consumeAbortError);

5075

ws.once?.("close", removeAbortErrorConsumer);

5176

ws.terminate?.();

@@ -60,5 +85,6 @@ export function waitForWebSocketOpen(

6085

timer.unref?.();

6186

ws.once("open", onOpen);

6287

ws.once("error", onError);

88+

ws.once("close", onClose);

6389

});

6490

}

Original file line numberDiff line numberDiff line change

@@ -33,6 +33,7 @@ describe("E2E WebSocket open guard", () => {

3333

expect(ws.terminated).toBe(true);

3434

expect(ws.listenerCount("open")).toBe(0);

3535

expect(ws.listenerCount("error")).toBe(0);

36+

expect(ws.listenerCount("close")).toBe(0);

3637

});

3738
3839

it("uses caller-specific timeout messages", async () => {

@@ -58,5 +59,19 @@ describe("E2E WebSocket open guard", () => {

5859

expect(ws.terminated).toBe(false);

5960

expect(ws.listenerCount("open")).toBe(0);

6061

expect(ws.listenerCount("error")).toBe(0);

62+

expect(ws.listenerCount("close")).toBe(0);

63+

});

64+
65+

it("rejects immediately when the socket closes before opening", async () => {

66+

const ws = new FakeWebSocket();

67+

const opened = waitForWebSocketOpen(ws, 1000);

68+
69+

ws.emit("close", 1006, Buffer.from("bye"));

70+
71+

await expect(opened).rejects.toThrow("closed before open: 1006 bye");

72+

expect(ws.terminated).toBe(false);

73+

expect(ws.listenerCount("open")).toBe(0);

74+

expect(ws.listenerCount("error")).toBe(0);

75+

expect(ws.listenerCount("close")).toBe(0);

6176

});

6277

});

Original file line numberDiff line numberDiff line change

@@ -1,3 +1,4 @@

1+

import { readFileSync } from "node:fs";

12

import { describe, expect, it } from "vitest";

23

import { readGatewayNetworkClientConnectTimeoutMs } from "../../scripts/e2e/lib/gateway-network/limits.mjs";

34

@@ -33,4 +34,15 @@ describe("gateway network WebSocket open guard", () => {

3334

}),

3435

).toBe(3000);

3536

});

37+
38+

it("proves health after the authenticated connect handshake", () => {

39+

const client = readFileSync("scripts/e2e/lib/gateway-network/client.mjs", "utf8");

40+

const connectIndex = client.indexOf('method: "connect"');

41+

const healthIndex = client.indexOf('method: "health"');

42+
43+

expect(connectIndex).toBeGreaterThanOrEqual(0);

44+

expect(healthIndex).toBeGreaterThan(connectIndex);

45+

expect(client).toContain('responseError("health", healthRes)');

46+

expect(client).toContain('message.includes("closed before open")');

47+

});

3648

});

Original file line numberDiff line numberDiff line change

@@ -38,6 +38,7 @@ describe("mcp channel WebSocket open guard", () => {

3838

expect(ws.terminated).toBe(true);

3939

expect(ws.listenerCount("open")).toBe(0);

4040

expect(ws.listenerCount("error")).toBe(0);

41+

expect(ws.listenerCount("close")).toBe(0);

4142

});

4243
4344

it("cleans listeners after successful opens", async () => {

@@ -50,5 +51,19 @@ describe("mcp channel WebSocket open guard", () => {

5051

expect(ws.terminated).toBe(false);

5152

expect(ws.listenerCount("open")).toBe(0);

5253

expect(ws.listenerCount("error")).toBe(0);

54+

expect(ws.listenerCount("close")).toBe(0);

55+

});

56+
57+

it("rejects immediately when the socket closes before opening", async () => {

58+

const ws = new FakeWebSocket();

59+

const opened = waitForWebSocketOpen(ws, 1000);

60+
61+

ws.emit("close", 1006, Buffer.from("bye"));

62+
63+

await expect(opened).rejects.toThrow("closed before open: 1006 bye");

64+

expect(ws.terminated).toBe(false);

65+

expect(ws.listenerCount("open")).toBe(0);

66+

expect(ws.listenerCount("error")).toBe(0);

67+

expect(ws.listenerCount("close")).toBe(0);

5368

});

5469

});