fix(commitments): guard extraction prompt timestamps · op...

Recent Commits to openclaw:main

steipete · 2026-05-30 · via Recent Commits to openclaw:main

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@ describe("commitment extraction", () => {`
`17`	`17`	`const nowMs = Date.parse("2026-04-29T16:00:00.000Z");`
`18`	`18`
`19`	`19`	`afterEach(async () => {`
	`20`	`+vi.restoreAllMocks();`
`20`	`21`	`vi.unstubAllEnvs();`
`21`	`22`	`await Promise.all(tmpDirs.map((dir) => fs.rm(dir, { recursive: true, force: true })));`
`22`	`23`	`tmpDirs.length = 0;`
`@@ -113,6 +114,38 @@ describe("commitment extraction", () => {`
`113`	`114`	`expect(prompt).not.toContain("thread-secret");`
`114`	`115`	`});`
`115`	`116`
	`117`	`+it("does not throw on out-of-range extraction prompt timestamps", () => {`
	`118`	`+vi.spyOn(Date, "now").mockReturnValue(Date.parse("2026-05-30T12:00:00.000Z"));`
	`119`	`+`
	`120`	`+const prompt = buildCommitmentExtractionPrompt({`
	`121`	`+items: [`
	`122`	`+item({`
	`123`	`+nowMs: 8_640_000_000_000_001,`
	`124`	`+existingPending: [`
	`125`	`+{`
	`126`	`+kind: "event_check_in",`
	`127`	`+reason: "valid pending",`
	`128`	`+dedupeKey: "valid",`
	`129`	`+earliestMs: Date.parse("2026-05-31T12:00:00.000Z"),`
	`130`	`+latestMs: Date.parse("2026-05-31T13:00:00.000Z"),`
	`131`	`+},`
	`132`	`+{`
	`133`	`+kind: "open_loop",`
	`134`	`+reason: "invalid pending",`
	`135`	`+dedupeKey: "invalid",`
	`136`	`+earliestMs: 8_640_000_000_000_001,`
	`137`	`+latestMs: 8_640_000_000_000_001,`
	`138`	`+},`
	`139`	`+],`
	`140`	`+}),`
	`141`	`+],`
	`142`	`+});`
	`143`	`+`
	`144`	`+expect(prompt).toContain('"now": "2026-05-30T12:00:00.000Z"');`
	`145`	`+expect(prompt).toContain('"dedupeKey": "valid"');`
	`146`	`+expect(prompt).not.toContain('"dedupeKey": "invalid"');`
	`147`	`+});`
	`148`	`+`
`116`	`149`	`it("rejects disabled, low-confidence, and non-future candidates", () => {`
`117`	`150`	`const cfg: OpenClawConfig = { commitments: { enabled: true } };`
`118`	`151`	`const valid = validateCommitmentCandidates({`

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`import { resolveAgentConfig } from "../agents/agent-scope.js";`
`2`	`2`	`import type { OpenClawConfig } from "../config/config.js";`
`3`	`3`	`import { resolveHeartbeatIntervalMs } from "../infra/heartbeat-summary.js";`
`4`		`-import { asFiniteNumber } from "../shared/number-coercion.js";`
	`4`	`+import { asFiniteNumber, timestampMsToIsoString } from "../shared/number-coercion.js";`
`5`	`5`	`import { normalizeOptionalString as asString } from "../shared/string-coerce.js";`
`6`	`6`	`import { isRecord } from "../utils.js";`
`7`	`7`	`import { resolveCommitmentsConfig } from "./config.js";`
`@@ -179,13 +179,30 @@ export async function hydrateCommitmentExtractionItem(params: {`
`179`	`179`	`}`
`180`	`180`
`181`	`181`	`function formatExistingPending(item: CommitmentExtractionItem) {`
`182`		`-return item.existingPending.map((commitment) => ({`
`183`		`-kind: commitment.kind,`
`184`		`-reason: commitment.reason,`
`185`		`-dedupeKey: commitment.dedupeKey,`
`186`		`-earliest: new Date(commitment.earliestMs).toISOString(),`
`187`		`-latest: new Date(commitment.latestMs).toISOString(),`
`188`		`-}));`
	`182`	`+return item.existingPending.flatMap((commitment) => {`
	`183`	`+const earliest = timestampMsToIsoString(commitment.earliestMs);`
	`184`	`+const latest = timestampMsToIsoString(commitment.latestMs);`
	`185`	`+if (!earliest \|\| !latest) {`
	`186`	`+return [];`
	`187`	`+}`
	`188`	`+return [`
	`189`	`+{`
	`190`	`+kind: commitment.kind,`
	`191`	`+reason: commitment.reason,`
	`192`	`+dedupeKey: commitment.dedupeKey,`
	`193`	`+ earliest,`
	`194`	`+ latest,`
	`195`	`+},`
	`196`	`+];`
	`197`	`+});`
	`198`	`+}`
	`199`	`+`
	`200`	`+function formatExtractionNow(valueMs: unknown): string {`
	`201`	`+return (`
	`202`	`+timestampMsToIsoString(valueMs) ??`
	`203`	`+timestampMsToIsoString(Date.now()) ??`
	`204`	`+"1970-01-01T00:00:00.000Z"`
	`205`	`+);`
`189`	`206`	`}`
`190`	`207`
`191`	`208`	`export function buildCommitmentExtractionPrompt(params: {`
`@@ -194,7 +211,7 @@ export function buildCommitmentExtractionPrompt(params: {`
`194`	`211`	`}): string {`
`195`	`212`	`const items = params.items.map((item) => ({`
`196`	`213`	`itemId: item.itemId,`
`197`		`-now: new Date(item.nowMs).toISOString(),`
	`214`	`+now: formatExtractionNow(item.nowMs),`
`198`	`215`	`timezone: item.timezone,`
`199`	`216`	`latestUserMessage: item.userText,`
`200`	`217`	`assistantResponse: item.assistantText ?? "",`

此内容由惯性聚合(RSS阅读器)自动聚合整理，仅供阅读参考。原文来自 — 版权归原作者所有。

推荐订阅源

Recent Commits to openclaw:main