惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

The GitHub Blog
The GitHub Blog
Jina AI
Jina AI
月光博客
月光博客
博客园 - Franky
小众软件
小众软件
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
V
Visual Studio Blog
有赞技术团队
有赞技术团队
V
V2EX
IT之家
IT之家
阮一峰的网络日志
阮一峰的网络日志
Stack Overflow Blog
Stack Overflow Blog
H
Help Net Security
Apple Machine Learning Research
Apple Machine Learning Research
腾讯CDC
D
DataBreaches.Net
Hugging Face - Blog
Hugging Face - Blog
Martin Fowler
Martin Fowler
罗磊的独立博客
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻
WordPress大学
WordPress大学
C
Check Point Blog
Microsoft Azure Blog
Microsoft Azure Blog
Microsoft Security Blog
Microsoft Security Blog

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(qa): reject loose cron cleanup probe pids · openclaw/...
vincentkoc · 2026-06-17 · via Recent Commits to openclaw:main
Original file line numberDiff line numberDiff line change

@@ -35,11 +35,18 @@ export function assertCronFinishedOk(finished: CronFinishedPayload | undefined):

3535

}

3636

}

3737
38+

function parseProbePid(raw: string): number | undefined {

39+

const text = raw.trim();

40+

if (!/^[1-9]\d*$/u.test(text)) {

41+

return undefined;

42+

}

43+

const pid = Number(text);

44+

return Number.isSafeInteger(pid) ? pid : undefined;

45+

}

46+
3847

async function readProbePid(pidPath: string): Promise<number | undefined> {

3948

try {

40-

const raw = (await fs.readFile(pidPath, "utf-8")).trim();

41-

const pid = Number.parseInt(raw, 10);

42-

return Number.isInteger(pid) && pid > 0 ? pid : undefined;

49+

return parseProbePid(await fs.readFile(pidPath, "utf-8"));

4350

} catch {

4451

return undefined;

4552

}

@@ -51,8 +58,8 @@ async function readProbePids(pidsPath: string): Promise<number[]> {

5158

const pids: number[] = [];

5259

const seen = new Set<number>();

5360

for (const line of raw.split(/\r?\n/)) {

54-

const pid = Number.parseInt(line.trim(), 10);

55-

if (!Number.isInteger(pid) || pid <= 0 || seen.has(pid)) {

61+

const pid = parseProbePid(line);

62+

if (pid === undefined || seen.has(pid)) {

5663

continue;

5764

}

5865

seen.add(pid);

Original file line numberDiff line numberDiff line change

@@ -37,6 +37,20 @@ describe("cron MCP cleanup docker client", () => {

3737

}

3838

});

3939
40+

it("does not parse malformed probe pid prefixes", async () => {

41+

const root = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-cron-mcp-client-"));

42+

try {

43+

const pidPath = path.join(root, "probe.pid");

44+

fs.writeFileSync(pidPath, "123abc\n", "utf8");

45+
46+

const startedAt = Date.now();

47+

await expect(waitForProbePid(pidPath, { pollMs: 1, timeoutMs: 20 })).resolves.toBeUndefined();

48+

expect(Date.now() - startedAt).toBeLessThan(1000);

49+

} finally {

50+

fs.rmSync(root, { force: true, recursive: true });

51+

}

52+

});

53+
4054

it("accepts cron finished events only when the run status is ok", () => {

4155

expect(() => assertCronFinishedOk({ status: "ok" })).not.toThrow();

4256

expect(() => assertCronFinishedOk({ status: "error" })).toThrow(