惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

B
Blog
量子位
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
Last Week in AI
Last Week in AI
酷 壳 – CoolShell
酷 壳 – CoolShell
人人都是产品经理
人人都是产品经理
Jina AI
Jina AI
雷峰网
雷峰网
博客园_首页
WordPress大学
WordPress大学
博客园 - 司徒正美
爱范儿
爱范儿
博客园 - 聂微东
IT之家
IT之家
美团技术团队
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
博客园 - 三生石上(FineUI控件)
有赞技术团队
有赞技术团队
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻
T
Tailwind CSS Blog
博客园 - Franky
V
V2EX
GbyAI
GbyAI
阮一峰的网络日志
阮一峰的网络日志

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(signal): use brew for macos signal-cli install (#9690...
RomneyDa · 2026-06-26 · via Recent Commits to openclaw:main

@@ -5,20 +5,36 @@ import path from "node:path";

55

import JSZip from "jszip";

66

import type { RuntimeEnv } from "openclaw/plugin-sdk/runtime-env";

77

import * as tar from "tar";

8-

import { beforeEach, describe, expect, it, vi } from "vitest";

8+

import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";

99

import type { ReleaseAsset } from "./install-signal-cli.js";

101011-

const { fetchWithSsrFGuardMock } = vi.hoisted(() => ({

12-

fetchWithSsrFGuardMock: vi.fn(),

13-

}));

11+

const { fetchWithSsrFGuardMock, resolveBrewExecutableMock, runPluginCommandWithTimeoutMock } =

12+

vi.hoisted(() => ({

13+

fetchWithSsrFGuardMock: vi.fn(),

14+

resolveBrewExecutableMock: vi.fn(),

15+

runPluginCommandWithTimeoutMock: vi.fn(),

16+

}));

14171518

vi.mock("openclaw/plugin-sdk/ssrf-runtime", () => ({

1619

fetchWithSsrFGuard: fetchWithSsrFGuardMock,

1720

}));

182122+

vi.mock("openclaw/plugin-sdk/setup-tools", async (importOriginal) => {

23+

const actual = await importOriginal<typeof import("openclaw/plugin-sdk/setup-tools")>();

24+

return {

25+

...actual,

26+

resolveBrewExecutable: resolveBrewExecutableMock,

27+

};

28+

});

29+30+

vi.mock("openclaw/plugin-sdk/run-command", () => ({

31+

runPluginCommandWithTimeout: runPluginCommandWithTimeoutMock,

32+

}));

33+1934

const {

2035

downloadToFile,

2136

extractSignalCliArchive,

37+

installSignalCli,

2238

installSignalCliFromRelease,

2339

looksLikeArchive,

2440

pickAsset,

@@ -74,6 +90,8 @@ async function withTempFile(run: (filePath: string) => Promise<void>) {

74907591

beforeEach(() => {

7692

fetchWithSsrFGuardMock.mockReset();

93+

resolveBrewExecutableMock.mockReset();

94+

runPluginCommandWithTimeoutMock.mockReset();

7795

});

78967997

function requireAsset(asset: ReleaseAsset | undefined, label: string): ReleaseAsset {

@@ -143,6 +161,25 @@ describe("pickAsset", () => {

143161

const result = requireAsset(pickAsset(SAMPLE_ASSETS, "darwin", "x64"), "darwin x64");

144162

expect(result.name).toContain("macOS-native");

145163

});

164+165+

it("does not fall back to Linux client archives when macOS assets are absent", () => {

166+

const currentUpstreamAssets: ReleaseAsset[] = [

167+

{

168+

name: "signal-cli-0.14.5-Linux-client.tar.gz",

169+

browser_download_url: "https://example.com/linux-client.tar.gz",

170+

},

171+

{

172+

name: "signal-cli-0.14.5-Linux-native.tar.gz",

173+

browser_download_url: "https://example.com/linux-native.tar.gz",

174+

},

175+

{

176+

name: "signal-cli-0.14.5.tar.gz",

177+

browser_download_url: "https://example.com/jvm.tar.gz",

178+

},

179+

];

180+181+

expect(pickAsset(currentUpstreamAssets, "darwin", "arm64")).toBeUndefined();

182+

});

146183

});

147184148185

describe("win32", () => {

@@ -305,6 +342,46 @@ describe("installSignalCliFromRelease", () => {

305342

});

306343

});

307344345+

describe("installSignalCli", () => {

346+

const originalPlatform = process.platform;

347+

const originalArch = process.arch;

348+349+

function setProcessPlatform(platform: NodeJS.Platform, arch: string) {

350+

Object.defineProperty(process, "platform", { configurable: true, value: platform });

351+

Object.defineProperty(process, "arch", { configurable: true, value: arch });

352+

}

353+354+

afterEach(() => {

355+

Object.defineProperty(process, "platform", { configurable: true, value: originalPlatform });

356+

Object.defineProperty(process, "arch", { configurable: true, value: originalArch });

357+

});

358+359+

it("uses Homebrew on macOS instead of downloading the first GitHub release archive", async () => {

360+

setProcessPlatform("darwin", "arm64");

361+

const brewPrefix = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-signal-brew-"));

362+

await fs.mkdir(path.join(brewPrefix, "bin"), { recursive: true });

363+

await fs.writeFile(path.join(brewPrefix, "bin", "signal-cli"), "");

364+

resolveBrewExecutableMock.mockReturnValue("/opt/homebrew/bin/brew");

365+

runPluginCommandWithTimeoutMock

366+

.mockResolvedValueOnce({ code: 0, stdout: "", stderr: "" })

367+

.mockResolvedValueOnce({ code: 0, stdout: `${brewPrefix}\n`, stderr: "" })

368+

.mockResolvedValueOnce({ code: 0, stdout: "signal-cli 0.14.5\n", stderr: "" });

369+370+

try {

371+

const result = await installSignalCli({ log: vi.fn() } as unknown as RuntimeEnv);

372+373+

expect(result).toEqual({

374+

ok: true,

375+

cliPath: path.join(brewPrefix, "bin", "signal-cli"),

376+

version: "0.14.5",

377+

});

378+

expect(fetchWithSsrFGuardMock).not.toHaveBeenCalled();

379+

} finally {

380+

await fs.rm(brewPrefix, { recursive: true, force: true });

381+

}

382+

});

383+

});

384+308385

describe("extractSignalCliArchive", () => {

309386

async function withArchiveWorkspace(run: (workDir: string) => Promise<void>) {

310387

const workDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-signal-install-"));