chore(lint): enable stricter error rules · openclaw/openc...

Recent Commits to openclaw:main

steipete · 2026-06-01 · via Recent Commits to openclaw:main

File tree

- mattermost/src/mattermost
- - - bundled-plugin-install-uninstall
    - openai-web-search-minimal

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,10 @@`
`82`	`82`	`"typescript/no-meaningless-void-operator": "error",`
`83`	`83`	`"typescript/no-misused-promises": "error",`
`84`	`84`	`"typescript/no-inferrable-types": "error",`
	`85`	`+"typescript/only-throw-error": "error",`
`85`	`86`	`"typescript/no-non-null-asserted-nullish-coalescing": "error",`
	`87`	`+"typescript/prefer-promise-reject-errors": "error",`
	`88`	`+"typescript/restrict-plus-operands": "error",`
`86`	`89`	`"typescript/no-unnecessary-qualifier": "error",`
`87`	`90`	`"typescript/no-unnecessary-type-assertion": "error",`
`88`	`91`	`"typescript/no-unnecessary-type-arguments": "error",`
`@@ -109,6 +112,8 @@`
`109`	`112`	`"typescript/require-array-sort-compare": "error",`
`110`	`113`	`"typescript/restrict-template-expressions": "error",`
`111`	`114`	`"typescript/triple-slash-reference": "error",`
	`115`	`+"typescript/unbound-method": "error",`
	`116`	`+"typescript/use-unknown-in-catch-callback-variable": "error",`
`112`	`117`	`"unicorn/consistent-date-clone": "error",`
`113`	`118`	`"unicorn/consistent-empty-array-spread": "error",`
`114`	`119`	`"unicorn/consistent-function-scoping": "off",`
`@@ -128,6 +133,7 @@`
`128`	`133`	`"unicorn/no-unnecessary-slice-end": "error",`
`129`	`134`	`"unicorn/no-useless-error-capture-stack-trace": "error",`
`130`	`135`	`"unicorn/no-useless-promise-resolve-reject": "error",`
	`136`	`+"unicorn/no-useless-switch-case": "error",`
`131`	`137`	`"unicorn/no-zero-fractions": "error",`
`132`	`138`	`"unicorn/prefer-date-now": "error",`
`133`	`139`	`"unicorn/prefer-dom-node-text-content": "error",`

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ class LegacyRunTurnEventQueue {`
`68`	`68`	`return item;`
`69`	`69`	`}`
`70`	`70`	`if (this.error) {`
`71`		`-throw this.error;`
	`71`	`+throw toLintErrorObject(this.error, "Non-Error thrown");`
`72`	`72`	`}`
`73`	`73`	`if (this.closed) {`
`74`	`74`	`return null;`
`@@ -178,3 +178,17 @@ export function lazyStartRuntimeTurn(`
`178`	`178`	`},`
`179`	`179`	`};`
`180`	`180`	`}`
	`181`	`+`
	`182`	`+function toLintErrorObject(value: unknown, fallbackMessage: string): Error {`
	`183`	`+if (value instanceof Error) {`
	`184`	`+return value;`
	`185`	`+}`
	`186`	`+if (typeof value === "string") {`
	`187`	`+return new Error(value);`
	`188`	`+}`
	`189`	`+const error = new Error(fallbackMessage, { cause: value });`
	`190`	`+if ((typeof value === "object" && value !== null) \|\| typeof value === "function") {`
	`191`	`+Object.assign(error, value);`
	`192`	`+}`
	`193`	`+return error;`
	`194`	`+}`

Original file line number	Diff line number	Diff line change
`@@ -286,7 +286,7 @@ describe("AcpxRuntime fresh reset wrapper", () => {`
`286`	`286`	`})`
`287`	`287`	`.then(`
`288`	`288`	`() => ({ status: "resolved" as const }),`
`289`		`-(error) => ({ status: "rejected" as const, error }),`
	`289`	`+(error: unknown) => ({ status: "rejected" as const, error }),`
`290`	`290`	`);`
`291`	`291`
`292`	`292`	`expect(outcome.status).toBe("rejected");`
`@@ -298,7 +298,12 @@ describe("AcpxRuntime fresh reset wrapper", () => {`
`298`	`298`	`code: "ACP_SESSION_INIT_FAILED",`
`299`	`299`	`message: expect.stringContaining("deployment missing"),`
`300`	`300`	`});`
`301`		`-expect(outcome.error.message).not.toContain("sk-testsecret1234567890");`
	`301`	`+const error = outcome.error;`
	`302`	`+expect(error).toBeInstanceOf(AcpRuntimeError);`
	`303`	`+if (!(error instanceof AcpRuntimeError)) {`
	`304`	`+throw new Error("expected AcpRuntimeError");`
	`305`	`+}`
	`306`	`+expect(error.message).not.toContain("sk-testsecret1234567890");`
`302`	`307`	`});`
`303`	`308`
`304`	`309`	`it("adds Codex wrapper stderr tail to generic first-turn failures", async () => {`

Original file line number	Diff line number	Diff line change
`@@ -218,13 +218,21 @@ describe("active-memory plugin", () => {`
`218`	`218`	`};`
`219`	`219`	`const waitForAbort = async (abortSignal?: AbortSignal): Promise<never> => {`
`220`	`220`	`if (abortSignal?.aborted) {`
`221`		`-throw (abortSignal.reason as unknown) ?? new Error("Operation aborted");`
	`221`	`+throw toLintErrorObject(`
	`222`	`+(abortSignal.reason as unknown) ?? new Error("Operation aborted"),`
	`223`	`+"Non-Error thrown",`
	`224`	`+);`
`222`	`225`	`}`
`223`	`226`	`return await new Promise<never>((_resolve, reject) => {`
`224`	`227`	`abortSignal?.addEventListener(`
`225`	`228`	`"abort",`
`226`	`229`	`() => {`
`227`		`-reject((abortSignal.reason as unknown) ?? new Error("Operation aborted"));`
	`230`	`+reject(`
	`231`	`+toLintErrorObject(`
	`232`	`+(abortSignal.reason as unknown) ?? new Error("Operation aborted"),`
	`233`	`+"Non-Error rejection",`
	`234`	`+),`
	`235`	`+);`
`228`	`236`	`},`
`229`	`237`	`{ once: true },`
`230`	`238`	`);`
`@@ -4350,3 +4358,17 @@ describe("active-memory plugin", () => {`
`4350`	`4358`	`expect(config.circuitBreakerCooldownMs).toBe(5000);`
`4351`	`4359`	`});`
`4352`	`4360`	`});`
	`4361`	`+`
	`4362`	`+function toLintErrorObject(value: unknown, fallbackMessage: string): Error {`
	`4363`	`+if (value instanceof Error) {`
	`4364`	`+return value;`
	`4365`	`+}`
	`4366`	`+if (typeof value === "string") {`
	`4367`	`+return new Error(value);`
	`4368`	`+}`
	`4369`	`+const error = new Error(fallbackMessage, { cause: value });`
	`4370`	`+if ((typeof value === "object" && value !== null) \|\| typeof value === "function") {`
	`4371`	`+Object.assign(error, value);`
	`4372`	`+}`
	`4373`	`+return error;`
	`4374`	`+}`

Original file line number	Diff line number	Diff line change
`@@ -1011,7 +1011,6 @@ function buildPromptStyleLines(style: ActiveMemoryPromptStyle): string[] {`
`1011`	`1011`	`"If relevant memory is mostly a stable user preference or recurring habit, lean toward returning it.",`
`1012`	`1012`	`"If the strongest match is only a one-off historical fact and not a recurring preference or habit, prefer NONE unless the latest user message clearly asks for that fact.",`
`1013`	`1013`	`];`
`1014`		`-case "balanced":`
`1015`	`1014`	`default:`
`1016`	`1015`	`return [`
`1017`	`1016`	`"Treat the latest user message as the primary query.",`
`@@ -1982,7 +1981,7 @@ async function waitForSubagentPartialTimeoutData(`
`1982`	`1981`	`(await Promise.race([`
`1983`	`1982`	`subagentPromise.then(`
`1984`	`1983`	`() => undefined,`
`1985`		`-(error) => readPartialTimeoutData(error),`
	`1984`	`+(error: unknown) => readPartialTimeoutData(error),`
`1986`	`1985`	`),`
`1987`	`1986`	`timeoutPromise,`
`1988`	`1987`	`])) ?? {}`

Original file line number	Diff line number	Diff line change
`@@ -571,7 +571,7 @@ export async function startGatewayBonjourAdvertiser(`
`571`	`571`	`.then(() => {`
`572`	`572`	logger.info(`bonjour: advertised ${serviceSummary(label, svc)}`);
`573`	`573`	`})`
`574`		`-.catch((err) => {`
	`574`	`+.catch((err: unknown) => {`
`575`	`575`	`handleAdvertiseFailure(label, svc, err, "failed");`
`576`	`576`	`});`
`577`	`577`	`} catch (err) {`
`@@ -747,7 +747,7 @@ export async function startGatewayBonjourAdvertiser(`
`747`	`747`	)})`,
`748`	`748`	`);`
`749`	`749`	`try {`
`750`		`-void svc.advertise().catch((err) => {`
	`750`	`+void svc.advertise().catch((err: unknown) => {`
`751`	`751`	`logger.warn(`
`752`	`752`	`bonjour: watchdog re-advertise failed (${serviceSummary(label, svc)}): ${formatBonjourError(err)}`,
`753`	`753`	`);`

Original file line number	Diff line number	Diff line change
`@@ -416,7 +416,8 @@ describe("cdp.helpers internal", () => {`
`416`	`416`	`await expect(`
`417`	`417`	`withCdpSocket(server.url, async (send) => {`
`418`	`418`	`await send("Test.ok");`
`419`		`-const rejectRawString = () => Promise.reject("raw-string-from-callback");`
	`419`	`+const rejectRawString = () =>`
	`420`	`+Promise.reject(toLintErrorObject("raw-string-from-callback", "Non-Error rejection"));`
`420`	`421`	`return rejectRawString();`
`421`	`422`	`}),`
`422`	`423`	`).rejects.toThrow(/raw-string-from-callback/);`
`@@ -572,3 +573,17 @@ describe("openCdpWebSocket option handling", () => {`
`572`	`573`	`ws.close();`
`573`	`574`	`});`
`574`	`575`	`});`
	`576`	`+`
	`577`	`+function toLintErrorObject(value: unknown, fallbackMessage: string): Error {`
	`578`	`+if (value instanceof Error) {`
	`579`	`+return value;`
	`580`	`+}`
	`581`	`+if (typeof value === "string") {`
	`582`	`+return new Error(value);`
	`583`	`+}`
	`584`	`+const error = new Error(fallbackMessage, { cause: value });`
	`585`	`+if ((typeof value === "object" && value !== null) \|\| typeof value === "function") {`
	`586`	`+Object.assign(error, value);`
	`587`	`+}`
	`588`	`+return error;`
	`589`	`+}`

Original file line number	Diff line number	Diff line change
`@@ -258,7 +258,7 @@ function extractJsonMessage(result: ChromeMcpToolResult): unknown {`
`258`	`258`	`}`
`259`	`259`	`}`
`260`	`260`	`if (lastError) {`
`261`		`-throw lastError;`
	`261`	`+throw toLintErrorObject(lastError, "Non-Error thrown");`
`262`	`262`	`}`
`263`	`263`	`return null;`
`264`	`264`	`}`
`@@ -629,7 +629,7 @@ async function closeChromeMcpClientAndProcess(params: {`
`629`	`629`	`return;`
`630`	`630`	`}`
`631`	`631`	`await params.client.close().catch(() => {});`
`632`		`-await terminateChromeMcpProcessTree(rootPid, descendantPids).catch((err) => {`
	`632`	`+await terminateChromeMcpProcessTree(rootPid, descendantPids).catch((err: unknown) => {`
`633`	`633`	`log.trace(`
`634`	`634`	`Unable to fully terminate Chrome MCP subprocess tree for pid ${rootPid}: ${err instanceof Error ? err.message : String(err)}`,
`635`	`635`	`);`
`@@ -761,7 +761,8 @@ async function waitForChromeMcpReady(`
`761`	`761`	`if (signal) {`
`762`	`762`	`racers.push(`
`763`	`763`	`new Promise<never>((_, reject) => {`
`764`		`-abortListener = () => reject(signal.reason ?? new Error("aborted"));`
	`764`	`+abortListener = () =>`
	`765`	`+reject(toLintErrorObject(signal.reason ?? new Error("aborted"), "Non-Error rejection"));`
`765`	`766`	`signal.addEventListener("abort", abortListener, { once: true });`
`766`	`767`	`}),`
`767`	`768`	`);`
`@@ -793,7 +794,8 @@ async function waitForChromeMcpPendingSession(`
`793`	`794`	`return await Promise.race([`
`794`	`795`	`pending,`
`795`	`796`	`new Promise<never>((_, reject) => {`
`796`		`-abortListener = () => reject(signal.reason ?? new Error("aborted"));`
	`797`	`+abortListener = () =>`
	`798`	`+reject(toLintErrorObject(signal.reason ?? new Error("aborted"), "Non-Error rejection"));`
`797`	`799`	`signal.addEventListener("abort", abortListener, { once: true });`
`798`	`800`	`}),`
`799`	`801`	`]);`
`@@ -1022,7 +1024,8 @@ async function callTool(`
`1022`	`1024`	`if (signal) {`
`1023`	`1025`	`racers.push(`
`1024`	`1026`	`new Promise<never>((_, reject) => {`
`1025`		`-abortListener = () => reject(signal.reason ?? new Error("aborted"));`
	`1027`	`+abortListener = () =>`
	`1028`	`+reject(toLintErrorObject(signal.reason ?? new Error("aborted"), "Non-Error rejection"));`
`1026`	`1029`	`signal.addEventListener("abort", abortListener, { once: true });`
`1027`	`1030`	`}),`
`1028`	`1031`	`);`
`@@ -1540,3 +1543,17 @@ export async function resetChromeMcpSessionsForTest(): Promise<void> {`
`1540`	`1543`	`await stopAllChromeMcpSessions();`
`1541`	`1544`	`chromeMcpProcessCleanupDepsForTest = null;`
`1542`	`1545`	`}`
	`1546`	`+`
	`1547`	`+function toLintErrorObject(value: unknown, fallbackMessage: string): Error {`
	`1548`	`+if (value instanceof Error) {`
	`1549`	`+return value;`
	`1550`	`+}`
	`1551`	`+if (typeof value === "string") {`
	`1552`	`+return new Error(value);`
	`1553`	`+}`
	`1554`	`+const error = new Error(fallbackMessage, { cause: value });`
	`1555`	`+if ((typeof value === "object" && value !== null) \|\| typeof value === "function") {`
	`1556`	`+Object.assign(error, value);`
	`1557`	`+}`
	`1558`	`+return error;`
	`1559`	`+}`

Original file line number	Diff line number	Diff line change
`@@ -315,9 +315,17 @@ export async function fetchBrowserJson<T>(`
`315`	`315`
`316`	`316`	`let abortListener: (() => void) \| undefined;`
`317`	`317`	`const abortPromise: Promise<never> = abortCtrl.signal.aborted`
`318`		`- ? Promise.reject(abortCtrl.signal.reason ?? new Error("aborted"))`
	`318`	`+ ? Promise.reject(`
	`319`	`+toLintErrorObject(abortCtrl.signal.reason ?? new Error("aborted"), "Non-Error rejection"),`
	`320`	`+)`
`319`	`321`	`: new Promise((_, reject) => {`
`320`		`-abortListener = () => reject(abortCtrl.signal.reason ?? new Error("aborted"));`
	`322`	`+abortListener = () =>`
	`323`	`+reject(`
	`324`	`+toLintErrorObject(`
	`325`	`+abortCtrl.signal.reason ?? new Error("aborted"),`
	`326`	`+"Non-Error rejection",`
	`327`	`+),`
	`328`	`+);`
`321`	`329`	`abortCtrl.signal.addEventListener("abort", abortListener, { once: true });`
`322`	`330`	`});`
`323`	`331`
`@@ -382,3 +390,17 @@ export const testApi = {`
`382`	`390`	`withLoopbackBrowserAuth: withLoopbackBrowserAuthImpl,`
`383`	`391`	`};`
`384`	`392`	`export { testApi as __test };`
	`393`	`+`
	`394`	`+function toLintErrorObject(value: unknown, fallbackMessage: string): Error {`
	`395`	`+if (value instanceof Error) {`
	`396`	`+return value;`
	`397`	`+}`
	`398`	`+if (typeof value === "string") {`
	`399`	`+return new Error(value);`
	`400`	`+}`
	`401`	`+const error = new Error(fallbackMessage, { cause: value });`
	`402`	`+if ((typeof value === "object" && value !== null) \|\| typeof value === "function") {`
	`403`	`+Object.assign(error, value);`
	`404`	`+}`
	`405`	`+return error;`
	`406`	`+}`

Original file line number	Diff line number	Diff line change
`@@ -1359,12 +1359,12 @@ export async function gotoPageWithNavigationGuard(`
`1359`	`1359`	`try {`
`1360`	`1360`	`const response = await opts.page.goto(opts.url, { timeout: opts.timeoutMs });`
`1361`	`1361`	`if (blockedError) {`
`1362`		`-throw blockedError;`
	`1362`	`+throw toLintErrorObject(blockedError, "Non-Error thrown");`
`1363`	`1363`	`}`
`1364`	`1364`	`return response;`
`1365`	`1365`	`} catch (err) {`
`1366`	`1366`	`if (blockedError) {`
`1367`		`-throw blockedError;`
	`1367`	`+throw toLintErrorObject(blockedError, "Non-Error thrown");`
`1368`	`1368`	`}`
`1369`	`1369`	`throw err;`
`1370`	`1370`	`} finally {`
`@@ -1813,3 +1813,17 @@ export async function focusPageByTargetIdViaPlaywright(opts: {`
`1813`	`1813`	`}`
`1814`	`1814`	`}`
`1815`	`1815`	`}`
	`1816`	`+`
	`1817`	`+function toLintErrorObject(value: unknown, fallbackMessage: string): Error {`
	`1818`	`+if (value instanceof Error) {`
	`1819`	`+return value;`
	`1820`	`+}`
	`1821`	`+if (typeof value === "string") {`
	`1822`	`+return new Error(value);`
	`1823`	`+}`
	`1824`	`+const error = new Error(fallbackMessage, { cause: value });`
	`1825`	`+if ((typeof value === "object" && value !== null) \|\| typeof value === "function") {`
	`1826`	`+Object.assign(error, value);`
	`1827`	`+}`
	`1828`	`+return error;`
	`1829`	`+}`

此内容由惯性聚合(RSS阅读器)自动聚合整理，仅供阅读参考。原文来自 — 版权归原作者所有。

推荐订阅源

Recent Commits to openclaw:main

File tree