惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

博客园_首页
H
Help Net Security
腾讯CDC
宝玉的分享
宝玉的分享
H
Hackread – Cybersecurity News, Data Breaches, AI and More
L
LangChain Blog
爱范儿
爱范儿
T
The Blog of Author Tim Ferriss
J
Java Code Geeks
让小产品的独立变现更简单 - ezindie.com
让小产品的独立变现更简单 - ezindie.com
MyScale Blog
MyScale Blog
Engineering at Meta
Engineering at Meta
N
Netflix TechBlog - Medium
D
Docker
V
V2EX
Last Week in AI
Last Week in AI
G
Google Developers Blog
IT之家
IT之家
C
Check Point Blog
钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
人人都是产品经理
人人都是产品经理
博客园 - 叶小钗
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
博客园 - 聂微东

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(ui): make control prompts real modals · openclaw/open...
BunsDev · 2026-04-29 · via Recent Commits to openclaw:main

@@ -0,0 +1,175 @@

1+

/* @vitest-environment jsdom */

2+3+

import { html, nothing, render } from "lit";

4+

import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";

5+

import { type OpenClawModalDialog } from "./modal-dialog.ts";

6+

import "./modal-dialog.ts";

7+8+

let container: HTMLDivElement;

9+10+

const showModalDescriptor = Object.getOwnPropertyDescriptor(

11+

HTMLDialogElement.prototype,

12+

"showModal",

13+

);

14+

const closeDescriptor = Object.getOwnPropertyDescriptor(HTMLDialogElement.prototype, "close");

15+16+

function nextFrame() {

17+

return new Promise<void>((resolve) => {

18+

requestAnimationFrame(() => resolve());

19+

});

20+

}

21+22+

function installDialogPolyfill() {

23+

Object.defineProperty(HTMLDialogElement.prototype, "showModal", {

24+

configurable: true,

25+

value(this: HTMLDialogElement) {

26+

this.setAttribute("open", "");

27+

},

28+

});

29+

Object.defineProperty(HTMLDialogElement.prototype, "close", {

30+

configurable: true,

31+

value(this: HTMLDialogElement) {

32+

this.removeAttribute("open");

33+

},

34+

});

35+

}

36+37+

function restoreDescriptor(name: "showModal" | "close", descriptor?: PropertyDescriptor) {

38+

if (descriptor) {

39+

Object.defineProperty(HTMLDialogElement.prototype, name, descriptor);

40+

return;

41+

}

42+

delete (HTMLDialogElement.prototype as Partial<HTMLDialogElement>)[name];

43+

}

44+45+

async function renderModal() {

46+

render(

47+

html`

48+

<openclaw-modal-dialog

49+

label="Confirm action"

50+

description="Review the operation before continuing."

51+

>

52+

<section>

53+

<h2 id="modal-title">Confirm action</h2>

54+

<p id="modal-description">Review the operation before continuing.</p>

55+

<button id="first-action">First</button>

56+

<button id="last-action">Last</button>

57+

</section>

58+

</openclaw-modal-dialog>

59+

`,

60+

container,

61+

);

62+

const modal = container.querySelector<OpenClawModalDialog>("openclaw-modal-dialog");

63+

expect(modal).not.toBeNull();

64+

await modal!.updateComplete;

65+

await nextFrame();

66+

const dialog = modal!.shadowRoot?.querySelector("dialog");

67+

expect(dialog).not.toBeNull();

68+

return { modal: modal!, dialog: dialog! };

69+

}

70+71+

describe("openclaw-modal-dialog", () => {

72+

beforeEach(() => {

73+

installDialogPolyfill();

74+

container = document.createElement("div");

75+

document.body.append(container);

76+

});

77+78+

afterEach(() => {

79+

render(nothing, container);

80+

container.remove();

81+

restoreDescriptor("showModal", showModalDescriptor);

82+

restoreDescriptor("close", closeDescriptor);

83+

vi.restoreAllMocks();

84+

});

85+86+

it("opens a labelled modal dialog with an optional description", async () => {

87+

const { modal, dialog } = await renderModal();

88+89+

expect(dialog.open).toBe(true);

90+

expect(dialog.getAttribute("role")).toBe("dialog");

91+

expect(dialog.getAttribute("aria-modal")).toBe("true");

92+

const labelId = dialog.getAttribute("aria-labelledby");

93+

const descriptionId = dialog.getAttribute("aria-describedby");

94+

expect(labelId).toBe("openclaw-modal-dialog-label");

95+

expect(descriptionId).toBe("openclaw-modal-dialog-description");

96+

expect(dialog.getRootNode()).toBe(modal.shadowRoot);

97+

expect(dialog.ownerDocument.querySelector(`#${labelId}`)).toBeNull();

98+

expect(modal.shadowRoot?.getElementById(labelId!)?.textContent).toBe("Confirm action");

99+

expect(modal.shadowRoot?.getElementById(descriptionId!)?.textContent).toBe(

100+

"Review the operation before continuing.",

101+

);

102+

});

103+104+

it("focuses the dialog container first", async () => {

105+

const { modal, dialog } = await renderModal();

106+107+

expect(modal.shadowRoot?.activeElement).toBe(dialog);

108+

expect(document.activeElement).not.toBe(container.querySelector("#first-action"));

109+

});

110+111+

it("cycles Tab and Shift+Tab inside focusable dialog content", async () => {

112+

const { dialog } = await renderModal();

113+

const first = container.querySelector<HTMLButtonElement>("#first-action");

114+

const last = container.querySelector<HTMLButtonElement>("#last-action");

115+

expect(first).not.toBeNull();

116+

expect(last).not.toBeNull();

117+118+

last!.focus();

119+

const tab = new KeyboardEvent("keydown", {

120+

key: "Tab",

121+

bubbles: true,

122+

cancelable: true,

123+

composed: true,

124+

});

125+

last!.dispatchEvent(tab);

126+

expect(tab.defaultPrevented).toBe(true);

127+

expect(document.activeElement).toBe(first);

128+129+

first!.focus();

130+

const shiftTab = new KeyboardEvent("keydown", {

131+

key: "Tab",

132+

shiftKey: true,

133+

bubbles: true,

134+

cancelable: true,

135+

composed: true,

136+

});

137+

first!.dispatchEvent(shiftTab);

138+

expect(shiftTab.defaultPrevented).toBe(true);

139+

expect(document.activeElement).toBe(last);

140+

expect(dialog.open).toBe(true);

141+

});

142+143+

it("emits modal-cancel on Escape", async () => {

144+

const { modal, dialog } = await renderModal();

145+

const onCancel = vi.fn();

146+

modal.addEventListener("modal-cancel", onCancel);

147+148+

dialog.dispatchEvent(

149+

new KeyboardEvent("keydown", {

150+

key: "Escape",

151+

bubbles: true,

152+

cancelable: true,

153+

composed: true,

154+

}),

155+

);

156+157+

expect(onCancel).toHaveBeenCalledTimes(1);

158+

});

159+160+

it("restores focus when closed and removed", async () => {

161+

const returnTarget = document.createElement("button");

162+

returnTarget.textContent = "Return";

163+

document.body.append(returnTarget);

164+

returnTarget.focus();

165+166+

await renderModal();

167+

expect(document.activeElement).not.toBe(returnTarget);

168+169+

render(nothing, container);

170+

await nextFrame();

171+172+

expect(document.activeElement).toBe(returnTarget);

173+

returnTarget.remove();

174+

});

175+

});