惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

Martin Fowler
Martin Fowler
有赞技术团队
有赞技术团队
博客园_首页
H
Help Net Security
GbyAI
GbyAI
aimingoo的专栏
aimingoo的专栏
V
Visual Studio Blog
The Cloudflare Blog
腾讯CDC
Jina AI
Jina AI
Last Week in AI
Last Week in AI
月光博客
月光博客
博客园 - 叶小钗
Google DeepMind News
Google DeepMind News
B
Blog RSS Feed
Blog — PlanetScale
Blog — PlanetScale
人人都是产品经理
人人都是产品经理
Engineering at Meta
Engineering at Meta
Y
Y Combinator Blog
Hugging Face - Blog
Hugging Face - Blog
博客园 - 聂微东
爱范儿
爱范儿
N
Netflix TechBlog - Medium
F
Fortinet All Blogs

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(discord): skip disabled reaction listeners · openclaw...
steipete · 2026-05-02 · via Recent Commits to openclaw:main

@@ -67,12 +67,24 @@ vi.mock("./gateway-supervisor.js", () => ({

6767

}));

68686969

vi.mock("./listeners.js", () => ({

70-

DiscordMessageListener: function DiscordMessageListener() {},

71-

DiscordInteractionListener: function DiscordInteractionListener() {},

72-

DiscordPresenceListener: function DiscordPresenceListener() {},

73-

DiscordReactionListener: function DiscordReactionListener() {},

74-

DiscordReactionRemoveListener: function DiscordReactionRemoveListener() {},

75-

DiscordThreadUpdateListener: function DiscordThreadUpdateListener() {},

70+

DiscordMessageListener: function DiscordMessageListener() {

71+

return { type: "message" };

72+

},

73+

DiscordInteractionListener: function DiscordInteractionListener() {

74+

return { type: "interaction" };

75+

},

76+

DiscordPresenceListener: function DiscordPresenceListener() {

77+

return { type: "presence" };

78+

},

79+

DiscordReactionListener: function DiscordReactionListener() {

80+

return { type: "reaction-add" };

81+

},

82+

DiscordReactionRemoveListener: function DiscordReactionRemoveListener() {

83+

return { type: "reaction-remove" };

84+

},

85+

DiscordThreadUpdateListener: function DiscordThreadUpdateListener() {

86+

return { type: "thread-update" };

87+

},

7688

registerDiscordListener: vi.fn(),

7789

}));

7890

@@ -81,13 +93,19 @@ vi.mock("./presence.js", () => ({

8193

}));

82948395

import { createDiscordRequestClient, DISCORD_REST_TIMEOUT_MS } from "../proxy-request-client.js";

84-

import { createDiscordMonitorClient, fetchDiscordBotIdentity } from "./provider.startup.js";

96+

import { registerDiscordListener } from "./listeners.js";

97+

import {

98+

createDiscordMonitorClient,

99+

fetchDiscordBotIdentity,

100+

registerDiscordMonitorListeners,

101+

} from "./provider.startup.js";

8510286103

describe("createDiscordMonitorClient", () => {

87104

beforeEach(() => {

88105

registerVoiceClientSpy.mockReset();

89106

waitForDiscordGatewayPluginRegistrationMock.mockReset().mockReturnValue(undefined);

90107

vi.mocked(createDiscordRequestClient).mockClear();

108+

vi.mocked(registerDiscordListener).mockClear();

91109

});

9211093111

function createRuntime() {

@@ -296,6 +314,92 @@ describe("createDiscordMonitorClient", () => {

296314

});

297315

});

298316317+

describe("registerDiscordMonitorListeners", () => {

318+

beforeEach(() => {

319+

vi.mocked(registerDiscordListener).mockClear();

320+

});

321+322+

function createRuntime() {

323+

return {

324+

log: vi.fn(),

325+

error: vi.fn(),

326+

exit: vi.fn(),

327+

};

328+

}

329+330+

function createListenerParams(

331+

overrides: Partial<Parameters<typeof registerDiscordMonitorListeners>[0]> = {},

332+

): Parameters<typeof registerDiscordMonitorListeners>[0] {

333+

return {

334+

cfg: {},

335+

client: { listeners: [] },

336+

accountId: "default",

337+

discordConfig: {},

338+

runtime: createRuntime(),

339+

botUserId: "bot-1",

340+

dmEnabled: false,

341+

groupDmEnabled: false,

342+

groupDmChannels: [],

343+

dmPolicy: "disabled",

344+

allowFrom: [],

345+

groupPolicy: "allowlist",

346+

guildEntries: {

347+

"guild-1": {

348+

id: "guild-1",

349+

reactionNotifications: "off",

350+

},

351+

},

352+

logger: {},

353+

messageHandler: {},

354+

...overrides,

355+

} as Parameters<typeof registerDiscordMonitorListeners>[0];

356+

}

357+358+

function registeredListenerTypes() {

359+

return vi.mocked(registerDiscordListener).mock.calls.map((call) => {

360+

const listener = call[1] as { type?: string };

361+

return listener.type;

362+

});

363+

}

364+365+

it("skips reaction listeners when every configured guild disables reactions and DMs are off", () => {

366+

registerDiscordMonitorListeners(createListenerParams());

367+368+

expect(registeredListenerTypes()).toEqual(["interaction", "message", "thread-update"]);

369+

});

370+371+

it("keeps reaction listeners when direct messages can emit reaction notifications", () => {

372+

registerDiscordMonitorListeners(

373+

createListenerParams({

374+

dmEnabled: true,

375+

}),

376+

);

377+378+

expect(registeredListenerTypes()).toContain("reaction-add");

379+

expect(registeredListenerTypes()).toContain("reaction-remove");

380+

});

381+382+

it("keeps reaction listeners when a configured guild enables reaction notifications", () => {

383+

registerDiscordMonitorListeners(

384+

createListenerParams({

385+

guildEntries: {

386+

"guild-1": {

387+

id: "guild-1",

388+

reactionNotifications: "off",

389+

},

390+

"guild-2": {

391+

id: "guild-2",

392+

reactionNotifications: "own",

393+

},

394+

},

395+

}),

396+

);

397+398+

expect(registeredListenerTypes()).toContain("reaction-add");

399+

expect(registeredListenerTypes()).toContain("reaction-remove");

400+

});

401+

});

402+299403

describe("fetchDiscordBotIdentity", () => {

300404

it("derives the bot id from a Discord bot token without calling /users/@me", async () => {

301405

const fetchUser = vi.fn(async () => {