惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
博客园_首页
大猫的无限游戏
大猫的无限游戏
让小产品的独立变现更简单 - ezindie.com
让小产品的独立变现更简单 - ezindie.com
Apple Machine Learning Research
Apple Machine Learning Research
B
Blog
B
Blog RSS Feed
Cyber Security Advisories - MS-ISAC
Cyber Security Advisories - MS-ISAC
P
Proofpoint News Feed
MyScale Blog
MyScale Blog
Engineering at Meta
Engineering at Meta
量子位
H
Hackread – Cybersecurity News, Data Breaches, AI and More
T
Tailwind CSS Blog
Stack Overflow Blog
Stack Overflow Blog
N
Netflix TechBlog - Medium
T
The Blog of Author Tim Ferriss
U
Unit 42
aimingoo的专栏
aimingoo的专栏
博客园 - 叶小钗
博客园 - 【当耐特】
云风的 BLOG
云风的 BLOG
博客园 - Franky
博客园 - 聂微东

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(security): kill timed out exec process trees · opencl...
vincentkoc · 2026-06-18 · via Recent Commits to openclaw:main
Original file line numberDiff line numberDiff line change

@@ -0,0 +1,17 @@

1+

import type { ChildProcess } from "node:child_process";

2+

import { signalProcessTree } from "./kill-tree.js";

3+
4+

export function shouldDetachChildForProcessTree(): boolean {

5+

return process.platform !== "win32";

6+

}

7+
8+

export function forceKillChildProcessTree(child: Pick<ChildProcess, "kill" | "pid">): void {

9+

if (typeof child.pid === "number" && child.pid > 0) {

10+

signalProcessTree(child.pid, "SIGKILL", {

11+

detached: shouldDetachChildForProcessTree(),

12+

});

13+

return;

14+

}

15+
16+

child.kill("SIGKILL");

17+

}

Original file line numberDiff line numberDiff line change

@@ -5,6 +5,12 @@ import path from "node:path";

55

import { afterAll, beforeAll, describe, expect, it, vi } from "vitest";

66

import type { OpenClawConfig } from "../config/config.js";

77

import { MAX_TIMER_TIMEOUT_MS } from "../shared/number-coercion.js";

8+

import {

9+

killPidIfAlive,

10+

readPidFile,

11+

waitForPidToExit,

12+

writeForkingNoOutputScript,

13+

} from "../test-utils/process-tree.js";

814

import { INVALID_EXEC_SECRET_REF_IDS } from "../test-utils/secret-ref-test-vectors.js";

915

import { withMockedWindowsPlatform } from "../test-utils/vitest-spies.js";

1016

import {

@@ -55,6 +61,7 @@ describe("secret ref resolver", () => {

5561

jsonOnly?: boolean;

5662

allowSymlinkCommand?: boolean;

5763

trustedDirs?: string[];

64+

env?: Record<string, string>;

5865

args?: string[];

5966

timeoutMs?: number;

6067

noOutputTimeoutMs?: number;

@@ -255,6 +262,28 @@ describe("secret ref resolver", () => {

255262

expect(value).toBe("ok");

256263

});

257264
265+

itPosix("kills forked exec provider children on no-output timeout", async () => {

266+

const root = await createCaseDir("exec-fork-timeout");

267+

const scriptPath = await writeForkingNoOutputScript(root);

268+

const pidPath = path.join(root, "forked.pid");

269+

let childPid: number | undefined;

270+
271+

try {

272+

await expect(

273+

resolveExecSecret(scriptPath, {

274+

env: { NODE_BINARY: process.execPath, PID_FILE: pidPath },

275+

noOutputTimeoutMs: 150,

276+

timeoutMs: 2000,

277+

}),

278+

).rejects.toThrow('Exec provider "execmain" produced no output');

279+
280+

childPid = await readPidFile(pidPath);

281+

expect(await waitForPidToExit(childPid)).toBe(true);

282+

} finally {

283+

killPidIfAlive(childPid);

284+

}

285+

});

286+
258287

itPosix("supports non-JSON single-value exec output when jsonOnly is false", async () => {

259288

const value = await resolveExecSecret(execPlainScriptPath, { jsonOnly: false });

260289

expect(value).toBe("plain-secret");

Original file line numberDiff line numberDiff line change

@@ -18,6 +18,10 @@ import {

1818

loadPluginManifestRegistry,

1919

type PluginManifestRegistry,

2020

} from "../plugins/manifest-registry.js";

21+

import {

22+

forceKillChildProcessTree,

23+

shouldDetachChildForProcessTree,

24+

} from "../process/child-process-tree.js";

2125

import { inspectPathPermissions, safeStat } from "../security/audit-fs.js";

2226

import { isPathInside } from "../security/scan-paths.js";

2327

import { resolveUserPath } from "../utils.js";

@@ -497,6 +501,7 @@ async function runExecResolver(params: {

497501

stdio: ["pipe", "pipe", "pipe"],

498502

shell: false,

499503

windowsHide: true,

504+

detached: shouldDetachChildForProcessTree(),

500505

});

501506
502507

let settled = false;

@@ -508,7 +513,7 @@ async function runExecResolver(params: {

508513

let noOutputTimer: NodeJS.Timeout | null = null;

509514

const timeoutTimer = setTimeout(() => {

510515

timedOut = true;

511-

child.kill("SIGKILL");

516+

forceKillChildProcessTree(child);

512517

}, params.timeoutMs);

513518
514519

const clearTimers = () => {

@@ -525,15 +530,15 @@ async function runExecResolver(params: {

525530

}

526531

noOutputTimer = setTimeout(() => {

527532

noOutputTimedOut = true;

528-

child.kill("SIGKILL");

533+

forceKillChildProcessTree(child);

529534

}, params.noOutputTimeoutMs);

530535

};

531536
532537

const append = (chunk: Buffer | string, target: "stdout" | "stderr") => {

533538

const text = typeof chunk === "string" ? chunk : chunk.toString("utf8");

534539

outputBytes += Buffer.byteLength(text, "utf8");

535540

if (outputBytes > params.maxOutputBytes) {

536-

child.kill("SIGKILL");

541+

forceKillChildProcessTree(child);

537542

if (!settled) {

538543

settled = true;

539544

clearTimers();

Original file line numberDiff line numberDiff line change

@@ -4,6 +4,12 @@ import os from "node:os";

44

import path from "node:path";

55

import { afterEach, beforeEach, describe, expect, it } from "vitest";

66

import type { OpenClawConfig } from "../config/types.openclaw.js";

7+

import {

8+

killPidIfAlive,

9+

readPidFile,

10+

waitForPidToExit,

11+

writeForkingNoOutputScript,

12+

} from "../test-utils/process-tree.js";

713

import {

814

runInstallPolicy,

915

validateInstallPolicyStatic,

@@ -211,6 +217,42 @@ describe("runInstallPolicy", () => {

211217

expect(result).toEqual({});

212218

});

213219
220+

it.runIf(process.platform !== "win32")(

221+

"kills forked policy command children on no-output timeout",

222+

async () => {

223+

const forkScriptPath = await writeForkingNoOutputScript(sourceDir);

224+

const pidPath = path.join(sourceDir, "forked.pid");

225+

let childPid: number | undefined;

226+
227+

try {

228+

const result = await runInstallPolicy({

229+

config: {

230+

security: {

231+

installPolicy: {

232+

enabled: true,

233+

exec: {

234+

source: "exec",

235+

command: forkScriptPath,

236+

env: { NODE_BINARY: process.execPath, PID_FILE: pidPath },

237+

allowInsecurePath: true,

238+

noOutputTimeoutMs: 150,

239+

timeoutMs: 2000,

240+

},

241+

},

242+

},

243+

},

244+

request: baseRequest(sourceDir),

245+

});

246+
247+

expect(result?.blocked?.reason).toContain("policy command produced no output");

248+

childPid = await readPidFile(pidPath);

249+

expect(await waitForPidToExit(childPid)).toBe(true);

250+

} finally {

251+

killPidIfAlive(childPid);

252+

}

253+

},

254+

);

255+
214256

it("does not inherit PATH unless passEnv includes it", async () => {

215257

const envPath = path.join(sourceDir, "env.json");

216258

const response = JSON.stringify({ protocolVersion: 1, decision: "allow" });

Original file line numberDiff line numberDiff line change

@@ -4,6 +4,10 @@ import fs from "node:fs/promises";

44

import path from "node:path";

55

import type { OpenClawConfig, SecurityConfig } from "../config/types.openclaw.js";

66

import { formatErrorMessage } from "../infra/errors.js";

7+

import {

8+

forceKillChildProcessTree,

9+

shouldDetachChildForProcessTree,

10+

} from "../process/child-process-tree.js";

711

import { normalizePositiveInt, normalizePositiveTimerMs } from "../secrets/shared.js";

812

import { resolveUserPath } from "../utils.js";

913

import { resolveRuntimeServiceVersion } from "../version.js";

@@ -534,6 +538,7 @@ async function runPolicyCommand(params: {

534538

stdio: ["pipe", "pipe", "pipe"],

535539

shell: false,

536540

windowsHide: true,

541+

detached: shouldDetachChildForProcessTree(),

537542

});

538543
539544

let settled = false;

@@ -545,7 +550,7 @@ async function runPolicyCommand(params: {

545550

let noOutputTimer: NodeJS.Timeout | null = null;

546551

const timeoutTimer = setTimeout(() => {

547552

timedOut = true;

548-

child.kill("SIGKILL");

553+

forceKillChildProcessTree(child);

549554

}, params.timeoutMs);

550555
551556

const clearTimers = () => {

@@ -562,15 +567,15 @@ async function runPolicyCommand(params: {

562567

}

563568

noOutputTimer = setTimeout(() => {

564569

noOutputTimedOut = true;

565-

child.kill("SIGKILL");

570+

forceKillChildProcessTree(child);

566571

}, params.noOutputTimeoutMs);

567572

};

568573
569574

const append = (chunk: Buffer | string, target: "stdout" | "stderr") => {

570575

const text = typeof chunk === "string" ? chunk : chunk.toString("utf8");

571576

outputBytes += Buffer.byteLength(text, "utf8");

572577

if (outputBytes > params.maxOutputBytes) {

573-

child.kill("SIGKILL");

578+

forceKillChildProcessTree(child);

574579

if (!settled) {

575580

settled = true;

576581

clearTimers();

Original file line numberDiff line numberDiff line change

@@ -0,0 +1,51 @@

1+

import fs from "node:fs/promises";

2+

import path from "node:path";

3+
4+

export async function writeForkingNoOutputScript(dir: string): Promise<string> {

5+

const scriptPath = path.join(dir, "fork-no-output.sh");

6+

await fs.writeFile(

7+

scriptPath,

8+

[

9+

"#!/bin/sh",

10+

'"$NODE_BINARY" -e "setInterval(() => {}, 1000)" &',

11+

'printf "%s" "$!" > "$PID_FILE"',

12+

"sleep 30",

13+

].join("\n"),

14+

"utf8",

15+

);

16+

await fs.chmod(scriptPath, 0o700);

17+

return scriptPath;

18+

}

19+
20+

export function isPidAlive(pid: number): boolean {

21+

try {

22+

process.kill(pid, 0);

23+

return true;

24+

} catch {

25+

return false;

26+

}

27+

}

28+
29+

export async function waitForPidToExit(pid: number, timeoutMs = 2000): Promise<boolean> {

30+

const deadline = Date.now() + timeoutMs;

31+

while (Date.now() < deadline) {

32+

if (!isPidAlive(pid)) {

33+

return true;

34+

}

35+

await new Promise<void>((resolve) => {

36+

setTimeout(resolve, 25);

37+

});

38+

}

39+

return !isPidAlive(pid);

40+

}

41+
42+

export async function readPidFile(pidPath: string): Promise<number> {

43+

return Number((await fs.readFile(pidPath, "utf8")).trim());

44+

}

45+
46+

export function killPidIfAlive(pid: number | undefined): void {

47+

if (pid === undefined || !isPidAlive(pid)) {

48+

return;

49+

}

50+

process.kill(pid, "SIGKILL");

51+

}