惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

The Cloudflare Blog
U
Unit 42
F
Fortinet All Blogs
雷峰网
雷峰网
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻
月光博客
月光博客
Y
Y Combinator Blog
罗磊的独立博客
V
Visual Studio Blog
大猫的无限游戏
大猫的无限游戏
J
Java Code Geeks
量子位
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
爱范儿
爱范儿
B
Blog RSS Feed
aimingoo的专栏
aimingoo的专栏
有赞技术团队
有赞技术团队
T
Tailwind CSS Blog
Microsoft Security Blog
Microsoft Security Blog
L
LangChain Blog
I
InfoQ
博客园 - 叶小钗
博客园 - 聂微东
Last Week in AI
Last Week in AI

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(slack): normalize approval user ids (#84671) · opencl...
kevinslin · 2026-05-21 · via Recent Commits to openclaw:main

@@ -69,9 +69,25 @@ describe("slack exec approvals", () => {

69697070

expect(getSlackExecApprovalApprovers({ cfg })).toEqual(["U456"]);

7171

expect(isSlackExecApprovalApprover({ cfg, senderId: "U456" })).toBe(true);

72+

expect(isSlackExecApprovalApprover({ cfg, senderId: "u456" })).toBe(true);

7273

expect(isSlackExecApprovalApprover({ cfg, senderId: "U123" })).toBe(false);

7374

});

747576+

it("canonicalizes configured exec approver ids before matching uppercase senders", () => {

77+

const explicitCfg = buildConfig({ approvers: ["u456"] });

78+

expect(getSlackExecApprovalApprovers({ cfg: explicitCfg })).toEqual(["U456"]);

79+

expect(isSlackExecApprovalApprover({ cfg: explicitCfg, senderId: "U456" })).toBe(true);

80+81+

const ownerFallbackCfg = {

82+

...buildConfig({ enabled: true }),

83+

commands: { ownerAllowFrom: ["slack:u123owner"] },

84+

} as OpenClawConfig;

85+

expect(getSlackExecApprovalApprovers({ cfg: ownerFallbackCfg })).toEqual(["U123OWNER"]);

86+

expect(isSlackExecApprovalApprover({ cfg: ownerFallbackCfg, senderId: "U123OWNER" })).toBe(

87+

true,

88+

);

89+

});

90+7591

it("does not infer approvers from allowFrom or DM default routes", () => {

7692

const cfg = buildConfig(

7793

{ enabled: true },

@@ -115,16 +131,18 @@ describe("slack exec approvals", () => {

115131

enabled: true,

116132

mode: "targets",

117133

targets: [

118-

{ channel: "slack", to: "user:U123TARGET" },

134+

{ channel: "slack", to: "user:u123target" },

119135

{ channel: "slack", to: "channel:C123" },

120136

],

121137

},

122138

},

123139

} as OpenClawConfig;

124140125141

expect(isSlackExecApprovalTargetRecipient({ cfg, senderId: "U123TARGET" })).toBe(true);

142+

expect(isSlackExecApprovalTargetRecipient({ cfg, senderId: "u123target" })).toBe(true);

126143

expect(isSlackExecApprovalTargetRecipient({ cfg, senderId: "U999OTHER" })).toBe(false);

127144

expect(isSlackExecApprovalAuthorizedSender({ cfg, senderId: "U123TARGET" })).toBe(true);

145+

expect(isSlackExecApprovalAuthorizedSender({ cfg, senderId: "u123target" })).toBe(true);

128146

});

129147130148

it("keeps the local Slack approval prompt path active", () => {

@@ -154,7 +172,15 @@ describe("slack exec approvals", () => {

154172155173

it("normalizes wrapped sender ids", () => {

156174

expect(normalizeSlackApproverId("user:U123OWNER")).toBe("U123OWNER");

175+

expect(normalizeSlackApproverId("user:u123owner")).toBe("U123OWNER");

176+

expect(normalizeSlackApproverId("slack:u123owner")).toBe("U123OWNER");

157177

expect(normalizeSlackApproverId("<@U123OWNER>")).toBe("U123OWNER");

178+

expect(normalizeSlackApproverId("<@u123owner>")).toBe("U123OWNER");

179+

expect(normalizeSlackApproverId("u123owner")).toBe("U123OWNER");

180+

expect(normalizeSlackApproverId("C123CHANNEL")).toBeUndefined();

181+

expect(normalizeSlackApproverId("slack:C123CHANNEL")).toBeUndefined();

182+

expect(normalizeSlackApproverId("user:C123CHANNEL")).toBeUndefined();

183+

expect(normalizeSlackApproverId("<@C123CHANNEL>")).toBeUndefined();

158184

});

159185160186

it("applies agent and session filters to request handling", () => {