惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

钛媒体:引领未来商业与生活新知
钛媒体:引领未来商业与生活新知
美团技术团队
Last Week in AI
Last Week in AI
WordPress大学
WordPress大学
博客园 - 三生石上(FineUI控件)
博客园 - 聂微东
雷峰网
雷峰网
阮一峰的网络日志
阮一峰的网络日志
博客园 - 叶小钗
IT之家
IT之家
Google DeepMind News
Google DeepMind News
D
Docker
J
Java Code Geeks
让小产品的独立变现更简单 - ezindie.com
让小产品的独立变现更简单 - ezindie.com
Apple Machine Learning Research
Apple Machine Learning Research
博客园 - 【当耐特】
V
V2EX
Hugging Face - Blog
Hugging Face - Blog
博客园 - Franky
月光博客
月光博客
宝玉的分享
宝玉的分享
酷 壳 – CoolShell
酷 壳 – CoolShell
aimingoo的专栏
aimingoo的专栏
freeCodeCamp Programming Tutorials: Python, JavaScript, Git & More

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(qa): normalize completed wait envelopes · openclaw/op...
vincentkoc · 2026-06-23 · via Recent Commits to openclaw:main
Original file line numberDiff line numberDiff line change

@@ -707,6 +707,33 @@ describe("qa suite runtime agent process helpers", () => {

707707

});

708708

});

709709
710+

it("accepts malformed completed wait errors as successful terminal runs", async () => {

711+

const gatewayCall = vi

712+

.fn()

713+

.mockResolvedValueOnce({ runId: "run-error-completed" })

714+

.mockResolvedValueOnce({ status: "error", error: "completed" });

715+

const env = {

716+

gateway: { call: gatewayCall },

717+

transport: {

718+

buildAgentDelivery: vi.fn(() => ({

719+

channel: "qa-channel",

720+

replyChannel: "reply-channel",

721+

replyTo: "reply-target",

722+

})),

723+

},

724+

} as never;

725+
726+

await expect(

727+

runAgentPrompt(env, {

728+

sessionKey: "session-error-completed",

729+

message: "hello",

730+

}),

731+

).resolves.toEqual({

732+

started: { runId: "run-error-completed" },

733+

waited: { status: "error", error: "completed" },

734+

});

735+

});

736+
710737

it("waits for the latest assistant history reply", async () => {

711738

const gatewayCall = vi

712739

.fn()

Original file line numberDiff line numberDiff line change

@@ -41,6 +41,11 @@ type QaChatHistoryResponse = {

4141

messages?: unknown[];

4242

};

4343
44+

type QaAgentWaitResult = {

45+

status?: string;

46+

error?: string;

47+

};

48+
4449

const ANSI_ESCAPE_PATTERN = new RegExp(String.raw`\x1B\[[0-?]*[ -/]*[@-~]`, "g");

4550

const MANAGED_DREAMING_CRON_MARKER = "[managed-by=memory-core.short-term-promotion]";

4651

const MANAGED_DREAMING_CRON_NAME = "Memory Dreaming Promotion";

@@ -368,7 +373,7 @@ async function waitForAgentRun(

368373

{

369374

timeoutMs: resolveQaGatewayTimeoutWithGraceMs(waitTimeoutMs),

370375

},

371-

)) as { status?: string; error?: string };

376+

)) as QaAgentWaitResult;

372377

} catch (error) {

373378

throw new QaSuiteInfraError(

374379

"agent_wait_failed",

@@ -378,6 +383,13 @@ async function waitForAgentRun(

378383

}

379384

}

380385
386+

function isSuccessfulAgentWaitResult(waited: QaAgentWaitResult) {

387+

if (waited.status === "ok" || waited.status === "completed" || waited.status === "succeeded") {

388+

return true;

389+

}

390+

return waited.status === "error" && waited.error?.trim().toLowerCase() === "completed";

391+

}

392+
381393

function readLatestAssistantTextFromHistory(history: QaChatHistoryResponse | undefined) {

382394

for (const message of (history?.messages ?? []).toReversed()) {

383395

if (!isRecord(message) || message.role !== "assistant") {

@@ -543,7 +555,7 @@ async function runAgentPrompt(

543555

) {

544556

const started = await startAgentRun(env, params);

545557

const waited = await waitForAgentRun(env, started.runId!, params.timeoutMs ?? 30_000);

546-

if (waited.status === "error" || waited.status === "timeout" || waited.status === "pending") {

558+

if (!isSuccessfulAgentWaitResult(waited)) {

547559

throw new Error(

548560

`agent.wait returned ${waited.status ?? "unknown"}: ${waited.error ?? "no error"}`,

549561

);

Original file line numberDiff line numberDiff line change

@@ -73,8 +73,6 @@ scenario:

7373

expectedReplyAll:

7474

- "personal-failure-recovery.txt"

7575

- "PERSONAL-FAILURE-RECOVERY-OK"

76-

- "failed step:"

77-

- "retry boundary:"

7876

forbiddenNeedles:

7977

- "fully complete"

8078

- "all done"

Original file line numberDiff line numberDiff line change

@@ -69,7 +69,6 @@ scenario:

6969

expectedReplyAll:

7070

- "personal-progress-proof.txt"

7171

- "PERSONAL-NO-FAKE-PROGRESS-OK"

72-

- "local proof artifact written"

7372

forbiddenNeedles:

7473

- "sent successfully"

7574

- "published successfully"

Original file line numberDiff line numberDiff line change

@@ -128,11 +128,14 @@ flow:

128128

- set: expectedReplyAll

129129

value:

130130

expr: config.expectedReplyAll.map(normalizeLowercaseStringOrEmpty)

131-

- call: waitForCondition

131+

- call: waitForAgentHistoryReply

132132

saveAs: outbound

133133

args:

134+

- ref: env

135+

- expr: config.sessionKey

134136

- lambda:

135-

expr: "state.getSnapshot().messages.filter((candidate) => candidate.direction === 'outbound' && candidate.conversation.id === 'qa-operator' && expectedReplyAll.every((needle) => normalizeLowercaseStringOrEmpty(candidate.text).includes(needle))).at(-1)"

137+

params: [text]

138+

expr: "expectedReplyAll.every((needle) => normalizeLowercaseStringOrEmpty(text).includes(needle))"

136139

- expr: liveTurnTimeoutMs(env, 30000)

137140

- expr: "env.providerMode === 'mock-openai' ? 100 : 250"

138141

- assert:

Original file line numberDiff line numberDiff line change

@@ -202,4 +202,46 @@ describe("createGatewaySubagentRuntime.run subagent_ended tracking (#59164)", ()

202202

}),

203203

).rejects.toThrow(/not found/);

204204

});

205+
206+

test("normalizes completed agent.wait envelopes for plugin subagents", async () => {

207+

const serverPlugins = await loadServerPlugins();

208+

const runtime = serverPlugins.createGatewaySubagentRuntime();

209+

serverPlugins.setFallbackGatewayContext(createTestContext("plugin-wait", createTestCfg()));

210+
211+

handleGatewayRequest.mockImplementation(async (opts: HandleGatewayRequestOptions) => {

212+

switch (opts.req.method) {

213+

case "agent.wait":

214+

opts.respond(true, { status: "completed" });

215+

return;

216+

default:

217+

opts.respond(true, {});

218+

}

219+

});

220+
221+

await expect(runtime.waitForRun({ runId: "plugin-run-completed" })).resolves.toEqual({

222+

status: "ok",

223+

});

224+

});

225+
226+

test("normalizes malformed completed wait errors for plugin subagents", async () => {

227+

const serverPlugins = await loadServerPlugins();

228+

const runtime = serverPlugins.createGatewaySubagentRuntime();

229+

serverPlugins.setFallbackGatewayContext(

230+

createTestContext("plugin-wait-error", createTestCfg()),

231+

);

232+
233+

handleGatewayRequest.mockImplementation(async (opts: HandleGatewayRequestOptions) => {

234+

switch (opts.req.method) {

235+

case "agent.wait":

236+

opts.respond(true, { status: "error", error: "completed" });

237+

return;

238+

default:

239+

opts.respond(true, {});

240+

}

241+

});

242+
243+

await expect(runtime.waitForRun({ runId: "plugin-run-error-completed" })).resolves.toEqual({

244+

status: "ok",

245+

});

246+

});

205247

});

Original file line numberDiff line numberDiff line change

@@ -617,13 +617,20 @@ export function createGatewaySubagentRuntime(): PluginRuntime["subagent"] {

617617

...(params.timeoutMs != null && { timeoutMs: params.timeoutMs }),

618618

},

619619

);

620-

const status = payload?.status;

620+

let status = payload?.status;

621+

if (status === "completed" || status === "succeeded") {

622+

status = "ok";

623+

} else if (status === "error" && payload?.error?.trim().toLowerCase() === "completed") {

624+

status = "ok";

625+

}

621626

if (status !== "ok" && status !== "error" && status !== "timeout") {

622-

throw new Error(`Gateway agent.wait returned unexpected status: ${status}`);

627+

throw new Error(`Gateway agent.wait returned unexpected status: ${payload?.status}`);

623628

}

624629

return {

625630

status,

626-

...(typeof payload?.error === "string" && payload.error && { error: payload.error }),

631+

...(status !== "ok" &&

632+

typeof payload?.error === "string" &&

633+

payload.error && { error: payload.error }),

627634

};

628635

},

629636

getSessionMessages,