fix(test): guard platform pin cli values · openclaw/openclaw@033455b

Recent Commits to openclaw:main

vincentkoc · 2026-06-20 · via Recent Commits to openclaw:main

Original file line number	Diff line number	Diff line change
`@@ -66,15 +66,12 @@ export function parseArgs(argv: string[]): CliOptions {`
`66`	`66`	`break;`
`67`	`67`	`}`
`68`	`68`	`case "--version": {`
`69`		`-explicitVersion = argv[index + 1] ?? null;`
	`69`	`+explicitVersion = readOptionValue(argv, index, "--version");`
`70`	`70`	`index += 1;`
`71`	`71`	`break;`
`72`	`72`	`}`
`73`	`73`	`case "--version-code": {`
`74`		`-const value = argv[index + 1];`
`75`		`-if (!value) {`
`76`		`-throw new Error("Missing value for --version-code.");`
`77`		`-}`
	`74`	`+const value = readOptionValue(argv, index, "--version-code");`
`78`	`75`	`explicitVersionCode = parseExplicitVersionCode(value);`
`79`	`76`	`index += 1;`
`80`	`77`	`break;`
`@@ -84,10 +81,7 @@ export function parseArgs(argv: string[]): CliOptions {`
`84`	`81`	`break;`
`85`	`82`	`}`
`86`	`83`	`case "--root": {`
`87`		`-const value = argv[index + 1];`
`88`		`-if (!value) {`
`89`		`-throw new Error("Missing value for --root.");`
`90`		`-}`
	`84`	`+const value = readOptionValue(argv, index, "--root");`
`91`	`85`	`rootDir = path.resolve(value);`
`92`	`86`	`index += 1;`
`93`	`87`	`break;`
`@@ -114,6 +108,14 @@ export function parseArgs(argv: string[]): CliOptions {`
`114`	`108`	`return { explicitVersion, explicitVersionCode, fromGateway, rootDir, sync };`
`115`	`109`	`}`
`116`	`110`
	`111`	`+function readOptionValue(argv: string[], index: number, flag: string): string {`
	`112`	`+const value = argv[index + 1];`
	`113`	`+if (value === undefined \|\| value === "" \|\| value.startsWith("-")) {`
	`114`	+throw new Error(`Missing value for ${flag}.`);
	`115`	`+}`
	`116`	`+return value;`
	`117`	`+}`
	`118`	`+`
`117`	`119`	`export function pinAndroidVersion(params: CliOptions): PinAndroidVersionResult {`
`118`	`120`	`const rootDir = path.resolve(params.rootDir);`
`119`	`121`	`let previousVersion: string \| null;`

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ export function parseArgs(argv: string[]): CliOptions {`
`47`	`47`	`break;`
`48`	`48`	`}`
`49`	`49`	`case "--version": {`
`50`		`-explicitVersion = argv[index + 1] ?? null;`
	`50`	`+explicitVersion = readOptionValue(argv, index, "--version");`
`51`	`51`	`index += 1;`
`52`	`52`	`break;`
`53`	`53`	`}`
`@@ -56,10 +56,7 @@ export function parseArgs(argv: string[]): CliOptions {`
`56`	`56`	`break;`
`57`	`57`	`}`
`58`	`58`	`case "--root": {`
`59`		`-const value = argv[index + 1];`
`60`		`-if (!value) {`
`61`		`-throw new Error("Missing value for --root.");`
`62`		`-}`
	`59`	`+const value = readOptionValue(argv, index, "--root");`
`63`	`60`	`rootDir = path.resolve(value);`
`64`	`61`	`index += 1;`
`65`	`62`	`break;`
`@@ -86,6 +83,14 @@ export function parseArgs(argv: string[]): CliOptions {`
`86`	`83`	`return { explicitVersion, fromGateway, rootDir, sync };`
`87`	`84`	`}`
`88`	`85`
	`86`	`+function readOptionValue(argv: string[], index: number, flag: string): string {`
	`87`	`+const value = argv[index + 1];`
	`88`	`+if (value === undefined \|\| value === "" \|\| value.startsWith("-")) {`
	`89`	+throw new Error(`Missing value for ${flag}.`);
	`90`	`+}`
	`91`	`+return value;`
	`92`	`+}`
	`93`	`+`
`89`	`94`	`export function pinIosVersion(params: CliOptions): PinIosVersionResult {`
`90`	`95`	`const rootDir = path.resolve(params.rootDir);`
`91`	`96`	`let previousVersion: string \| null;`

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,22 @@ describe("parseArgs", () => {`
`34`	`34`	`);`
`35`	`35`	`}`
`36`	`36`	`});`
	`37`	`+`
	`38`	`+it("rejects flags where option values are required", () => {`
	`39`	`+for (const { args, message } of [`
	`40`	`+{ args: ["--version", "--no-sync"], message: "Missing value for --version." },`
	`41`	`+{`
	`42`	`+args: ["--version", "2026.6.5", "--version-code", "--no-sync"],`
	`43`	`+message: "Missing value for --version-code.",`
	`44`	`+},`
	`45`	`+{`
	`46`	`+args: ["--version", "2026.6.5", "--root", "--no-sync"],`
	`47`	`+message: "Missing value for --root.",`
	`48`	`+},`
	`49`	`+]) {`
	`50`	`+expect(() => parseArgs(args)).toThrow(message);`
	`51`	`+}`
	`52`	`+});`
`37`	`53`	`});`
`38`	`54`
`39`	`55`	`describe("pinAndroidVersion", () => {`

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,18 @@ describe("parseArgs", () => {`
`17`	`17`	`"Choose exactly one of --from-gateway or --version <YYYY.M.PATCH>",`
`18`	`18`	`);`
`19`	`19`	`});`
	`20`	`+`
	`21`	`+it("rejects flags where option values are required", () => {`
	`22`	`+for (const { args, message } of [`
	`23`	`+{ args: ["--version", "--no-sync"], message: "Missing value for --version." },`
	`24`	`+{`
	`25`	`+args: ["--version", "2026.4.7", "--root", "--no-sync"],`
	`26`	`+message: "Missing value for --root.",`
	`27`	`+},`
	`28`	`+]) {`
	`29`	`+expect(() => parseArgs(args)).toThrow(message);`
	`30`	`+}`
	`31`	`+});`
`20`	`32`	`});`
`21`	`33`
`22`	`34`	`describe("pinIosVersion", () => {`

此内容由惯性聚合(RSS阅读器)自动聚合整理，仅供阅读参考。原文来自 — 版权归原作者所有。

推荐订阅源

Recent Commits to openclaw:main