惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

博客园_首页
Y
Y Combinator Blog
Engineering at Meta
Engineering at Meta
D
Docker
GbyAI
GbyAI
aimingoo的专栏
aimingoo的专栏
大猫的无限游戏
大猫的无限游戏
腾讯CDC
P
Proofpoint News Feed
A
About on SuperTechFans
WordPress大学
WordPress大学
Stack Overflow Blog
Stack Overflow Blog
Google DeepMind News
Google DeepMind News
C
Check Point Blog
Microsoft Security Blog
Microsoft Security Blog
H
Hackread – Cybersecurity News, Data Breaches, AI and More
L
LangChain Blog
MyScale Blog
MyScale Blog
博客园 - 三生石上(FineUI控件)
Hugging Face - Blog
Hugging Face - Blog
Microsoft Azure Blog
Microsoft Azure Blog
N
Netflix TechBlog - Medium
G
Google Developers Blog
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(browser): preserve explicit ai snapshot refs · opencl...
steipete · 2026-04-25 · via Recent Commits to openclaw:main
Original file line numberDiff line numberDiff line change

@@ -11,6 +11,7 @@ Docs: https://docs.openclaw.ai

1111
1212

### Fixes

1313
14+

- Browser/tool: keep explicit AI snapshots from inheriting the efficient role-snapshot default and preserve numeric Playwright AI refs, so `--format ai` remains a real AI snapshot path. Fixes #62550. Thanks @ly85206559.

1415

- Slack/messages: serialize write-client requests and whole outbound sends per target so rapid multi-message Slack replies preserve send order. Fixes #69101. (#69105) Thanks @nightq and @ztexydt-cqh.

1516

- Slack/messages: keep Slack bot tokens out of internal message-ordering and DM cache keys.

1617

- Slack/exec approvals: resolve native approval button clicks over the Gateway instead of delivering `/approve ...` as plain agent text, preserving retry buttons if Gateway resolution fails. Fixes #71023. (#71025) Thanks @marusan03.

Original file line numberDiff line numberDiff line change

@@ -234,13 +234,12 @@ export async function executeSnapshotAction(params: {

234234

const { input, baseUrl, profile, proxyRequest } = params;

235235

const snapshotDefaults = browserToolActionDeps.loadConfig().browser?.snapshotDefaults;

236236

const format: "ai" | "aria" | undefined =

237-

input.snapshotFormat === "ai" || input.snapshotFormat === "aria"

238-

? input.snapshotFormat

239-

: undefined;

237+

input.snapshotFormat === "ai" ? "ai" : input.snapshotFormat === "aria" ? "aria" : undefined;

238+

const formatExplicit = format !== undefined;

240239

const mode: "efficient" | undefined =

241240

input.mode === "efficient"

242241

? "efficient"

243-

: format !== "aria" && snapshotDefaults?.mode === "efficient"

242+

: !formatExplicit && format !== "aria" && snapshotDefaults?.mode === "efficient"

244243

? "efficient"

245244

: undefined;

246245

const labels = typeof input.labels === "boolean" ? input.labels : undefined;

Original file line numberDiff line numberDiff line change

@@ -404,7 +404,8 @@ describe("browser tool snapshot maxChars", () => {

404404

configMocks.loadConfig.mockReturnValue({

405405

browser: { snapshotDefaults: { mode: "efficient" } },

406406

});

407-

await runSnapshotToolCall({ snapshotFormat: "ai" });

407+

const tool = createBrowserTool();

408+

await tool.execute?.("call-1", { action: "snapshot", target: "host" });

408409
409410

expect(browserClientMocks.browserSnapshot).toHaveBeenCalledWith(

410411

undefined,

@@ -414,6 +415,19 @@ describe("browser tool snapshot maxChars", () => {

414415

);

415416

});

416417
418+

it("does not apply config snapshot defaults to explicit ai snapshots", async () => {

419+

configMocks.loadConfig.mockReturnValue({

420+

browser: { snapshotDefaults: { mode: "efficient" } },

421+

});

422+

await runSnapshotToolCall({ snapshotFormat: "ai" });

423+
424+

expect(browserClientMocks.browserSnapshot).toHaveBeenCalled();

425+

const opts = browserClientMocks.browserSnapshot.mock.calls.at(-1)?.[1] as

426+

| { mode?: string }

427+

| undefined;

428+

expect(opts?.mode).toBeUndefined();

429+

});

430+
417431

it("does not apply config snapshot defaults to aria snapshots", async () => {

418432

configMocks.loadConfig.mockReturnValue({

419433

browser: { snapshotDefaults: { mode: "efficient" } },

Original file line numberDiff line numberDiff line change

@@ -136,6 +136,34 @@ describe("pw-ai", () => {

136136

expect(res.snapshot).toContain("TRUNCATED");

137137

});

138138
139+

it("returns numeric ai snapshot refs in the public snapshot output", async () => {

140+

const snapshot = ['- button "OK" [ref=1]', '- link "Docs" [ref=2]'].join("\n");

141+

const p1 = createPage({ targetId: "T1", snapshotFull: snapshot });

142+

const browser = createBrowser([p1.page]);

143+

(chromiumMock.connectOverCDP as unknown as ReturnType<typeof vi.fn>).mockResolvedValue(browser);

144+
145+

const res = await snapshotAiViaPlaywright({

146+

cdpUrl: "http://127.0.0.1:18792",

147+

targetId: "T1",

148+

});

149+
150+

expect(res.snapshot).toContain("[ref=1]");

151+

expect(res.snapshot).toContain("[ref=2]");

152+

expect(res.refs).toMatchObject({

153+

1: { role: "button", name: "OK" },

154+

2: { role: "link", name: "Docs" },

155+

});

156+
157+

await clickViaPlaywright({

158+

cdpUrl: "http://127.0.0.1:18792",

159+

targetId: "T1",

160+

ref: "1",

161+

});

162+
163+

expect(p1.locator).toHaveBeenCalledWith("aria-ref=1");

164+

expect(p1.click).toHaveBeenCalledTimes(1);

165+

});

166+
139167

it("clicks a ref using aria-ref locator", async () => {

140168

const p1 = createPage({ targetId: "T1" });

141169

const browser = createBrowser([p1.page]);

Original file line numberDiff line numberDiff line change

@@ -64,7 +64,7 @@ describe("pw-role-snapshot", () => {

6464

expect(parseRoleRef("e12")).toBe("e12");

6565

expect(parseRoleRef("@e12")).toBe("e12");

6666

expect(parseRoleRef("ref=e12")).toBe("e12");

67-

expect(parseRoleRef("12")).toBeNull();

67+

expect(parseRoleRef("12")).toBe("12");

6868

expect(parseRoleRef("")).toBeNull();

6969

});

7070

@@ -87,4 +87,18 @@ describe("pw-role-snapshot", () => {

8787

expect(res.refs.e5).toMatchObject({ role: "link", name: "Home" });

8888

expect(res.refs.e7).toMatchObject({ role: "button", name: "Save" });

8989

});

90+
91+

it("preserves numeric Playwright AI snapshot refs", () => {

92+

const ai = [

93+

"- navigation [ref=1]:",

94+

' - link "Home" [ref=5]',

95+

' - button "Save" [ref=7] [cursor=pointer]:',

96+

].join("\n");

97+
98+

const res = buildRoleSnapshotFromAiSnapshot(ai, { interactive: true });

99+

expect(res.snapshot).toContain("[ref=5]");

100+

expect(Object.keys(res.refs).toSorted()).toEqual(["5", "7"]);

101+

expect(res.refs["5"]).toMatchObject({ role: "link", name: "Home" });

102+

expect(res.refs["7"]).toMatchObject({ role: "button", name: "Save" });

103+

});

90104

});

Original file line numberDiff line numberDiff line change

@@ -265,7 +265,13 @@ export function parseRoleRef(raw: string): string | null {

265265

: trimmed.startsWith("ref=")

266266

? trimmed.slice(4)

267267

: trimmed;

268-

return /^e\d+$/.test(normalized) ? normalized : null;

268+

if (/^e\d+$/i.test(normalized)) {

269+

return normalized;

270+

}

271+

if (/^\d{1,9}$/.test(normalized)) {

272+

return normalized;

273+

}

274+

return null;

269275

}

270276
271277

export function buildRoleSnapshotFromAriaSnapshot(

@@ -328,8 +334,12 @@ export function buildRoleSnapshotFromAriaSnapshot(

328334

}

329335
330336

function parseAiSnapshotRef(suffix: string): string | null {

331-

const match = suffix.match(/\[ref=(e\d+)\]/i);

332-

return match ? match[1] : null;

337+

const eMatch = suffix.match(/\[ref=(e\d+)\]/i);

338+

if (eMatch) {

339+

return eMatch[1];

340+

}

341+

const numMatch = suffix.match(/\[ref=(\d{1,9})\]/);

342+

return numMatch ? numMatch[1] : null;

333343

}

334344
335345

/**

Original file line numberDiff line numberDiff line change

@@ -101,12 +101,17 @@ describe("browser cli snapshot defaults", () => {

101101

args: ["--format", "aria"],

102102

expectMode: undefined,

103103

},

104+

{

105+

label: "does not apply config snapshot defaults to explicit ai snapshots",

106+

args: ["--format", "ai"],

107+

expectMode: undefined,

108+

},

104109

])("$label", async ({ args, expectMode }) => {

105110

configMocks.loadConfig.mockReturnValue({

106111

browser: { snapshotDefaults: { mode: "efficient" } },

107112

});

108113
109-

if (args.includes("--format")) {

114+

if (args.includes("--format") && args.includes("aria")) {

110115

gatewayMocks.callGatewayFromCli.mockResolvedValueOnce({

111116

ok: true,

112117

format: "aria",

Original file line numberDiff line numberDiff line change

@@ -75,8 +75,13 @@ export function registerBrowserInspectCommands(

7575

const parent = parentOpts(cmd);

7676

const profile = parent?.browserProfile;

7777

const format = opts.format === "aria" ? "aria" : "ai";

78+

const formatWasExplicit =

79+

typeof cmd.getOptionValueSource === "function" &&

80+

cmd.getOptionValueSource("format") === "cli";

7881

const configMode =

79-

format === "ai" && loadConfig().browser?.snapshotDefaults?.mode === "efficient"

82+

!formatWasExplicit &&

83+

format === "ai" &&

84+

loadConfig().browser?.snapshotDefaults?.mode === "efficient"

8085

? "efficient"

8186

: undefined;

8287

const mode = opts.efficient === true || opts.mode === "efficient" ? "efficient" : configMode;