惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

Google DeepMind News
Google DeepMind News
aimingoo的专栏
aimingoo的专栏
爱范儿
爱范儿
D
Docker
I
InfoQ
Microsoft Security Blog
Microsoft Security Blog
G
Google Developers Blog
OSCHINA 社区最新新闻
OSCHINA 社区最新新闻
Vercel News
Vercel News
H
Hackread – Cybersecurity News, Data Breaches, AI and More
T
Tailwind CSS Blog
D
DataBreaches.Net
月光博客
月光博客
N
Netflix TechBlog - Medium
Cyber Security Advisories - MS-ISAC
Cyber Security Advisories - MS-ISAC
让小产品的独立变现更简单 - ezindie.com
让小产品的独立变现更简单 - ezindie.com
V
Visual Studio Blog
MyScale Blog
MyScale Blog
B
Blog
阮一峰的网络日志
阮一峰的网络日志
L
LangChain Blog
Recent Announcements
Recent Announcements
Microsoft Azure Blog
Microsoft Azure Blog
WordPress大学
WordPress大学

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(channels): harden manifest read-only metadata · openc...
vincentkoc · 2026-04-25 · via Recent Commits to openclaw:main

@@ -1,5 +1,6 @@

11

import { resolveAgentWorkspaceDir, resolveDefaultAgentId } from "../../agents/agent-scope.js";

22

import type { OpenClawConfig } from "../../config/types.openclaw.js";

3+

import { isBlockedObjectKey } from "../../infra/prototype-keys.js";

34

import {

45

hasExplicitChannelConfig,

56

listConfiguredChannelIdsForReadOnlyScope,

@@ -10,11 +11,14 @@ import {

1011

loadPluginManifestRegistry,

1112

type PluginManifestRecord,

1213

} from "../../plugins/manifest-registry.js";

13-

import { DEFAULT_ACCOUNT_ID } from "../../routing/session-key.js";

14+

import { DEFAULT_ACCOUNT_ID, normalizeAccountId } from "../../routing/session-key.js";

15+

import { sanitizeForLog } from "../../terminal/ansi.js";

1416

import { getBundledChannelSetupPlugin } from "./bundled.js";

1517

import { listChannelPlugins } from "./registry.js";

1618

import type { ChannelPlugin } from "./types.plugin.js";

171920+

const SAFE_MANIFEST_CHANNEL_ID_PATTERN = /^[a-z0-9][a-z0-9_-]{0,63}$/i;

21+1822

type ReadOnlyChannelPluginOptions = {

1923

env?: NodeJS.ProcessEnv;

2024

workspaceDir?: string;

@@ -28,6 +32,7 @@ type ReadOnlyChannelPluginResolution = {

2832

configuredChannelIds: string[];

2933

missingConfiguredChannelIds: string[];

3034

};

35+

type ManifestChannelConfigRecord = NonNullable<PluginManifestRecord["channelConfigs"]>[string];

31363237

function addChannelPlugins(

3338

byId: Map<string, ChannelPlugin>,

@@ -66,6 +71,21 @@ function rebindChannelScopedString(

6671

return value;

6772

}

687374+

function isSafeManifestChannelId(channelId: string): boolean {

75+

return SAFE_MANIFEST_CHANNEL_ID_PATTERN.test(channelId) && !isBlockedObjectKey(channelId);

76+

}

77+78+

function readOwnRecordValue(record: Record<string, unknown>, key: string): unknown {

79+

if (isBlockedObjectKey(key) || !Object.prototype.hasOwnProperty.call(record, key)) {

80+

return undefined;

81+

}

82+

return record[key];

83+

}

84+85+

function normalizeManifestText(value: string | undefined, fallback: string): string {

86+

return sanitizeForLog(value?.trim() || fallback).trim();

87+

}

88+6989

function rebindChannelConfig(

7090

cfg: OpenClawConfig,

7191

sourceChannelId: string,

@@ -113,11 +133,14 @@ function restoreReboundChannelConfig(params: {

113133

}

114134115135

function getChannelConfigRecord(cfg: OpenClawConfig, channelId: string): Record<string, unknown> {

136+

if (!isSafeManifestChannelId(channelId)) {

137+

return {};

138+

}

116139

const channels = cfg.channels;

117140

if (!channels || typeof channels !== "object" || Array.isArray(channels)) {

118141

return {};

119142

}

120-

const entry = (channels as Record<string, unknown>)[channelId];

143+

const entry = readOwnRecordValue(channels as Record<string, unknown>, channelId);

121144

return entry && typeof entry === "object" && !Array.isArray(entry)

122145

? (entry as Record<string, unknown>)

123146

: {};

@@ -127,7 +150,14 @@ function listManifestChannelAccountIds(cfg: OpenClawConfig, channelId: string):

127150

const channelConfig = getChannelConfigRecord(cfg, channelId);

128151

const accounts = channelConfig.accounts;

129152

if (accounts && typeof accounts === "object" && !Array.isArray(accounts)) {

130-

return Object.keys(accounts).toSorted((left, right) => left.localeCompare(right));

153+

return [

154+

...new Set(

155+

Object.keys(accounts)

156+

.filter((accountId) => !isBlockedObjectKey(accountId))

157+

.map((accountId) => normalizeAccountId(accountId))

158+

.filter((accountId) => !isBlockedObjectKey(accountId)),

159+

),

160+

].toSorted((left, right) => left.localeCompare(right));

131161

}

132162

return hasExplicitChannelConfig({ config: cfg, channelId }) ? [DEFAULT_ACCOUNT_ID] : [];

133163

}

@@ -138,10 +168,13 @@ function resolveManifestChannelAccountConfig(params: {

138168

accountId?: string | null;

139169

}): Record<string, unknown> {

140170

const channelConfig = getChannelConfigRecord(params.cfg, params.channelId);

141-

const resolvedAccountId = params.accountId?.trim() || DEFAULT_ACCOUNT_ID;

171+

const resolvedAccountId = normalizeAccountId(params.accountId);

142172

const accounts = channelConfig.accounts;

143173

if (accounts && typeof accounts === "object" && !Array.isArray(accounts)) {

144-

const accountConfig = (accounts as Record<string, unknown>)[resolvedAccountId];

174+

const accountConfig = readOwnRecordValue(

175+

accounts as Record<string, unknown>,

176+

resolvedAccountId,

177+

);

145178

if (accountConfig && typeof accountConfig === "object" && !Array.isArray(accountConfig)) {

146179

return accountConfig as Record<string, unknown>;

147180

}

@@ -153,19 +186,31 @@ function buildManifestChannelPlugin(params: {

153186

record: PluginManifestRecord;

154187

channelId: string;

155188

}): ChannelPlugin | undefined {

156-

const channelConfig = params.record.channelConfigs?.[params.channelId];

157-

if (!channelConfig) {

189+

if (!isSafeManifestChannelId(params.channelId)) {

190+

return undefined;

191+

}

192+

const channelConfigValue = params.record.channelConfigs

193+

? readOwnRecordValue(params.record.channelConfigs as Record<string, unknown>, params.channelId)

194+

: undefined;

195+

if (

196+

!channelConfigValue ||

197+

typeof channelConfigValue !== "object" ||

198+

Array.isArray(channelConfigValue)

199+

) {

158200

return undefined;

159201

}

160-

const label = channelConfig.label?.trim() || params.record.name || params.channelId;

161-

const blurb = channelConfig.description?.trim() || params.record.description || "";

202+

const channelConfig = channelConfigValue as ManifestChannelConfigRecord;

203+

const label =

204+

normalizeManifestText(channelConfig.label, params.record.name || params.channelId) ||

205+

params.channelId;

206+

const blurb = normalizeManifestText(channelConfig.description, params.record.description || "");

162207

return {

163208

id: params.channelId,

164209

meta: {

165210

id: params.channelId,

166211

label,

167212

selectionLabel: label,

168-

docsPath: `/channels/${params.channelId}`,

213+

docsPath: `/channels/${encodeURIComponent(params.channelId)}`,

169214

blurb,

170215

...(channelConfig.preferOver?.length ? { preferOver: channelConfig.preferOver } : {}),

171216

},

@@ -179,7 +224,7 @@ function buildManifestChannelPlugin(params: {

179224

listAccountIds: (cfg) => listManifestChannelAccountIds(cfg, params.channelId),

180225

defaultAccountId: () => DEFAULT_ACCOUNT_ID,

181226

resolveAccount: (cfg, accountId) => ({

182-

accountId: accountId?.trim() || DEFAULT_ACCOUNT_ID,

227+

accountId: normalizeAccountId(accountId),

183228

config: resolveManifestChannelAccountConfig({

184229

cfg,

185230

channelId: params.channelId,

@@ -340,7 +385,9 @@ function addSetupChannelPlugins(

340385

},

341386

): void {

342387

for (const setup of setups) {

343-

const ownedMissingChannelIds = options.ownedMissingChannelIdsByPluginId.get(setup.pluginId);

388+

const ownedMissingChannelIds = options.ownedMissingChannelIdsByPluginId

389+

.get(setup.pluginId)

390+

?.filter(isSafeManifestChannelId);

344391

if (!ownedMissingChannelIds || ownedMissingChannelIds.length === 0) {

345392

continue;

346393

}

@@ -361,7 +408,9 @@ function addSetupChannelPlugins(

361408

);

362409

continue;

363410

}

364-

const ownedChannelIds = options.ownedChannelIdsByPluginId.get(setup.pluginId) ?? [];

411+

const ownedChannelIds = (options.ownedChannelIdsByPluginId.get(setup.pluginId) ?? []).filter(

412+

isSafeManifestChannelId,

413+

);

365414

if (setup.plugin.id !== setup.pluginId && !ownedChannelIds.includes(setup.plugin.id)) {

366415

continue;

367416

}

@@ -395,6 +444,9 @@ function addManifestChannelPlugins(

395444

continue;

396445

}

397446

for (const channelId of record.channels) {

447+

if (!isSafeManifestChannelId(channelId)) {

448+

continue;

449+

}

398450

if (!channelIds.has(channelId)) {

399451

continue;

400452

}

@@ -487,7 +539,7 @@ export function resolveReadOnlyChannelPluginsForConfig(

487539

manifestRecords,

488540

}),

489541

),

490-

];

542+

].filter(isSafeManifestChannelId);

491543

const byId = new Map<string, ChannelPlugin>();

492544493545

addChannelPlugins(byId, listChannelPlugins());