惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

D
Docker
酷 壳 – CoolShell
酷 壳 – CoolShell
博客园 - Franky
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
A
About on SuperTechFans
博客园 - 【当耐特】
Microsoft Security Blog
Microsoft Security Blog
H
Hackread – Cybersecurity News, Data Breaches, AI and More
The GitHub Blog
The GitHub Blog
雷峰网
雷峰网
博客园_首页
freeCodeCamp Programming Tutorials: Python, JavaScript, Git & More
IT之家
IT之家
博客园 - 叶小钗
Google DeepMind News
Google DeepMind News
aimingoo的专栏
aimingoo的专栏
博客园 - 聂微东
B
Blog RSS Feed
H
Help Net Security
Recent Announcements
Recent Announcements
阮一峰的网络日志
阮一峰的网络日志
D
DataBreaches.Net
L
LangChain Blog
Vercel News
Vercel News

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
refactor: isolate exec approval followup handoff · opencl...
steipete · 2026-05-10 · via Recent Commits to openclaw:main

@@ -3,16 +3,30 @@ import { normalizeOptionalString } from "../shared/string-coerce.js";

33

import type { ExecElevatedDefaults } from "./bash-tools.exec-types.js";

4455

const EXEC_APPROVAL_FOLLOWUP_IDEMPOTENCY_PREFIX = "exec-approval-followup:";

6-

const EXEC_APPROVAL_FOLLOWUP_ELEVATED_TOKEN_MARKER = ":elevated:";

7-

const EXEC_APPROVAL_FOLLOWUP_ELEVATED_TTL_MS = 5 * 60 * 1000;

6+

const EXEC_APPROVAL_FOLLOWUP_IDEMPOTENCY_NONCE_MARKER = ":nonce:";

7+

const EXEC_APPROVAL_FOLLOWUP_RUNTIME_HANDOFF_TTL_MS = 5 * 60 * 1000;

889-

type ExecApprovalFollowupElevatedEntry = {

9+

export type ExecApprovalFollowupRuntimeHandoff = {

10+

kind: "exec-approval-followup";

11+

approvalId: string;

1012

sessionKey: string;

13+

idempotencyKey: string;

1114

bashElevated: ExecElevatedDefaults;

15+

};

16+17+

export type ExecApprovalFollowupRuntimeHandoffRegistration = {

18+

handoffId: string;

19+

idempotencyKey: string;

20+

};

21+22+

type ExecApprovalFollowupRuntimeHandoffEntry = ExecApprovalFollowupRuntimeHandoff & {

1223

expiresAtMs: number;

1324

};

142515-

const execApprovalFollowupElevatedDefaults = new Map<string, ExecApprovalFollowupElevatedEntry>();

26+

const execApprovalFollowupRuntimeHandoffs = new Map<

27+

string,

28+

ExecApprovalFollowupRuntimeHandoffEntry

29+

>();

16301731

function cloneExecElevatedDefaults(value: ExecElevatedDefaults): ExecElevatedDefaults {

1832

return {

@@ -28,96 +42,109 @@ function cloneExecElevatedDefaults(value: ExecElevatedDefaults): ExecElevatedDef

2842

};

2943

}

304431-

function pruneExpiredExecApprovalFollowupElevatedDefaults(nowMs: number): void {

32-

for (const [token, entry] of execApprovalFollowupElevatedDefaults) {

45+

function cloneExecApprovalFollowupRuntimeHandoff(

46+

value: ExecApprovalFollowupRuntimeHandoff,

47+

): ExecApprovalFollowupRuntimeHandoff {

48+

return {

49+

kind: value.kind,

50+

approvalId: value.approvalId,

51+

sessionKey: value.sessionKey,

52+

idempotencyKey: value.idempotencyKey,

53+

bashElevated: cloneExecElevatedDefaults(value.bashElevated),

54+

};

55+

}

56+57+

function pruneExpiredExecApprovalFollowupRuntimeHandoffs(nowMs: number): void {

58+

for (const [handoffId, entry] of execApprovalFollowupRuntimeHandoffs) {

3359

if (entry.expiresAtMs <= nowMs) {

34-

execApprovalFollowupElevatedDefaults.delete(token);

60+

execApprovalFollowupRuntimeHandoffs.delete(handoffId);

3561

}

3662

}

3763

}

38643965

export function buildExecApprovalFollowupIdempotencyKey(params: {

4066

approvalId: string;

41-

execApprovalFollowupToken?: string;

67+

nonce?: string;

4268

}): string {

4369

const base = `${EXEC_APPROVAL_FOLLOWUP_IDEMPOTENCY_PREFIX}${params.approvalId}`;

44-

return params.execApprovalFollowupToken

45-

? `${base}${EXEC_APPROVAL_FOLLOWUP_ELEVATED_TOKEN_MARKER}${params.execApprovalFollowupToken}`

46-

: base;

70+

const nonce = normalizeOptionalString(params.nonce);

71+

return nonce ? `${base}${EXEC_APPROVAL_FOLLOWUP_IDEMPOTENCY_NONCE_MARKER}${nonce}` : base;

4772

}

487349-

function parseExecApprovalFollowupToken(idempotencyKey: string): string | undefined {

50-

if (!idempotencyKey.startsWith(EXEC_APPROVAL_FOLLOWUP_IDEMPOTENCY_PREFIX)) {

74+

export function parseExecApprovalFollowupApprovalId(idempotencyKey: string): string | undefined {

75+

const normalized = normalizeOptionalString(idempotencyKey);

76+

if (!normalized?.startsWith(EXEC_APPROVAL_FOLLOWUP_IDEMPOTENCY_PREFIX)) {

5177

return undefined;

5278

}

53-

const tokenMarker = idempotencyKey.lastIndexOf(EXEC_APPROVAL_FOLLOWUP_ELEVATED_TOKEN_MARKER);

54-

if (tokenMarker < EXEC_APPROVAL_FOLLOWUP_IDEMPOTENCY_PREFIX.length) {

55-

return undefined;

56-

}

57-

return normalizeOptionalString(

58-

idempotencyKey.slice(tokenMarker + EXEC_APPROVAL_FOLLOWUP_ELEVATED_TOKEN_MARKER.length),

59-

);

79+

const body = normalized.slice(EXEC_APPROVAL_FOLLOWUP_IDEMPOTENCY_PREFIX.length);

80+

const nonceMarker = body.lastIndexOf(EXEC_APPROVAL_FOLLOWUP_IDEMPOTENCY_NONCE_MARKER);

81+

return normalizeOptionalString(nonceMarker >= 0 ? body.slice(0, nonceMarker) : body);

6082

}

618362-

export function registerExecApprovalFollowupElevatedDefaults(params: {

84+

export function registerExecApprovalFollowupRuntimeHandoff(params: {

85+

approvalId: string;

6386

sessionKey: string;

6487

bashElevated?: ExecElevatedDefaults;

6588

nowMs?: number;

66-

}): string | undefined {

89+

}): ExecApprovalFollowupRuntimeHandoffRegistration | undefined {

90+

const approvalId = normalizeOptionalString(params.approvalId);

6791

const sessionKey = normalizeOptionalString(params.sessionKey);

68-

if (!params.bashElevated || !sessionKey) {

92+

if (!approvalId || !sessionKey || !params.bashElevated) {

6993

return undefined;

7094

}

7195

const nowMs = params.nowMs ?? Date.now();

72-

pruneExpiredExecApprovalFollowupElevatedDefaults(nowMs);

73-

const token = randomUUID();

74-

execApprovalFollowupElevatedDefaults.set(token, {

96+

pruneExpiredExecApprovalFollowupRuntimeHandoffs(nowMs);

97+

const handoffId = randomUUID();

98+

const idempotencyKey = buildExecApprovalFollowupIdempotencyKey({

99+

approvalId,

100+

nonce: randomUUID(),

101+

});

102+

execApprovalFollowupRuntimeHandoffs.set(handoffId, {

103+

kind: "exec-approval-followup",

104+

approvalId,

75105

sessionKey,

106+

idempotencyKey,

76107

bashElevated: cloneExecElevatedDefaults(params.bashElevated),

77-

expiresAtMs: nowMs + EXEC_APPROVAL_FOLLOWUP_ELEVATED_TTL_MS,

108+

expiresAtMs: nowMs + EXEC_APPROVAL_FOLLOWUP_RUNTIME_HANDOFF_TTL_MS,

78109

});

79-

return token;

110+

return { handoffId, idempotencyKey };

80111

}

8111282-

export function consumeExecApprovalFollowupElevatedDefaults(params: {

83-

token?: string;

113+

export function consumeExecApprovalFollowupRuntimeHandoff(params: {

114+

handoffId?: string;

115+

approvalId?: string;

116+

idempotencyKey?: string;

84117

sessionKey?: string;

85118

nowMs?: number;

86-

}): ExecElevatedDefaults | undefined {

87-

const token = normalizeOptionalString(params.token);

88-

if (!token) {

119+

}): ExecApprovalFollowupRuntimeHandoff | undefined {

120+

const handoffId = normalizeOptionalString(params.handoffId);

121+

const approvalId = normalizeOptionalString(params.approvalId);

122+

const idempotencyKey = normalizeOptionalString(params.idempotencyKey);

123+

if (!handoffId || !approvalId || !idempotencyKey) {

89124

return undefined;

90125

}

91126

const nowMs = params.nowMs ?? Date.now();

92-

pruneExpiredExecApprovalFollowupElevatedDefaults(nowMs);

93-

const entry = execApprovalFollowupElevatedDefaults.get(token);

127+

pruneExpiredExecApprovalFollowupRuntimeHandoffs(nowMs);

128+

const entry = execApprovalFollowupRuntimeHandoffs.get(handoffId);

94129

if (!entry) {

95130

return undefined;

96131

}

97132

if (entry.expiresAtMs <= nowMs) {

98-

execApprovalFollowupElevatedDefaults.delete(token);

133+

execApprovalFollowupRuntimeHandoffs.delete(handoffId);

99134

return undefined;

100135

}

101136

const sessionKey = normalizeOptionalString(params.sessionKey);

102-

if (entry.sessionKey !== sessionKey) {

137+

if (

138+

entry.approvalId !== approvalId ||

139+

entry.idempotencyKey !== idempotencyKey ||

140+

entry.sessionKey !== sessionKey

141+

) {

103142

return undefined;

104143

}

105-

execApprovalFollowupElevatedDefaults.delete(token);

106-

return cloneExecElevatedDefaults(entry.bashElevated);

107-

}

108-109-

export function consumeExecApprovalFollowupElevatedDefaultsFromIdempotencyKey(params: {

110-

idempotencyKey: string;

111-

sessionKey?: string;

112-

nowMs?: number;

113-

}): ExecElevatedDefaults | undefined {

114-

return consumeExecApprovalFollowupElevatedDefaults({

115-

token: parseExecApprovalFollowupToken(params.idempotencyKey),

116-

sessionKey: params.sessionKey,

117-

nowMs: params.nowMs,

118-

});

144+

execApprovalFollowupRuntimeHandoffs.delete(handoffId);

145+

return cloneExecApprovalFollowupRuntimeHandoff(entry);

119146

}

120147121-

export function resetExecApprovalFollowupElevatedDefaultsForTests(): void {

122-

execApprovalFollowupElevatedDefaults.clear();

148+

export function resetExecApprovalFollowupRuntimeHandoffsForTests(): void {

149+

execApprovalFollowupRuntimeHandoffs.clear();

123150

}