fix(qa): reject loose mock OpenAI ports · openclaw/openclaw@ae99ce7

Recent Commits to openclaw:main

vincentkoc · 2026-06-17 · via Recent Commits to openclaw:main

File tree

- npm-onboard-channel-agent

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,26 @@`
`1`	`1`	`// Mock OpenAI model config helpers for E2E fixture generation.`
	`2`	`+function formatMockPortValue(value) {`
	`3`	`+return value === undefined ? "<missing>" : JSON.stringify(String(value));`
	`4`	`+}`
	`5`	`+`
	`6`	`+export function parseMockOpenAiPort(value, label = "mock OpenAI port") {`
	`7`	`+const text = String(value ?? "").trim();`
	`8`	`+if (!/^[1-9]\d*$/u.test(text)) {`
	`9`	`+throw new Error(`
	`10`	+`${label} must be a TCP port from 1 to 65535. Got: ${formatMockPortValue(value)}`,
	`11`	`+);`
	`12`	`+}`
	`13`	`+const port = Number(text);`
	`14`	`+if (!Number.isSafeInteger(port) \|\| port > 65535) {`
	`15`	`+throw new Error(`
	`16`	+`${label} must be a TCP port from 1 to 65535. Got: ${formatMockPortValue(value)}`,
	`17`	`+);`
	`18`	`+}`
	`19`	`+return port;`
	`20`	`+}`
	`21`	`+`
`2`	`22`	`export function applyMockOpenAiModelConfig(cfg, params) {`
	`23`	`+const mockPort = parseMockOpenAiPort(params.mockPort);`
`3`	`24`	`const modelRef = params.modelRef ?? "openai/gpt-5.5";`
`4`	`25`	`const modelId = modelRef.split("/").at(-1) ?? "gpt-5.5";`
`5`	`26`	`const cost = { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 };`
`@@ -10,7 +31,7 @@ export function applyMockOpenAiModelConfig(cfg, params) {`
`10`	`31`	`...cfg.models?.providers,`
`11`	`32`	`openai: {`
`12`	`33`	`...cfg.models?.providers?.openai,`
`13`		-baseUrl: `http://127.0.0.1:${params.mockPort}/v1`,
	`34`	+baseUrl: `http://127.0.0.1:${mockPort}/v1`,
`14`	`35`	`apiKey: { source: "env", provider: "default", id: "OPENAI_API_KEY" },`
`15`	`36`	`api: "openai-responses",`
`16`	`37`	`agentRuntime: { id: "openclaw" },`

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,10 @@ import {`
`8`	`8`	`} from "../agent-turn-output.mjs";`
`9`	`9`	`import { assertOpenAiEnvAuthProfileStore } from "../auth-profile-store-assertions.mjs";`
`10`	`10`	`import { readPositiveIntEnv } from "../env-limits.mjs";`
`11`		`-import { applyMockOpenAiModelConfig } from "../fixtures/mock-openai-config.mjs";`
	`11`	`+import {`
	`12`	`+applyMockOpenAiModelConfig,`
	`13`	`+parseMockOpenAiPort,`
	`14`	`+} from "../fixtures/mock-openai-config.mjs";`
`12`	`15`	`import { readTextFileBounded, readTextFileTail } from "../text-file-utils.mjs";`
`13`	`16`
`14`	`17`	`const command = process.argv[2];`
`@@ -117,15 +120,15 @@ function assertOnboardState() {`
`117`	`120`	`}`
`118`	`121`
`119`	`122`	`function configureMockModel() {`
`120`		`-const mockPort = Number(process.argv[3]);`
	`123`	`+const mockPort = parseMockOpenAiPort(process.argv[3]);`
`121`	`124`	`const configPath = path.join(process.env.HOME, ".openclaw", "openclaw.json");`
`122`	`125`	`const cfg = readJson(configPath);`
`123`	`126`	`applyMockOpenAiModelConfig(cfg, { mockPort });`
`124`	`127`	fs.writeFileSync(configPath, `${JSON.stringify(cfg, null, 2)}\n`);
`125`	`128`	`}`
`126`	`129`
`127`	`130`	`function assertMockModelConfig() {`
`128`		`-const mockPort = Number(process.argv[3]);`
	`131`	`+const mockPort = parseMockOpenAiPort(process.argv[3]);`
`129`	`132`	`const expectedModelRef = "openai/gpt-5.5";`
`130`	`133`	const expectedBaseUrl = `http://127.0.0.1:${mockPort}/v1`;
`131`	`134`	`const configPath = path.join(process.env.HOME, ".openclaw", "openclaw.json");`

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,10 @@ import {`
`7`	`7`	`assertOpenAiRequestLogUsed,`
`8`	`8`	`} from "../agent-turn-output.mjs";`
`9`	`9`	`import { assertOpenAiEnvAuthProfileStore } from "../auth-profile-store-assertions.mjs";`
`10`		`-import { applyMockOpenAiModelConfig } from "../fixtures/mock-openai-config.mjs";`
	`10`	`+import {`
	`11`	`+applyMockOpenAiModelConfig,`
	`12`	`+parseMockOpenAiPort,`
	`13`	`+} from "../fixtures/mock-openai-config.mjs";`
`11`	`14`	`import { readPluginInstallRecords } from "../plugin-index-sqlite.mjs";`
`12`	`15`	`import { readTextFileTail } from "../text-file-utils.mjs";`
`13`	`16`
`@@ -145,7 +148,7 @@ function readStateText() {`
`145`	`148`	`}`
`146`	`149`
`147`	`150`	`function configureMockOpenAi() {`
`148`		`-const mockPort = Number(process.argv[3]);`
	`151`	`+const mockPort = parseMockOpenAiPort(process.argv[3]);`
`149`	`152`	`const cfg = readJson(configPath());`
`150`	`153`	`applyMockOpenAiModelConfig(cfg, { mockPort, includeImageDefaults: true });`
`151`	`154`	`writeConfig(cfg);`

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,10 @@ import {`
`7`	`7`	`assertOpenAiRequestLogUsed,`
`8`	`8`	`} from "../agent-turn-output.mjs";`
`9`	`9`	`import { readBoundedResponseText as readBoundedResponseTextWithLimit } from "../bounded-response-text.mjs";`
`10`		`-import { applyMockOpenAiModelConfig } from "../fixtures/mock-openai-config.mjs";`
	`10`	`+import {`
	`11`	`+applyMockOpenAiModelConfig,`
	`12`	`+parseMockOpenAiPort,`
	`13`	`+} from "../fixtures/mock-openai-config.mjs";`
`11`	`14`	`import { readPluginInstallRecords } from "../plugin-index-sqlite.mjs";`
`12`	`15`	`import { readTextFileTail } from "../text-file-utils.mjs";`
`13`	`16`
`@@ -192,7 +195,7 @@ function assertOnboard() {`
`192`	`195`	`}`
`193`	`196`
`194`	`197`	`function configureMockModel() {`
`195`		`-const mockPort = Number(process.argv[3]);`
	`198`	`+const mockPort = parseMockOpenAiPort(process.argv[3]);`
`196`	`199`	`const cfg = readJson(configPath());`
`197`	`200`	`applyMockOpenAiModelConfig(cfg, { mockPort });`
`198`	`201`	`writeConfig(cfg);`

Original file line number	Diff line number	Diff line change
`@@ -84,6 +84,17 @@ function runOnboardAssert(home: string) {`
`84`	`84`	`});`
`85`	`85`	`}`
`86`	`86`
	`87`	`+function runMockModelAssert(home: string, command: string, port: string) {`
	`88`	`+return spawnSync(process.execPath, [assertionsPath, command, port], {`
	`89`	`+encoding: "utf8",`
	`90`	`+env: {`
	`91`	`+ ...process.env,`
	`92`	`+HOME: home,`
	`93`	`+NODE_OPTIONS: nodeOptionsWithoutExperimentalWarnings(),`
	`94`	`+},`
	`95`	`+});`
	`96`	`+}`
	`97`	`+`
`87`	`98`	`function runStatusAssert(`
`88`	`99`	`channel: string,`
`89`	`100`	`channelsStatus: unknown,`
`@@ -110,6 +121,22 @@ function runStatusAssert(`
`110`	`121`	`}`
`111`	`122`
`112`	`123`	`describe("npm onboard channel agent assertions", () => {`
	`124`	`+it("rejects loose mock OpenAI port args", () => {`
	`125`	`+const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-onboard-assertions-"));`
	`126`	`+`
	`127`	`+try {`
	`128`	`+for (const command of ["configure-mock-model", "assert-mock-model-config"]) {`
	`129`	`+const result = runMockModelAssert(tempDir, command, "1e3");`
	`130`	`+`
	`131`	`+expect(result.status).not.toBe(0);`
	`132`	`+expect(result.stderr).toContain("mock OpenAI port must be a TCP port from 1 to 65535");`
	`133`	`+expect(result.stderr).toContain('"1e3"');`
	`134`	`+}`
	`135`	`+} finally {`
	`136`	`+fs.rmSync(tempDir, { force: true, recursive: true });`
	`137`	`+}`
	`138`	`+});`
	`139`	`+`
`113`	`140`	`it("validates OpenAI env refs from the SQLite auth profile store", () => {`
`114`	`141`	`const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-onboard-assertions-"));`
`115`	`142`	`const agentDir = path.join(tempDir, ".openclaw", "agents", "main", "agent");`

Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,14 @@ function writeAuthProfileStoreSqlite(agentDir: string, store: unknown) {`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`describe("release scenario assertions", () => {`
	`58`	`+it("rejects loose mock OpenAI port args", () => {`
	`59`	`+const result = runAssertion(["configure-mock-openai", "1e3"]);`
	`60`	`+`
	`61`	`+expect(result.status).not.toBe(0);`
	`62`	`+expect(result.stderr).toContain("mock OpenAI port must be a TCP port from 1 to 65535");`
	`63`	`+expect(result.stderr).toContain('"1e3"');`
	`64`	`+});`
	`65`	`+`
`58`	`66`	`it("scans large files when checking release scenario output text", () => {`
`59`	`67`	`const root = mkdtempSync(path.join(tmpdir(), "openclaw-release-scenarios-"));`
`60`	`68`	`const outputPath = path.join(root, "output.log");`

Original file line number	Diff line number	Diff line change
`@@ -88,6 +88,21 @@ async function startTcpFixtureServer(handler: (socket: Socket) => void): Promise`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`describe("release user journey assertions", () => {`
	`91`	`+it("rejects loose mock OpenAI port args", () => {`
	`92`	`+const root = mkdtempSync(path.join(tmpdir(), "openclaw-release-user-assertions-"));`
	`93`	`+const home = path.join(root, "home");`
	`94`	`+`
	`95`	`+try {`
	`96`	`+const result = runAssertion(home, ["configure-mock-model", "1e3"]);`
	`97`	`+`
	`98`	`+expect(result.status).not.toBe(0);`
	`99`	`+expect(result.stderr).toContain("mock OpenAI port must be a TCP port from 1 to 65535");`
	`100`	`+expect(result.stderr).toContain('"1e3"');`
	`101`	`+} finally {`
	`102`	`+rmSync(root, { force: true, recursive: true });`
	`103`	`+}`
	`104`	`+});`
	`105`	`+`
`91`	`106`	`it("scans large files when checking release user journey output text", () => {`
`92`	`107`	`const root = mkdtempSync(path.join(tmpdir(), "openclaw-release-user-assertions-"));`
`93`	`108`	`const home = path.join(root, "home");`

此内容由惯性聚合(RSS阅读器)自动聚合整理，仅供阅读参考。原文来自 — 版权归原作者所有。

推荐订阅源

Recent Commits to openclaw:main

File tree