惯性聚合 高效追踪和阅读你感兴趣的博客、新闻、科技资讯
阅读原文 在惯性聚合中打开

推荐订阅源

有赞技术团队
有赞技术团队
M
MIT News - Artificial intelligence
Hugging Face - Blog
Hugging Face - Blog
博客园 - 聂微东
量子位
S
SegmentFault 最新的问题
V
Visual Studio Blog
博客园 - 【当耐特】
Apple Machine Learning Research
Apple Machine Learning Research
奇客Solidot–传递最新科技情报
奇客Solidot–传递最新科技情报
小众软件
小众软件
Stack Overflow Blog
Stack Overflow Blog
Vercel News
Vercel News
D
Docker
J
Java Code Geeks
博客园 - 三生石上(FineUI控件)
博客园 - Franky
Recent Announcements
Recent Announcements
freeCodeCamp Programming Tutorials: Python, JavaScript, Git & More
MongoDB | Blog
MongoDB | Blog
D
DataBreaches.Net
Y
Y Combinator Blog
云风的 BLOG
云风的 BLOG
V
V2EX

Recent Commits to openclaw:main

test: merge chat side-result checks · openclaw/openclaw@ddd2c2a test: merge cron history checks · openclaw/openclaw@f7eb746 test: merge responsive navigation shell checks · openclaw/openclaw@c2e4b47 docs(changelog): add codex oauth fixes · openclaw/openclaw@628e6cd test: merge navigation routing cases · openclaw/openclaw@5d8cecb Tests: mock channel registry bundled fallback · openclaw/openclaw@2b08233 Secrets: avoid broad web search discovery for single plugin config · openclaw/openclaw@a464f59 test: merge config view browser checks · openclaw/openclaw@20cf511 fix(status): align oauth health with runtime · openclaw/openclaw@eed7116 feat: add macOS screen snapshots for monitor preview (#67954) thanks … · openclaw/openclaw@f377db1 fix: report shared auth scopes in hello-ok (#67810) thanks @BunsDev · openclaw/openclaw@0b6c39b Auto-reply: avoid eager bundled route fallback · openclaw/openclaw@3ea1bf4 Tests: narrow session binding contract setup · openclaw/openclaw@54e4e16 fix(macOS): enable undo/redo in webchat composer text input (#34962) · openclaw/openclaw@00951dc Tests: speed up channel setup promotion · openclaw/openclaw@82b529a Docs: refresh agent instructions · openclaw/openclaw@5775fe2 fix(auth): serialize OAuth refresh across agents to fix #26322 (#67876) · openclaw/openclaw@8e79080 test: allow ollama public surface boundary test · openclaw/openclaw@7d4f1a6 Docs: add test performance guardrails · openclaw/openclaw@89706d3 Tests: restore context-engine usage proof · openclaw/openclaw@e4c4f95 Tests: slim context engine runtime coverage · openclaw/openclaw@74c198f ci: retry failed custom checkouts · openclaw/openclaw@0ee5baf test: trim duplicate provider auth onboarding cases · openclaw/openclaw@1ffc02e matrix: fix sessions_spawn --thread subagent session spawning (#67643) · openclaw/openclaw@1ce2596 test: reduce auth choice fixture churn · openclaw/openclaw@857b9cd test: mock health status config boundaries · openclaw/openclaw@9d5ab4a test: mock onboard config io boundary · openclaw/openclaw@299694d test: mock legacy state plugin boundaries · openclaw/openclaw@2713089 test: mock channel install boundaries · openclaw/openclaw@b945248 test: mock doctor preview channel boundaries · openclaw/openclaw@b1a3ad4
fix(acpx): stage Claude ACP adapter runtime dependency · ...
steipete · 2026-04-28 · via Recent Commits to openclaw:main

@@ -21,6 +21,10 @@ async function makeTempDir(): Promise<string> {

2121

return dir;

2222

}

232324+

function quoteArg(value: string): string {

25+

return JSON.stringify(value);

26+

}

27+2428

function restoreEnv(name: keyof typeof previousEnv): void {

2529

const value = previousEnv[name];

2630

if (value === undefined) {

@@ -42,11 +46,25 @@ function generatedCodexPaths(stateDir: string): {

4246

};

4347

}

444849+

function generatedClaudePaths(stateDir: string): {

50+

wrapperPath: string;

51+

} {

52+

const baseDir = path.join(stateDir, "acpx");

53+

return {

54+

wrapperPath: path.join(baseDir, "claude-agent-acp-wrapper.mjs"),

55+

};

56+

}

57+4558

function expectCodexWrapperCommand(command: string | undefined, wrapperPath: string): void {

4659

expect(command).toContain(process.execPath);

4760

expect(command).toContain(wrapperPath);

4861

}

496263+

function expectClaudeWrapperCommand(command: string | undefined, wrapperPath: string): void {

64+

expect(command).toContain(process.execPath);

65+

expect(command).toContain(wrapperPath);

66+

}

67+5068

afterEach(async () => {

5169

restoreEnv("CODEX_HOME");

5270

restoreEnv("OPENCLAW_AGENT_DIR");

@@ -62,6 +80,7 @@ describe("prepareAcpxCodexAuthConfig", () => {

6280

const agentDir = path.join(root, "agent");

6381

const stateDir = path.join(root, "state");

6482

const generated = generatedCodexPaths(stateDir);

83+

const generatedClaude = generatedClaudePaths(stateDir);

6584

const installedBinPath = path.join(

6685

root,

6786

"node_modules",

@@ -84,7 +103,9 @@ describe("prepareAcpxCodexAuthConfig", () => {

84103

});

8510486105

expectCodexWrapperCommand(resolved.agents.codex, generated.wrapperPath);

106+

expectClaudeWrapperCommand(resolved.agents.claude, generatedClaude.wrapperPath);

87107

await expect(fs.access(generated.wrapperPath)).resolves.toBeUndefined();

108+

await expect(fs.access(generatedClaude.wrapperPath)).resolves.toBeUndefined();

88109

const wrapper = await fs.readFile(generated.wrapperPath, "utf8");

89110

expect(wrapper).toContain(JSON.stringify(installedBinPath));

90111

expect(wrapper).toContain("defaultArgs = [installedBinPath]");

@@ -114,6 +135,28 @@ describe("prepareAcpxCodexAuthConfig", () => {

114135

expect(wrapper).not.toContain("@zed-industries/codex-acp@^0.11.1");

115136

});

116137138+

it("falls back to the patched Claude ACP package when the local adapter is unavailable", async () => {

139+

const root = await makeTempDir();

140+

const stateDir = path.join(root, "state");

141+

const generated = generatedClaudePaths(stateDir);

142+

const pluginConfig = resolveAcpxPluginConfig({

143+

rawConfig: {},

144+

workspaceDir: root,

145+

});

146+147+

await prepareAcpxCodexAuthConfig({

148+

pluginConfig,

149+

stateDir,

150+

resolveInstalledClaudeAcpBinPath: async () => undefined,

151+

});

152+153+

const wrapper = await fs.readFile(generated.wrapperPath, "utf8");

154+

expect(wrapper).toContain('"@agentclientprotocol/claude-agent-acp@0.31.0"');

155+

expect(wrapper).toContain('"--", "claude-agent-acp"');

156+

expect(wrapper).not.toContain("@agentclientprotocol/claude-agent-acp@^0.31.0");

157+

expect(wrapper).not.toContain("@agentclientprotocol/claude-agent-acp@0.31.1");

158+

});

159+117160

it("uses the bundled Codex ACP dependency by default when it is installed", async () => {

118161

const root = await makeTempDir();

119162

const stateDir = path.join(root, "state");

@@ -134,6 +177,26 @@ describe("prepareAcpxCodexAuthConfig", () => {

134177

expect(wrapper).toContain("defaultArgs = [installedBinPath]");

135178

});

136179180+

it("uses the bundled Claude ACP dependency by default when it is installed", async () => {

181+

const root = await makeTempDir();

182+

const stateDir = path.join(root, "state");

183+

const generated = generatedClaudePaths(stateDir);

184+

const pluginConfig = resolveAcpxPluginConfig({

185+

rawConfig: {},

186+

workspaceDir: root,

187+

});

188+189+

await prepareAcpxCodexAuthConfig({

190+

pluginConfig,

191+

stateDir,

192+

});

193+194+

const wrapper = await fs.readFile(generated.wrapperPath, "utf8");

195+

expect(wrapper).toContain("@agentclientprotocol/claude-agent-acp");

196+

expect(wrapper).toContain("dist/index.js");

197+

expect(wrapper).toContain("defaultArgs = [installedBinPath]");

198+

});

199+137200

it("launches the locally installed Codex ACP bin with isolated CODEX_HOME", async () => {

138201

const root = await makeTempDir();

139202

const stateDir = path.join(root, "state");

@@ -164,6 +227,39 @@ describe("prepareAcpxCodexAuthConfig", () => {

164227

expect(path.resolve(String(launched.codexHome))).toBe(expectedCodexHome);

165228

});

166229230+

it("launches the locally installed Claude ACP bin without going through npm", async () => {

231+

const root = await makeTempDir();

232+

const stateDir = path.join(root, "state");

233+

const generated = generatedClaudePaths(stateDir);

234+

const installedBinPath = path.join(root, "claude-agent-acp-bin.js");

235+

await fs.writeFile(

236+

installedBinPath,

237+

"console.log(JSON.stringify({ argv: process.argv.slice(2), codexHome: process.env.CODEX_HOME ?? null }));\n",

238+

"utf8",

239+

);

240+

const pluginConfig = resolveAcpxPluginConfig({

241+

rawConfig: {},

242+

workspaceDir: root,

243+

});

244+245+

await prepareAcpxCodexAuthConfig({

246+

pluginConfig,

247+

stateDir,

248+

resolveInstalledClaudeAcpBinPath: async () => installedBinPath,

249+

});

250+251+

const { stdout } = await execFileAsync(

252+

process.execPath,

253+

[generated.wrapperPath, "--permission-mode", "bypass"],

254+

{

255+

cwd: root,

256+

},

257+

);

258+

const launched = JSON.parse(stdout.trim()) as { argv?: unknown; codexHome?: unknown };

259+

expect(launched.argv).toEqual(["--permission-mode", "bypass"]);

260+

expect(launched.codexHome).toBeNull();

261+

});

262+167263

it("does not copy source Codex auth", async () => {

168264

const root = await makeTempDir();

169265

const sourceCodexHome = path.join(root, "source-codex");

@@ -208,7 +304,7 @@ describe("prepareAcpxCodexAuthConfig", () => {

208304

).rejects.toMatchObject({ code: "ENOENT" });

209305

});

210306211-

it("wraps an explicitly configured Codex agent command with isolated CODEX_HOME", async () => {

307+

it("normalizes an explicitly configured Codex ACP command to the local wrapper", async () => {

212308

const root = await makeTempDir();

213309

const sourceCodexHome = path.join(root, "source-codex");

214310

const stateDir = path.join(root, "state");

@@ -237,8 +333,9 @@ describe("prepareAcpxCodexAuthConfig", () => {

237333

});

238334239335

expectCodexWrapperCommand(resolved.agents.codex, generated.wrapperPath);

240-

expect(resolved.agents.codex).toContain("npx @zed-industries/codex-acp@0.12.0");

241-

expect(resolved.agents.codex).toContain("-c 'model=\"gpt-5.4\"'");

336+

expect(resolved.agents.codex).not.toContain("npx @zed-industries/codex-acp@0.12.0");

337+

expect(resolved.agents.codex).toContain(quoteArg("-c"));

338+

expect(resolved.agents.codex).toContain(quoteArg('model="gpt-5.4"'));

242339

const isolatedConfig = await fs.readFile(generated.configPath, "utf8");

243340

expect(isolatedConfig).not.toContain("notify");

244341

expect(isolatedConfig).not.toContain("SkyComputerUseClient");

@@ -247,4 +344,79 @@ describe("prepareAcpxCodexAuthConfig", () => {

247344

expect(wrapper).toContain("CODEX_HOME: codexHome");

248345

expect(wrapper).not.toContain(sourceCodexHome);

249346

});

347+348+

it("normalizes an explicitly configured Claude ACP npx command to the local wrapper", async () => {

349+

const root = await makeTempDir();

350+

const stateDir = path.join(root, "state");

351+

const generated = generatedClaudePaths(stateDir);

352+

const pluginConfig = resolveAcpxPluginConfig({

353+

rawConfig: {

354+

agents: {

355+

claude: {

356+

command: "npx -y @agentclientprotocol/claude-agent-acp@0.31.0 --permission-mode bypass",

357+

},

358+

},

359+

},

360+

workspaceDir: root,

361+

});

362+363+

const resolved = await prepareAcpxCodexAuthConfig({

364+

pluginConfig,

365+

stateDir,

366+

resolveInstalledClaudeAcpBinPath: async () => path.join(root, "claude-agent-acp.js"),

367+

});

368+369+

expectClaudeWrapperCommand(resolved.agents.claude, generated.wrapperPath);

370+

expect(resolved.agents.claude).not.toContain("npx -y @agentclientprotocol/claude-agent-acp");

371+

expect(resolved.agents.claude).toContain("--permission-mode");

372+

expect(resolved.agents.claude).toContain("bypass");

373+

});

374+375+

it("leaves a custom Claude agent command alone", async () => {

376+

const root = await makeTempDir();

377+

const stateDir = path.join(root, "state");

378+

const pluginConfig = resolveAcpxPluginConfig({

379+

rawConfig: {

380+

agents: {

381+

claude: {

382+

command: "node ./custom-claude-wrapper.mjs --flag",

383+

},

384+

},

385+

},

386+

workspaceDir: root,

387+

});

388+389+

const resolved = await prepareAcpxCodexAuthConfig({

390+

pluginConfig,

391+

stateDir,

392+

resolveInstalledClaudeAcpBinPath: async () => path.join(root, "claude-agent-acp.js"),

393+

});

394+395+

expect(resolved.agents.claude).toBe("node ./custom-claude-wrapper.mjs --flag");

396+

});

397+398+

it("does not normalize custom Claude commands that only mention the package name", async () => {

399+

const root = await makeTempDir();

400+

const stateDir = path.join(root, "state");

401+

const command =

402+

"node ./custom-claude-wrapper.mjs @agentclientprotocol/claude-agent-acp@0.31.0 --flag";

403+

const pluginConfig = resolveAcpxPluginConfig({

404+

rawConfig: {

405+

agents: {

406+

claude: {

407+

command,

408+

},

409+

},

410+

},

411+

workspaceDir: root,

412+

});

413+414+

const resolved = await prepareAcpxCodexAuthConfig({

415+

pluginConfig,

416+

stateDir,

417+

resolveInstalledClaudeAcpBinPath: async () => path.join(root, "claude-agent-acp.js"),

418+

});

419+420+

expect(resolved.agents.claude).toBe(command);

421+

});

250422

});